3048 Commits

Author	SHA1	Message	Date
Leonardo Alt	508aae8a67	Disable state mutability warning for functions with empty body	2018-12-12 14:43:44 +01:00
Leonardo Alt	53537864a2	Disable unused var warning for functions with empty body	2018-12-12 14:43:44 +01:00
Daniel Kirchner	788612d2ef	Refactoring of the ControlFlowGraph and use for detecting all uninitialized storage accesses.	2018-12-12 04:20:53 +01:00
chriseth	fb3a0ac1c7	Codegen for object access.	2018-12-11 19:24:44 +01:00
chriseth	8d49e53995	Provide Dialect to EVMCodeTransform.	2018-12-11 19:24:31 +01:00
chriseth	9f86ede32d	Merge pull request #5454 from ethereum/smt_math_functions ... [SMTChecker] Abstract math functions	2018-12-11 18:35:10 +01:00
chriseth	b5deca0383	Merge pull request #4779 from ethereum/optimise-string-literals ... Decide better in storing string literals as data	2018-12-11 17:50:14 +01:00
Leonardo Alt	08737e43dc	[SMTChecker] Use SymbolicFunctionVariable for uninterpreted functions	2018-12-11 11:28:25 +01:00
chriseth	baaefb4b42	Merge pull request #5619 from ethereum/cleanup-abc ... Some code cleanup	2018-12-10 19:22:02 +01:00
Mathias Baumann	2f6dc2e773	Replace push_back with emplace_back where it makes sense	2018-12-10 19:02:39 +01:00
Yi Huang	81f703427e	Add tests for implcit conversions from literals to fixed-point numbers.	2018-12-10 17:31:20 +01:00
chriseth	53f531ecb0	Set codecopy limit for data to 32 bytes.	2018-12-10 17:11:48 +01:00
chriseth	871ea22bb9	Merge pull request #5008 from liangdzou/yul_stack_reuse ... Reuse stack slots in Yul codegen	2018-12-10 16:14:33 +01:00
liangdzou	362648a450	Reuse stack slots in Yul to EVM code generation.	2018-12-10 14:28:56 +01:00
Leonardo Alt	de46bb2c42	[SMTChecker] Introduce SymbolicFunctionVariable	2018-12-10 11:34:29 +01:00
Erik Kundt	e2395a3dcf	Adds more detailed type errors and tests.	2018-12-07 12:35:35 +01:00
Erik Kundt	b2afb8cdda	Adds an additional message to failing type conversions.	2018-12-07 11:55:53 +01:00
chriseth	6a9e8a6fe3	Merge pull request #4936 from ethereum/binSelect ... Binary search for dispatch.	2018-12-07 00:55:09 +01:00
chriseth	4b2a64306a	Merge pull request #5587 from ethereum/yulCodeBuiltins ... Builtin functions to access Yul objects.	2018-12-06 16:49:52 +01:00
chriseth	3fc118ba21	Analyze and compile sub-objects.	2018-12-06 14:32:04 +01:00
chriseth	f6ed29b88b	Extend abstract assembly to be able to handle sub-objects.	2018-12-06 14:32:04 +01:00
chriseth	4721cf332f	Expose EthAssemblyAdapter.	2018-12-06 14:32:04 +01:00
chriseth	0e8841005c	Merge pull request #5554 from ethereum/cp-SourceReferenceFormatter-refactor ... [2/3] Refactor SourceReferenceFormatter (split-out data extraction & make use of new SourceLocation knowledge)	2018-12-06 14:01:39 +01:00
Christian Parpart	073b03d90c	liblangutil: refactor SourceReferenceFormatter, splitting out retrieval and making use of new SourceLocation's CharStream knowledge	2018-12-06 14:01:01 +01:00
chriseth	7f39c3e522	Binary search for dispatch.	2018-12-06 13:07:14 +01:00
chriseth	5fde279d2a	Merge pull request #5514 from corollari/develop ... Remove unary + from the type system	2018-12-06 10:27:09 +01:00
Albert	df08d79623	Fix #5470 ... Remove unary + from the type system	2018-12-06 01:54:04 +01:00
chriseth	3a378eae1a	Restrict toHex to bytes.	2018-12-05 22:37:05 +01:00
Kevin Kelley	fb6fd1b3c2	add a 'readable' format for large hex values	2018-12-05 22:15:02 +01:00
chriseth	63d67c7153	Merge pull request #5591 from ethereum/smt_simplify_sort ... [SMTChecker] Simplify symbolic variables	2018-12-05 17:28:45 +01:00
Erik Kundt	e3accc6aa6	Simplifies Result<T> and prevents undefined behaviour.	2018-12-05 10:33:34 +01:00
Erik Kundt	05e74d096e	Introduces Result<T> for operator and implicit conversion type checks.	2018-12-05 10:33:34 +01:00
Leonardo Alt	b9f424e373	[SMTChecker] Simplify symbolic variables	2018-12-05 09:56:52 +01:00
chriseth	6efe2a5266	Merge pull request #5390 from ethereum/smt_one_loop ... [SMTChecker] Unroll loops once	2018-12-05 09:23:19 +01:00
chriseth	c8e201e520	Provide Yul Object builtins.	2018-12-04 15:40:50 +01:00
chriseth	7ee1ddc172	Switch namespaces.	2018-12-04 15:36:03 +01:00
chriseth	0b1125281a	Remove some includes.	2018-12-04 15:31:00 +01:00
chriseth	3ebb78a886	Adjust include paths.	2018-12-04 15:20:29 +01:00
chriseth	0ec7a0e72c	Move AsmCodeGen.	2018-12-04 15:20:23 +01:00
Leonardo Alt	8069bb61da	[SMTChecker] Loops are unrolled once	2018-12-04 12:35:19 +01:00
chriseth	99db4e3ff4	Introduce the concept of builtin functions.	2018-12-04 12:06:33 +01:00
Anurag Dashputre	82f5763e7a	Fix internal compiler error for unimplemented base contract function.	2018-12-03 12:25:31 +01:00
chriseth	4b98946e5a	Merge pull request #5341 from ethereum/optimizeAssemblyCommandline ... Apply the optimize commandline parameter to assembly mode.	2018-12-03 11:52:48 +01:00
chriseth	5897b14d63	Merge pull request #5568 from ethereum/smt_remove_unary_plus ... [SMTChecker] Remove unary plus operator	2018-12-03 11:19:34 +01:00
chriseth	3f613a44ec	Merge pull request #5557 from ethereum/fixInterfaceImplementedByPublicStateVariable ... Public state variables are implementing external functions.	2018-12-03 10:46:44 +01:00
chriseth	0668a9ecfb	Public state variables are implementing external functions.	2018-12-03 10:46:03 +01:00
Leonardo Alt	6d41ffb4a5	[SMTChecker] Remove unary plus operator	2018-12-03 10:35:38 +01:00
chriseth	aaeb74f592	Merge pull request #5537 from ethereum/cp-SourceLocation-related-refactoring ... [1/3] SourceLocation related refactoring.	2018-11-30 23:45:31 +01:00
chriseth	6c44c5f0c9	Apply the optimize commandline parameter to assembly mode.	2018-11-30 23:39:05 +01:00
Christian Parpart	435f7b3b72	liblangutil: Scanner: remove superfluous sourceName field (it's in CharStream already) ... Also, ParserBase::sourceName() was dead code. Eliminating it should increase test coverage (how sneaky) :-)	2018-11-30 17:07:17 +01:00
Christian Parpart	c48a5264be	liblangutil: SourceLocation: adds (shared) pointer to underlying CharStream source, eliminating sourceName ... Also, adapted affecting code to those changes.	2018-11-30 17:07:12 +01:00
chriseth	cc00d8172b	Merge pull request #5528 from ethereum/smt_sorts_virtual ... [SMTChecker] Make smt::Sort::operator== virtual	2018-11-30 16:48:46 +01:00
chriseth	33d6a24c47	Move library related checks.	2018-11-30 16:30:20 +01:00
chriseth	4f992298c6	Move hash collisions checks.	2018-11-30 16:30:19 +01:00
chriseth	6d1644e55c	Move external type clash check.	2018-11-30 16:30:19 +01:00
chriseth	4f4f623273	Move fallback function checks.	2018-11-30 16:30:19 +01:00
chriseth	2a85152463	Move constructor checks.	2018-11-30 16:30:19 +01:00
chriseth	b610be4882	Rename functions.	2018-11-30 16:30:19 +01:00
chriseth	d1cc731843	No need to visit structs early.	2018-11-30 16:30:19 +01:00
chriseth	2c2c976697	Move base constructor argument checks.	2018-11-30 16:30:19 +01:00
chriseth	57a62429c9	Move abstract function check.	2018-11-30 16:30:19 +01:00
chriseth	89cf6a5a38	Move override checks.	2018-11-30 16:30:19 +01:00
chriseth	d054a3b85d	Move duplication checks.	2018-11-30 16:30:19 +01:00
chriseth	0bd9db480f	Add skeleton for contract level checker.	2018-11-30 16:30:19 +01:00
Leonardo Alt	2f6de12e8c	[SMTChecker] Make smt::Sort::operator== virtual	2018-11-30 10:41:15 +01:00
chriseth	d6d41b2bc7	Merge pull request #5548 from ethereum/fixMemberAccess ... Fix bug related to state variables of function type accessed via base contract.	2018-11-30 09:26:08 +01:00
chriseth	c445e7dfa4	Disallow inline arrays of mapping type.	2018-11-29 19:45:06 +01:00
chriseth	73a64da041	Fix bug related to state variables of function type accessed via base contract.	2018-11-29 19:30:27 +01:00
chriseth	124a8def84	Merge pull request #5543 from ethereum/fixSortMOve ... Fix move bug.	2018-11-29 16:13:24 +01:00
chriseth	9e9250c961	Fix move bug.	2018-11-29 15:32:38 +01:00
Leonardo Alt	67bbcefe6c	Report deprecation error on functions sha3 and suicide also without call.	2018-11-29 14:29:13 +01:00
Christian Parpart	22eff22492	liblangutil: extends CharStream to know about the respective (file-)name (and adapt codebase to it)	2018-11-29 12:45:27 +01:00
chriseth	f6d013237d	Merge pull request #5538 from hydai/static_uint256 ... Replace IntegerType(256) with static function IntegerType::uint256()	2018-11-29 11:17:33 +01:00
Leonardo Alt	1d47919c0c	Fix ICE when function type struct parameter has field of non-existent type	2018-11-29 10:38:47 +01:00
hydai	9326adc3db	Replace IntegerType(256) with static function IntegerType::uint256()	2018-11-29 17:07:18 +08:00
chriseth	b4086ac870	Merge pull request #5526 from ethereum/fixGetterNewCoder ... Fix: Disallow structs in getters for old encoder.	2018-11-28 17:05:52 +01:00
chriseth	46f3da0b87	Properly check getter types to be old-abi-coder-compatible.	2018-11-28 14:08:25 +01:00
chriseth	5c0331a058	Merge pull request #5525 from ethereum/obsoleteComment ... Remove obsolete comment.	2018-11-28 12:23:12 +01:00
chriseth	4fa47322f9	Remove obsolete comment.	2018-11-28 11:49:00 +01:00
chriseth	728119bb11	Use yul parser in assembly stack.	2018-11-27 15:59:57 +01:00
chriseth	e016cb99e6	Yul objects.	2018-11-27 15:59:57 +01:00
chriseth	240ad0e34e	Merge pull request #5382 from ethereum/libraryMappingPublic ... Allow mapping arguments for public and external library functions.	2018-11-26 19:47:32 +01:00
chriseth	4d7799eed4	Properly disallow different return types for interface overloads with different visibilities.	2018-11-26 16:51:28 +01:00
chriseth	f937896727	Merge pull request #5445 from ethereum/publicExternalOverwrite ... Allow overwriting external functions (with ``calldata`` arguments) with public functions (with ``memory`` arguments)	2018-11-26 16:50:40 +01:00
Daniel Kirchner	30e6f8d3fb	Allow mapping arguments for public and external library functions.	2018-11-26 16:31:46 +01:00
chriseth	f6d8810103	Merge pull request #5504 from ethereum/smt_fix_emscripten ... [SMTChecker] Fix crash when SMTLib2Interface reports unknow for constant checks	2018-11-26 16:14:02 +01:00
chriseth	764d618c44	Merge pull request #5404 from ethereum/jumpFixes ... Annotate jump from calldata decode to function as "jump in".	2018-11-26 16:08:04 +01:00
chriseth	a46d5c6580	Fix merge problem in CMake files.	2018-11-26 14:50:04 +01:00
chriseth	d950905a28	Merge pull request #5493 from ethereum/cmake-no-globbing ... [WIP] CMake: Explicitly state which files to compile instead of relying on globbing	2018-11-26 14:45:35 +01:00
Christian Parpart	cdd8c72c9d	CMake: Explicitly state which files to compile instead of relying on globbing. ... Also remove header file lists, as there is no need to add them to add_library() or add_executable(), which should lower maintenance of the cmake files.	2018-11-26 14:39:24 +01:00
chriseth	5ec634939e	Use asCallableFunction for definition clashes in the same contract.	2018-11-26 14:30:32 +01:00
chriseth	36a369d077	Use asCallableFunction for external interface clash check.	2018-11-26 14:30:32 +01:00
chriseth	939365a1d5	Use callable types for override check.	2018-11-26 14:30:32 +01:00
chriseth	9a4968ba1d	Use asCallableFunction in override check (part 1).	2018-11-26 14:30:32 +01:00
chriseth	7921e5f0b9	Merge pull request #5486 from ethereum/allowExternalPublicOverride ... Allow external public override	2018-11-26 14:26:55 +01:00
chriseth	9ac7c748f8	Merge pull request #5494 from ethereum/scanner-error-handling ... Improved Scanner error diagnostics.	2018-11-26 14:17:08 +01:00
Leonardo Alt	aaaa92012c	[SMTChecker] Unknown answer for constant condition check should not do anything	2018-11-26 12:54:02 +01:00
chriseth	0b474d5299	Merge pull request #5497 from ethereum/langutil-SourceReferenceFormatter ... Moving SourceReferenceFormatter into langutil namespace.	2018-11-26 12:44:25 +01:00
chriseth	0f0e466d36	Allow visibility change from external to public.	2018-11-26 12:41:26 +01:00
chriseth	bc137c2eeb	Merge pull request #5485 from ethereum/refactorCallableFunction ... Refactor callable function	2018-11-26 12:34:43 +01:00
chriseth	0e08fb7469	Use "in" tag for jumps from unpacker to function.	2018-11-26 11:02:58 +01:00
Christian Parpart	e4106bd06e	Change scanner error diagnostics to be non-intrusive to the token API. ... This also implicitly eliminates the magic-token Token::IllegalHex, and streamlines error diagnostics over a custom enum class.	2018-11-24 12:40:51 +01:00
Christian Parpart	aeb66905de	Moving SourceReferenceFormatter into langutil namespace.	2018-11-24 12:33:36 +01:00
Lazaridis	e454737a3c	adapt to latest code changes	2018-11-23 17:27:52 +01:00
chriseth	9a94e503da	Merge pull request #5491 from ethereum/libyul-as-library ... Libyul as static library (version 3 ;( )	2018-11-23 17:01:18 +01:00
Christian Parpart	ec47c8946b	Isolating libyul library API into its own namespace yul.	2018-11-23 14:29:00 +01:00
Christian Parpart	3734f40d31	CMake: Isolate libyul into its own static library	2018-11-23 12:37:37 +01:00
Christian Parpart	713d94476e	Reorder some include files and group <libyul/>'s together (as much as possible)	2018-11-23 12:37:19 +01:00
Christian Parpart	0f4ed52a71	Rewrite header paths to adapt to recent git mv of libsolidity/inlineasm to libyul	2018-11-23 11:18:57 +01:00
Christian Parpart	10e6d2897d	Moving files from libsolidity/inlineasm/*.{cpp,h} to libyul/.	2018-11-23 11:16:52 +01:00
Leonardo Alt	6251a289dd	Testing with smtlib2 interface always there	2018-11-23 09:43:49 +01:00
Leonardo Alt	dee0c4ded8	Error message stays in the SMTChecker	2018-11-23 09:43:49 +01:00
Leonardo Alt	f3c2309c73	Display better error message in SMTLib2	2018-11-23 09:43:49 +01:00
Leonardo Alt	f44be616c9	Renaming json fields smtlib2queries and smtlib2responses	2018-11-23 09:43:49 +01:00
chriseth	54bed454f6	Rename function and warn if responses are supplied for Z3.	2018-11-23 09:43:49 +01:00
chriseth	bb10be789c	Inject SMTLIB2 queries and responses via standard-json-io.	2018-11-23 09:43:49 +01:00
chriseth	d686807153	Style	2018-11-22 21:13:02 +01:00
chriseth	ecd059cb92	Merge pull request #5451 from ethereum/bound_function_tests ... Add assert and tests for bound functions	2018-11-22 18:23:46 +01:00
chriseth	a781bda595	Correct style.	2018-11-22 17:15:25 +01:00
Leonardo Alt	ec84a7dc9b	[SMTChecker] Refactor setZeroValue and setUnknownValue	2018-11-22 16:42:51 +01:00
chriseth	62e801ed70	Use callable function for virtual resolution.	2018-11-22 15:48:12 +01:00
chriseth	92ba8a95f6	Make asCallableFunction to never fail and assert abount parameter size if bound instead.	2018-11-22 15:47:45 +01:00
chriseth	9e964852cc	Rename 'asMemberFunction' to widen its purpose.	2018-11-22 15:24:45 +01:00
Leonardo Alt	06189ae57f	Add assert and tests for bound functions	2018-11-22 14:41:39 +01:00
Leonardo Alt	20accf1a90	[SMTChecker] Add ArraySort and array operations	2018-11-22 14:04:20 +01:00
Leonardo Alt	13a142b039	[SMTChecker] Add FunctionSort and refactors the solver interface to create variables	2018-11-22 10:04:04 +01:00
Christian Parpart	d67322a186	Introduce namespace langutil in liblangutil directory. ... Also: - Use {}-style list initialisation for SourceLocation construction - Introduce new system includes - Changes the API of the Scanner to take source as value (with move) as opposed to as a reference	2018-11-21 19:13:44 +00:00
Christian Parpart	80371e2d25	Ensure liblangutil is compiled and linked as its own static library.	2018-11-21 18:58:36 +00:00
Christian Parpart	87821c53c3	Isolating files shared between Yul- and Solidity language frontend.	2018-11-21 18:58:12 +00:00
Alex Beregszaszi	2c6e1888eb	Merge pull request #5466 from ethereum/smt_refactor_sort_patch1 ... [SMTChecker] Refactor smt::Sort and its usage	2018-11-21 15:17:58 +00:00
Leonardo Alt	01ce43e51b	[SMTChecker] Refactor smt::Sort and its usage	2018-11-21 15:46:47 +01:00
mordax	ea8b7d803e	Removing redundant virtual from override function declaration ... Remove trailing whitespace Remove changelog change	2018-11-21 14:37:32 +00:00
Leonardo Alt	06c3f0953a	[SMTChecker] Support bound function calls	2018-11-19 15:29:00 +01:00
Leonardo Alt	70bb0eaf95	[SMTChecker] Implement uninterpreted functions and use it for blockhash()	2018-11-15 09:12:42 +01:00
chriseth	727e3f24bc	Do not perform cleanup on unsigned integers when loading from calldata.	2018-11-14 20:52:30 +00:00
Alex Beregszaszi	d60cab1983	Add CompilerStack state assertions in internal methods	2018-11-14 10:47:26 +00:00
Alex Beregszaszi	be70703f82	Move lastContractName closer to contractNames	2018-11-14 10:29:16 +00:00
Alex Beregszaszi	5778af07a3	Do not crash on filesystemFriendlyName if no contracts were compiled	2018-11-14 10:29:16 +00:00
Leonardo Alt	9a4fd946c3	Add Scanner function that prints source based on SourceLocation	2018-11-13 13:49:29 +01:00
chriseth	7e0041cf22	Merge pull request #5406 from ethereum/uninitializedStorageUnimplemented ... Ignore unimplemented functions for detecting uninitialized storage returns.	2018-11-13 13:22:59 +01:00
Daniel Kirchner	b5e9d849ef	Ignore unimplemented functions for storage returns.	2018-11-13 12:18:22 +01:00
Daniel Kirchner	74557ceb0e	Deterministic YulStringRepository using string hashes.	2018-11-12 23:43:16 +01:00
chriseth	2cc304fd3f	Fix for style.	2018-11-12 09:15:22 +01:00
chriseth	af65bac737	Remove trailing whitespace.	2018-11-12 09:15:22 +01:00
Kristofer Peterson	f927da9182	Refactor of bool TypeChecker::visit(FunctionCall const& _functionCall). ... Visit method now cleanly determines if node represents a function call, struct construction or type conversion. Type checking, validation and error message logic is moved to separate methods.	2018-11-09 16:35:54 +00:00
chriseth	0f2ba3522f	Reset yul string repository.	2018-11-09 15:40:36 +01:00
chriseth	6bbedab383	Merge pull request #5265 from ethereum/cleanupsha3 ... Simplify sha3.	2018-11-09 15:39:57 +01:00
chriseth	b801e61611	Merge pull request #5365 from ethereum/improveNameDispenser ... [Yul] Use single counter for name dispenser for performance reasons.	2018-11-08 12:24:21 +01:00
Daniel Kirchner	fce1c3a9e7	Merge pull request #5370 from ethereum/fixWindows ... Fix windows build.	2018-11-08 12:06:32 +01:00
chriseth	1f4ecff446	Fix windows build.	2018-11-08 11:30:58 +01:00
chriseth	84e8a782d6	Merge pull request #5351 from ethereum/functionTypeConversion ... Relax type equality requirement of function types during conversion in code generation.	2018-11-08 11:29:55 +01:00
chriseth	cc2de07bc6	Merge pull request #5348 from ethereum/boostRationalNegativeDenominatorFix ... Fix negative denominator in ``boost::rational`` during exponentiation.	2018-11-08 11:25:30 +01:00
Daniel Kirchner	b16a3644fe	Function type conversion test cases.	2018-11-08 10:51:51 +01:00
chriseth	845899e305	Use single counter for name dispenser for performance reasons.	2018-11-07 23:09:33 +01:00
chriseth	674e17c2a8	Performance: Replace string by special single-copy YulString class.	2018-11-07 19:30:27 +01:00
Christian Parpart	ab0de38f16	Eliminate byte-typedef and use uint8_t in all their places instead. ... This change is made to (easily) be forward compatible with future C++ standards, in order to allow compiling the code with newer standards at some point in the future. * Removed the `using byte = uint8_t;` line from Common.h * Mechanically change all uses of `byte` to `uint8_t`. Tested with GCC 7.3 in C++11/14/17 modes :-)	2018-11-07 12:17:57 +01:00
Daniel Kirchner	a3e37a9d5a	Relax identity requirement of function type conversions during code generation.	2018-11-06 13:22:33 +01:00
Daniel Kirchner	e036133d1b	Fix negative denominator in `boost::rational` during exponentiation.	2018-11-06 10:52:10 +01:00
Erik Kundt	1d8e9af407	Fixes crash while encoding too large arrays.	2018-10-30 15:14:57 +01:00
chriseth	4d82831b06	Merge pull request #5316 from lazaridiscom/4891-memory-store-asserts ... refine memory-store assertions, closes #4891	2018-10-28 20:50:41 +01:00
Lazaridis	cab8dea7fe	refine memory-store assertions, closes #4891	2018-10-27 00:04:54 +03:00
chriseth	39687cf110	Remove unused AST utils.	2018-10-25 14:02:09 +02:00
chriseth	c36a3bd683	Merge pull request #5283 from ethereum/smt_fixed_bytes ... [SMTChecker] Support FixedBytes	2018-10-25 13:01:01 +02:00
chriseth	f714b0dd7c	Merge pull request #5242 from ethereum/someChecks ... Some well-formedness checks for the Yul AST.	2018-10-25 12:44:28 +02:00
Leonardo Alt	d8cbf321da	Grouping of symbolic variables in the same file and support to FixedBytes	2018-10-25 09:30:48 +02:00
chriseth	01566c2e1a	Merge pull request #5272 from ethereum/smt_special_vars ... [SMTChecker] Support msg.*, tx.*, block.*, gasleft and blockhash	2018-10-24 14:34:17 +02:00
Leonardo Alt	e2cf5f6ed9	Add gasleft constraint and use full member access name	2018-10-22 18:19:11 +02:00
Christian Parpart	f112377dd4	Refactor solidity::Token into an enum class with TokenTraits helper namespace	2018-10-22 17:00:51 +02:00
chriseth	19be6cd818	Some well-formedness checks for the Yul AST.	2018-10-22 15:52:26 +02:00
Leonardo Alt	b46b827c30	[SMTChecker] Support msg.*, tx.*, block.*, gasleft and blockhash	2018-10-19 15:52:16 +02:00
chriseth	c13b5280c1	Merge pull request #5256 from ethereum/lvalueCleanup ... Lvalue cleanup	2018-10-19 11:20:12 +02:00
chriseth	fed7a7d61a	Merge pull request #5257 from ethereum/assertAboutRemoved ... Assert about some removed language concepts in the code generator.	2018-10-19 11:04:29 +02:00
chriseth	e78b95d9d4	Renamed SHA3.{h,cpp} files.	2018-10-18 14:31:36 +02:00
chriseth	97d01d9b47	Assert about some removed language concepts in the code generator.	2018-10-17 22:26:40 +02:00
chriseth	c14dfeb8c5	Removed unreachable cases in LValue.cpp.	2018-10-17 22:17:33 +02:00
Leonardo Alt	070471d8d4	Fix possibly effectless map emplace	2018-10-17 19:00:38 +02:00
Leonardo Alt	c92d3b537d	[SMTChecker] Refactor expressions such that they also use SymbolicVariable	2018-10-17 18:36:24 +02:00
Leonardo	3db1ce0e14	Merge pull request #5235 from ethereum/smt_refactor_types ... [SMTChecker] Refactoring types	2018-10-17 18:35:48 +02:00
chriseth	9d00f710bc	Merge pull request #5224 from bshastry/compilerwarn-fix ... Fix compiler warning	2018-10-17 17:23:22 +02:00
Bhargava Shastry	67fd3ca4a7	Retained move/copy semantics; removed const qualifier from Expression's members name (of type std::string) and arguments (of type std::vector<Expression>)	2018-10-17 16:46:18 +02:00
Bhargava Shastry	546b08c158	Fix compiler warning: clang-8 warns of explicitly-defined op implicitly deleted for Expression object's copy and move constructors	2018-10-17 16:42:51 +02:00
Leonardo Alt	afe83cc28b	Refactor SymbolicAddressVariable and SymbolicVariable allocation	2018-10-17 15:58:13 +02:00
Leonardo Alt	aa23326e06	Consistent renaming of 'counters' and 'sequence' to 'index'	2018-10-17 15:58:13 +02:00
Leonardo Alt	ec39fdcb3c	[SMTChecker] Refactoring types	2018-10-17 15:58:13 +02:00
chriseth	5e01d767d0	Prevent externally used functions from being removed.	2018-10-17 14:12:10 +02:00
chriseth	2384947521	Merge pull request #5209 from ethereum/smt_ssa_refactor ... [SMTChecker] Refactor SSAVariable such that it only uses Type and not Declaration	2018-10-15 16:49:47 +02:00
Leonardo Alt	e4851cf59e	[SMTChecker] Inline calls to internal functions	2018-10-15 15:11:21 +02:00
Leonardo Alt	4a4620ac95	Refactor SSAVariable such that it only uses Type and not Declaration	2018-10-15 14:20:54 +02:00
chriseth	0778fb2dfc	Merge pull request #5208 from mestorlx/bug4156 ... [WIP] Bad identifier suggestion in certain cases	2018-10-15 13:03:49 +02:00
Christian Parpart	1304361b9c	Renaming namespace dev::julia to dev::yul.	2018-10-15 11:58:51 +02:00
Christian Parpart	9a4bec7e47	Renaming libjulia to libyul	2018-10-15 11:52:35 +02:00
Christian Parpart	6d815a142f	Fixes invalid function calls to literals inside tuple assignment's LHS.	2018-10-15 10:35:11 +02:00
mestorlx	1ce9566e50	Updated MAXIMUM_STRING_DISTANCE to non static maximumStringDistance taking into account length of the identifier	2018-10-13 09:54:07 -03:00
chriseth	2feaacba9d	Merge pull request #5195 from ethereum/unsigned-array-index ... Do not crash on non-unsigned array index	2018-10-10 20:56:25 +02:00
Erik Kundt	763ae30023	Fixes crash on non-unsigned array index.	2018-10-10 19:49:25 +02:00
Martin Diz	ef25454a04	Improved error message for lookup in function types.	2018-10-10 11:53:53 -03:00
chriseth	b5399a7aa0	Merge pull request #5132 from ethereum/genericVisitor ... Generic visitor.	2018-10-10 16:01:20 +02:00
chriseth	06200b4b64	Merge pull request #5180 from ethereum/cpp-cleanup ... Some C++ cleanup	2018-10-10 11:43:42 +02:00
Alex Beregszaszi	6c3d12d85b	Do not require ctype/stdio if not needed	2018-10-09 19:06:22 +01:00
Alex Beregszaszi	e732c49c2f	Change find to use a single character	2018-10-09 18:06:25 +01:00
Christian Parpart	4d5216c2e0	Fixes large rational number literals being wrongly interpreted. ... Fixes #5052.	2018-10-09 14:36:49 +02:00
chriseth	3f216bac5e	Generic visitor.	2018-10-09 14:27:21 +02:00
chriseth	547b26d464	Merge pull request #5124 from lazaridiscom/1802-hex-error-reporting ... use Token type for hex error, draft re #1802	2018-10-09 14:17:11 +02:00
Lazaridis	4bcd89105c	provide general hex-literal error message, fixes #1802 ... dummy	2018-10-09 06:51:19 +03:00
Alex Beregszaszi	fa0ce6a7e7	Use empty() instead of size() == 0	2018-10-09 04:29:37 +01:00
chriseth	6a0b7759ba	Fix pragma error suggestion.	2018-10-09 03:15:53 +02:00
chriseth	7ff9a27979	Merge pull request #4734 from ethereum/astUpdate ... JSON AST: replace ``isConstructor`` by ``kind`` which also supports fallbacks	2018-10-08 21:47:27 +02:00
chriseth	d76bfcd935	Fix typos.	2018-10-04 13:28:16 +02:00
Christian Parpart	9fb835b710	Fixes #5051 (introduced in #4684), effectively allowing underscores in address literals.	2018-10-02 15:37:15 +02:00
chriseth	db4f780283	Merge pull request #4962 from anurag-git/anurag_issue_3667-1 ... Removed default case from "ExpressionCompiler::visit(FunctionCall...)".	2018-10-01 13:24:26 +02:00
chriseth	5ae32b24a6	Merge pull request #5113 from ethereum/compilerstack-datagas ... Use GasEstimator::dataGas in CompilerStack	2018-10-01 13:20:38 +02:00
Anurag Dashputre	3321000f67	Removing extra default cases to force compile time error, instead of runtime.	2018-09-30 12:40:38 +05:30
Alex Beregszaszi	c4b5101b9d	Merge pull request #4676 from jwasinger/extcodehash ... Add support for EXTCODEHASH	2018-09-28 00:04:40 +01:00
Alex Beregszaszi	d71cc66dde	Use GasEstimator::dataGas in CompilerStack	2018-09-28 00:03:35 +01:00
chriseth	f81c6e6d16	Merge pull request #5099 from ethereum/standard-json-optimiser ... Be more strict about values in the optimizer block in StandardJSON	2018-09-26 22:31:27 +02:00
Alex Beregszaszi	384a65f660	Be more strict about values in the optimizer block in StandardJSON	2018-09-26 16:51:08 +01:00
Jared Wasinger	c6bd2979b1	Add assembly support for EXTCODEHASH (EIP-1052)	2018-09-26 16:11:02 +01:00
Alex Beregszaszi	d64be90497	Add PathGasMeter.estimateMax helper	2018-09-26 14:25:40 +01:00
chriseth	13cd7c3fed	Merge pull request #5061 from ethereum/fixedSizeArrayLength ... Disallow fixed-size arrays with zero length	2018-09-26 14:55:07 +02:00
chriseth	46f630c5a6	Merge pull request #5092 from ethereum/create2-evmversion ... CREATE2 is part of Constantinople now	2018-09-26 14:53:44 +02:00
Alex Beregszaszi	00b1b96eb4	Use better assertion messages for RationalNumberType::literalValue	2018-09-26 13:05:58 +01:00
Erik Kundt	466e8f56e6	Removes unnecessary check of array type.	2018-09-26 12:46:08 +02:00
Alex Beregszaszi	8cfc6c98d6	CREATE2 is part of Constantinople now ... Also add hasCreate2 to EVMVersion	2018-09-26 01:58:10 +01:00
Nicolás Venturo	f8d43a4da5	Removed extra whitespace.	2018-09-25 14:40:39 -03:00
chriseth	64a6888aba	Merge pull request #5063 from ethereum/standard-json-bug ... Fix typo in parsing/writing JSON error in StandardCompiler	2018-09-24 15:01:38 +02:00
chriseth	32112d6480	Merge pull request #5041 from liangdzou/fix_typo_in_doc ... fix typo in docs and comments	2018-09-24 13:52:33 +02:00
Khan M Rashedun-Naby	376ce07915	Use 'switch' instead of 'if..else if'	2018-09-24 08:31:44 +06:00
Erik Kundt	e6d87e54c8	Simplifies zero-length check for fixed-size arrays.	2018-09-22 03:07:12 +02:00
Erik Kundt	d821cbdff5	Moves length check to reference resolver.	2018-09-22 00:25:52 +02:00
Alex Beregszaszi	abfd283af7	Fix typo in parsing/writing JSON error in StandardCompiler	2018-09-21 22:43:57 +01:00
Erik Kundt	ff5be17990	Disallows fixed-size multidim. arrays with zero-length.	2018-09-21 18:44:56 +02:00
Alex Beregszaszi	5dd3ee2d96	Merge pull request #5050 from ethereum/standard-json-crashes ... Add proper error reporting when invalid settings are provided in StandardJSON	2018-09-21 15:48:05 +01:00
Alex Beregszaszi	8f96fe698d	Merge pull request #5049 from ethereum/structtype-assert-annotation ... Add assertion for annotated type in Structtype::canBeUsedExternally	2018-09-21 15:02:26 +01:00
Alex Beregszaszi	a515173900	Add proper error reporting when invalid settings are provided in StandardJSON	2018-09-21 14:53:24 +01:00
Alex Beregszaszi	69ff61d149	Add assertion for annotated type in Structtype::canBeUsedExternally	2018-09-21 14:25:05 +01:00
liangdzou	f347dee812	fix typo	2018-09-21 09:27:33 +08:00
chriseth	dc9853bb6e	Merge pull request #5030 from ethereum/payableConversion ... Make non-payable default for conversion to address.	2018-09-20 21:20:46 +02:00
liangdzou	44e8dfd393	fix typo	2018-09-20 22:54:57 +08:00
chriseth	d0461c49fe	Make non-payable default for conversion to address.	2018-09-20 14:31:04 +02:00
hydai	b409faa675	Disallow uppercase X in hex number literals	2018-09-19 22:01:15 +08:00
liangdzou	24e5dcc352	fix code format problems	2018-09-19 00:18:49 +08:00
liangdzou	808c3f3df5	fix some format typos	2018-09-17 22:13:21 +08:00
liangdzou	f3cbdadec7	Do not set to ref for explicit conversion and add assertion for array ... type conversion. Also, add some test cases for #4901 and #4948.	2018-09-14 08:42:40 +02:00
Jordan Last	d0497aacc0	fixing rebase conflicts ... add ElementaryTypes::BytesMemory and ElementaryTypes::StringMemory fix rebase conflicts fixing rebase conflicts use make_shared instead of new fix tabs and StateMutability parameter create address and addressType functions, fix spaces in comment fix typo and switch nonpayable to payable fix spaces fix comment again	2018-09-13 15:53:06 -06:00
Daniel Kirchner	e7daed68c1	Merge pull request #4911 from ethereum/addressPayable ... Payable and non-payable address type.	2018-09-13 17:30:54 +02:00
Daniel Kirchner	ae35a58124	Add `stateMutability field to JSON AST for address` types.	2018-09-13 15:15:49 +02:00
Daniel Kirchner	12aaca1645	Add payable and non-payable state mutability to AddressType.	2018-09-13 15:15:49 +02:00
Anurag Dashputre	b86cea033b	Removed default case from "ExpressionCompiler::visit(FunctionCall...)".	2018-09-13 15:40:06 +05:30
liangdzou	558a4ac49c	give more information (at most 35 chars before and after) for too long lines ... add tests for giving more informations for too long lines add edge tests for giving more informations for too long lines avoid printing out tailing white space update test case after avoiding printing out trailing whitespace update test case for removing the pre-release warning from reference refactor the code to if-else flavor rename folder to cmdlineErrorReports under test rename folder to cmdlineErrorReports under test ignore whitespace for reference files avoiding to modify the file stderr_path by call sed without -i option print ' ...' instead of ' ... ' at the end of a line	2018-09-13 09:55:54 +08:00
Daniel Kirchner	1ce3581a52	Accept `address payable` during parsing.	2018-09-11 14:52:23 +02:00
Daniel Kirchner	a434896458	Restore `isConstructor` in the legacy AST.	2018-09-11 14:47:25 +02:00
Daniel Kirchner	395ab9a872	Replace `isConstructor field in the JSON AST by a kind` field.	2018-09-11 14:47:25 +02:00
chriseth	120438c0cf	Always perform cleanup for EXP.	2018-09-10 12:47:46 +02:00
chriseth	0b7b8162ca	This fixes several bugs with regards to line breaks and comments: ... - any unicode line break (line feed, vertical tab, form feed, carriage return, NEL, LS and PS) is considered to terminate a single-line comment. The line break itself is considered to be the next token after the comment, leading to a parser error if it is not an ascii character (i.e. for NEL, LS and PS). - unterminated multiline comments are considered illegal tokens - '/** /' is considered an unterminated multiline comment (previously, whitespace was allowed before the last '/'	2018-09-06 16:42:59 +02:00
chriseth	977ac9c390	Refactor handling of whitespace.	2018-09-06 16:42:59 +02:00
Daniel Kirchner	f020f96b6c	More consistently use parse*() functions without argument in the parser.	2018-09-06 14:55:07 +02:00
chriseth	522174890f	Merge pull request #4872 from bakaoh/issue4716 ... Crash when array index value is too large	2018-09-05 21:47:42 +02:00
Daniel Kirchner	87804b6419	Split IntegerType into IntegerType and AddressType.	2018-09-05 12:19:14 +02:00
chriseth	a996ea266c	Merge pull request #4590 from ethereum/msgValueModifier ... Warn if modifier uses msg.value in non-payable function	2018-09-05 10:32:10 +02:00
bakaoh	a7ffff6a29	Fix #4716: Crash when array index value is too large	2018-09-05 10:54:38 +07:00
chriseth	e6aa15bae1	Merge pull request #4895 from ethereum/abidecodesingle ... Fix abi.decode returning single value.	2018-09-04 23:47:56 +02:00
chriseth	85debe77d9	Merge pull request #4866 from bakaoh/issue4743 ... Fix#4743: Incorrect source location for nameless parameters	2018-09-04 20:21:03 +02:00
chriseth	8da1f25030	Merge pull request #4897 from ethereum/trailingWhitespaceDetection ... Trailing whitespace detection script and circleci job.	2018-09-04 18:20:57 +02:00
chriseth	624dbbe142	Fix abi.decode returning single value.	2018-09-04 18:19:00 +02:00
Daniel Kirchner	1ae6ec9038	Remove trailing whitespace.	2018-09-04 17:43:04 +02:00
chriseth	9daac90cf7	Merge pull request #4888 from ethereum/disallow_single_statement_vardecl_if_while_for ... Disallow single statement var decl in if/while/for without blocks	2018-09-04 17:24:06 +02:00
Daniel Kirchner	82f512a7d4	Add return data to bare calls.	2018-09-04 13:31:10 +02:00
Leonardo Alt	ac8892e0e3	Review suggestions	2018-09-04 12:14:04 +02:00
Leonardo Alt	17176871ab	Changed error message and added tests	2018-09-04 11:48:58 +02:00
Daniel Kirchner	a102f3b783	Remove trailing whitespace for all files in the repository.	2018-09-04 11:30:30 +02:00
chriseth	2783905bab	Merge pull request #4837 from chase1745/default-to-unspecified ... Rename `Location::Default` to `Location::Unspecified`	2018-09-03 18:44:41 +02:00
chriseth	431c2fbcf3	Turn warning into error.	2018-09-03 18:35:57 +02:00
Erik Kundt	75a92b0ffd	Warns if modifier uses msg.value in non-payable function.	2018-09-03 18:35:57 +02:00
Leonardo Alt	4522c804f3	Disallow single statement var decl in if/while/for without blocks	2018-09-03 18:21:57 +02:00
chriseth	758bc1614c	Merge pull request #4851 from anurag-git/anurag_issue_4824 ... Removed unused "FunctionType::Kind::CallCode"	2018-09-03 16:51:05 +02:00
bakaoh	c458f5988b	Fix#4743: Incorrect source location for nameless parameters	2018-08-28 11:11:40 +07:00
Anurag Dashputre	94c327c1ae	Removed unused "FunctionType::Kind::CallCode" from Types.h and all its usage	2018-08-23 13:09:00 +05:30
Anurag Dashputre	8497dcd721	Merge branch 'develop' into anurag_issue_3667	2018-08-23 11:56:45 +05:30
Anurag Dashputre	55524788e2	Removed the default cases related to assertion to detect the problem at compile-time instead of run-time	2018-08-23 11:47:00 +05:30
Chase McDermott	551e0bf47c	Rename Location::Default to Location::Unspecified.	2018-08-17 18:15:22 -05:00
Anurag Dashputre	435cd95c54	Default case removed to detect errors at comoile time rather than run time	2018-08-17 18:37:35 +05:30
chriseth	410d288dfc	Merge pull request #4629 from ethereum/mapping_dynamic_key ... Dynamic type as mapping key returns error instead of assertion fail	2018-08-16 15:56:14 +02:00
chriseth	c274af0770	Merge pull request #4825 from ethereum/expressionCompBareCall ... More safeguards for (library) function types.	2018-08-16 14:38:44 +02:00
Leonardo Alt	583e7156ba	Dynamic type as mapping key returns error instead of assertion fail	2018-08-16 11:59:41 +02:00
liangdzou	74c37935f0	fix a typo: declaratoion => declaration	2018-08-16 13:42:46 +08:00
chriseth	cc6fa6d61f	Merge pull request #4822 from ethereum/addressStaticCall ... Add ``staticcall`` to ``address``.	2018-08-16 00:13:21 +02:00
chriseth	455345871d	More safeguards for (library) function types.	2018-08-15 17:11:43 +02:00
Leonardo Alt	faed71c6b1	Review suggestions	2018-08-15 17:11:18 +02:00
Leonardo Alt	b6c839e817	Disallow indexed reference types in events when using ABIEncoderV2	2018-08-15 17:11:18 +02:00
Daniel Kirchner	7ca0aaaf6f	Add `staticcall to address`.	2018-08-15 16:06:48 +02:00
chriseth	6c0261e6ab	Merge pull request #4390 from ethereum/abidecode ... Add abi.decode	2018-08-15 12:31:26 +02:00
chriseth	9328ea4c3c	Add abi.decode(bytes data, (...))	2018-08-15 10:45:16 +02:00
bakaoh	3fa8829845	Fixes #4718: High CPU usage when using large variable names	2018-08-15 10:23:08 +02:00
chriseth	cc54f6c425	Merge pull request #4738 from ethereum/dataloc_merged ... Enforce data location.	2018-08-14 21:38:07 +02:00
chriseth	8f27fb1f4a	Merge pull request #4542 from aarlt/constructor_natspec ... Fix: natspec annotations on constructors	2018-08-14 19:13:25 +02:00
Chase McDermott	683bce1869	Refactor data location check.	2018-08-14 18:07:15 +02:00
chriseth	3f42118d19	Merge pull request #4765 from ethereum/fixes-issue-4673 ... [WIP] Fixes issue where computing storage size for a number would take too long (or even cause a crash).	2018-08-14 17:34:04 +02:00
Jesse Busman	c059119145	Add implicit convertibility to function pointer with higher state mutability	2018-08-14 17:13:10 +02:00
chriseth	ec7ccbdf86	Merge pull request #4782 from ethereum/encodePackedArrayOfStructs ... Encode packed array of structs	2018-08-14 16:32:57 +02:00
Christian Parpart	43bda53410	Fixes issue where computing storage size for a number would take too long. ... Fixes #4673.	2018-08-14 15:38:10 +02:00
Christian Parpart	81faafe7f2	Adds support for structs in interfaces. ... Closes #4733.	2018-08-14 15:36:03 +02:00
chriseth	6ca3973944	Merge pull request #4777 from ethereum/typeConversionMemory ... Defaul data location for type conversions is memory.	2018-08-14 11:36:19 +02:00
chriseth	3dd31b704a	Merge pull request #4798 from ethereum/mappingArgumentsAndReturns ... Mapping arguments and returns	2018-08-13 17:27:29 +02:00
chriseth	ae8218543b	Merge pull request #4696 from ethereum/byteLiteralConversion ... Disallow ambiguous implicit and explicit conversions from number literals to bytesXX	2018-08-13 17:25:30 +02:00
Daniel Kirchner	341128962f	Allow mappings of arrays as arguments and return values of internal functions.	2018-08-13 16:33:37 +02:00
Daniel Kirchner	4ae59acc09	Consider mappings return values in control flow analysis.	2018-08-13 16:33:37 +02:00
Daniel Kirchner	a9f31da411	Allow mapping arguments and return values in all internal functions.	2018-08-13 15:50:22 +02:00
chriseth	bd567a22c9	Defaul data location for type conversions is memory.	2018-08-13 14:38:12 +02:00
Daniel Kirchner	57ada1d69e	Allow mapping arguments and return values in internal library functions.	2018-08-13 14:31:10 +02:00
Daniel Kirchner	7d7abeb149	Disallow ambiguous conversions between number literals and bytesXX types.	2018-08-13 14:27:01 +02:00
Daniel Kirchner	954d7433bd	Disallow remappings with empty prefix.	2018-08-10 19:26:48 +02:00
chriseth	0b65b2dff6	Disallow packed encoding of arrays of structs.	2018-08-09 21:16:51 +02:00
chriseth	6954f83a0c	Merge pull request #4790 from ethereum/fixCalldata ... Fix data location of external reference parameters.	2018-08-09 19:40:15 +02:00
Daniel Kirchner	b6e352f694	Merge pull request #4767 from ethereum/cvc4Build ... Add workarounds for building against CVC4 on ArchLinux.	2018-08-09 15:45:52 +02:00
chriseth	c9ca083d14	Fix data location of external reference parameters.	2018-08-09 15:04:00 +02:00
Alex Beregszaszi	ed52f422b7	Rename FunctionKind SHA3 to KECCAK256 (as the instruction was renamed in libevmasm)	2018-08-08 22:37:40 +01:00
Alexander Arlt	f76d4d5919	Fix: natspec annotations on constructors ... - natspec annotations on constructore where ignored.	2018-08-08 21:53:35 +02:00
chriseth	d634d20b5b	Merge pull request #4684 from ethereum/underscores_in_numeric_literals ... [BREAKING] Underscores in numeric literals	2018-08-08 21:36:57 +02:00
Daniel Kirchner	c7a0f44159	Do not force GMP to be present as dependency of CVC4, but also allow CLN instead.	2018-08-08 19:02:59 +02:00
Daniel Kirchner	9b4546c487	Add workarounds for building against CVC4 on ArchLinux.	2018-08-08 19:02:59 +02:00
Alex Beregszaszi	551343ae3e	Merge pull request #4665 from mattaereal/cmake-patch-solver ... cmake option added to make solvers optional	2018-08-08 17:58:01 +01:00
Alex Beregszaszi	9d782cc39c	Merge pull request #4770 from ethereum/throw-codegen ... Remove code generation for Throw statement	2018-08-08 17:55:27 +01:00
Alex Beregszaszi	bb071f3075	Merge pull request #4769 from ethereum/inlineasm-overloading-resolution ... Provide nicer error message when referencing overloaded references	2018-08-08 17:55:10 +01:00
Alex Beregszaszi	a9819aa8bc	Remove code generation for Throw statement ... It is disallowed in the type system.	2018-08-08 17:02:25 +01:00
Matías Aereal Aeón	4b20708c49	cmake flags to make solvers optional. Implementation of #4651	2018-08-08 12:43:57 -03:00
Alex Beregszaszi	9062704054	Merge pull request #4753 from mattaereal/boost-to-string-patch ... Replace boost:lexical_cast<std::string> for std::to_string.	2018-08-08 16:07:25 +01:00
Alex Beregszaszi	3c791d637d	Provide nicer error message when referencing overloaded references	2018-08-08 15:59:24 +01:00
Alex Beregszaszi	efeffa8083	Merge pull request #4761 from ethereum/libsolc-exceptions ... Mark libsolc external C functions as noexcept	2018-08-08 15:56:12 +01:00
Matías Aereal Aeón	e902ce1aa0	Removing std:: from std::to_string and include for boost/lexical_cast	2018-08-08 11:26:30 -03:00
Alex Beregszaszi	1bfb841771	Remove experimental 0.5.0 pragma	2018-08-08 14:05:36 +01:00
chriseth	de8e9114fd	Merge pull request #4740 from ethereum/enforceNumberOfReturnValues ... Disallow empty return in function with return arguments.	2018-08-08 14:59:09 +02:00
Alex Beregszaszi	5b4ad10b3c	Mark StandardCompiler::compile as noexcept ... It has a generic catch statement and shouldn't leak out exceptions.	2018-08-08 13:22:40 +01:00
Christian Parpart	b9222808f6	Cleanup & polish numbers-with-underscores parsing, also improving tests.	2018-08-08 13:38:46 +02:00
chriseth	d0863f4994	Merge pull request #4748 from ethereum/validate-identifier ... Assert that type identifier contains only valid characters	2018-08-08 12:50:45 +02:00
chriseth	fd12c718f6	Merge pull request #4745 from ethereum/nameResolverNoEarlyExit ... Do not stop after the first error in reference resolution.	2018-08-08 12:49:46 +02:00
Alex Beregszaszi	64e3c9913f	Merge pull request #4736 from ethereum/removeFillRight ... Remove remaining instances of ``fillRight``.	2018-08-08 11:27:37 +01:00
Balajiganapathi S	09a36cba02	Add stricter hex underscore rules	2018-08-08 12:05:51 +02:00
Balajiganapathi S	0000bfc604	Allow underscores in numbers.	2018-08-08 12:05:51 +02:00
Matías Aereal Aeón	7dae58cbcc	Replace boost:lexical_cast<std::string> for std::to_string.	2018-08-08 03:55:43 -03:00
Alex Beregszaszi	3064bd17bc	Assert that type identifier contains only valid characters	2018-08-07 22:29:21 +01:00
Alex Beregszaszi	4dc3335cda	Merge pull request #4744 from ethereum/smt-magic-variable ... SMT: do not crash on referencing MagicVariableDeclaration	2018-08-07 21:30:14 +01:00
chriseth	43d6a9d763	Do not stop after the first error in reference resolution.	2018-08-07 22:04:59 +02:00
Alex Beregszaszi	f024efb7ab	SMT: do not crash on referencing MagicVariableDeclaration	2018-08-07 20:43:20 +01:00
Daniel Kirchner	cc83e69469	Disallow empty return expressions in functions with non-empty return parameters.	2018-08-07 20:48:07 +02:00
Daniel Kirchner	b11e39e25e	Remove remaining instances of `fillRight` left over from tuple wildcards assignments.	2018-08-07 18:51:53 +02:00
chriseth	d7756322c0	Merge pull request #4731 from ethereum/interface-enum ... Allow enums in interfaces	2018-08-07 17:20:05 +02:00
chriseth	901550e473	Merge pull request #4692 from ethereum/devcore-path ... Move absolutePath/sanitizePath helpers from CompilerStack to libdevcore	2018-08-07 16:15:49 +02:00
chriseth	a949cffd24	Merge pull request #4699 from ethereum/cleanup_VariableDeclaration ... libsolidity: Remove dead code wrt. VariableDeclaration::canHaveAutoType	2018-08-07 16:14:41 +02:00
chriseth	c61cc98d0d	Merge pull request #4726 from ethereum/moveNothrow ... Make MemberList nothrow move constructible.	2018-08-07 16:11:59 +02:00
Alex Beregszaszi	a765b5b31c	Merge pull request #4720 from ethereum/abi-rational-type-identifier ... Fix type identifiers for RationalNumberType (on negative numbers)	2018-08-07 14:25:11 +01:00
Alex Beregszaszi	13e37df97c	Allow enums in interfaces	2018-08-07 13:28:53 +01:00
Alex Beregszaszi	b0f9fc5af0	Fix type identifiers for RationalNumberType	2018-08-07 13:23:14 +01:00
chriseth	133fd3d302	Make MemberList nothrow move constructible.	2018-08-07 14:20:18 +02:00
Alex Beregszaszi	05cc7e79e1	More precise error message if using non-variables with _slot/_offset	2018-08-07 13:18:54 +01:00
Alex Beregszaszi	eb7b3862ac	Properly handle invalid references used together with _slot and _offset.	2018-08-07 13:18:38 +01:00
Alex Beregszaszi	8b2d630275	Merge pull request #4724 from ethereum/slot-in-assembly ... Do not crash on using _slot and _offset suffixes on their own	2018-08-07 12:55:40 +01:00
Alex Beregszaszi	296ba24f7f	Do not crash on using _slot and _offset suffixes on their own	2018-08-07 12:14:12 +01:00
chriseth	71e26f6adb	Remove clone feature.	2018-08-07 11:10:50 +01:00
Christian Parpart	4c90ddf64a	libsolidity: Remove dead code wrt. VariableDeclaration::canHaveAutoType() ... Closes #4667	2018-08-07 11:34:13 +02:00
Alex Beregszaszi	bd75d4268b	Move fullyQualifiedName to ContractDefinition only	2018-08-06 18:58:27 +02:00
chriseth	276724dedc	Merge pull request #4663 from ethereum/dropConstantAST ... [BREAKING] Drop constant field from JSON AST	2018-08-06 18:55:12 +02:00
Alex Beregszaszi	eccc603291	FixedBytes(0) is invalid, do not check for it in ABIEncoderV2	2018-08-06 16:54:05 +02:00
chriseth	bc73617f5e	Merge pull request #4689 from ethereum/cleanup-050-tests ... Cleanup 0.5.0 test cases	2018-08-06 14:45:31 +02:00
Alex Beregszaszi	3de0b8b7f0	Move absolutePath/sanitizePath helpers from CompilerStack to libdevcore	2018-08-06 12:54:22 +01:00
Alex Beregszaszi	3481d4e2ec	Merge pull request #4690 from ethereum/equalParameterTypes ... Renamed FunctionType::hasEqualArgumentTypes to FunctionType::hasEqual…	2018-08-06 12:50:04 +01:00
Jesse Busman	3fcd62921e	Renamed FunctionType::hasEqualArgumentTypes to FunctionType::hasEqualParameterTypes	2018-08-06 13:05:06 +02:00
Alex Beregszaszi	08e431f94e	Remove unused 050 variable in ReferencesResolver	2018-08-06 12:03:00 +01:00
chriseth	9d03de1f25	Merge pull request #4671 from ethereum/mappingTupleAssignment ... Disallow assignments to mappings within tuple assignments; allow for local variables.	2018-08-06 12:59:16 +02:00
chriseth	3576980710	Merge pull request #4644 from ethereum/event_struct_error ... Disallow structs in events without ABIEncoderV2	2018-08-06 11:44:05 +02:00
chriseth	30f981fc2c	Merge pull request #4681 from ethereum/var-suggestion-crash ... Fix declaration suggestion for var with different number of components	2018-08-06 11:21:54 +02:00
Daniel Kirchner	44374a5846	Remove "constant" from JSON AST.	2018-08-06 11:15:25 +02:00
Alex Beregszaszi	83e6c34526	Fix declaration suggestion for var with different number of components	2018-08-04 15:22:22 +01:00
Christian Parpart	a4ee1dfc83	Merge pull request #4412 from ethereum/v050-reference-resolver-errorTypeForLoose ... [BREAKING] permanently set errorTypeForLoose from Warning to SyntaxError	2018-08-03 19:30:33 +02:00
Daniel Kirchner	f9b90feea0	Review suggestions; to be squashed.	2018-08-03 17:38:06 +02:00
Daniel Kirchner	1e4b5886d6	Allow assignments to local variables of mapping types.	2018-08-03 16:22:03 +02:00
Daniel Kirchner	c0a169ca90	Disallow assignments to mappings within tuple assignments.	2018-08-03 15:46:26 +02:00
Leonardo Alt	20c6cea7bb	Disallow structs in events without ABIEncoderV2	2018-08-03 13:41:27 +02:00
Daniel Kirchner	35c5b7de25	Turn warning about uninitialized storage returns into an error.	2018-08-02 19:34:38 +02:00
chriseth	009a55c82d	Merge pull request #4327 from ethereum/document-internals ... Properly explain all the analsys steps in CompilerStack	2018-08-02 15:07:35 +02:00
chriseth	90a5928b88	Merge pull request #4522 from ethereum/fullEncodingType ... Isolate determining the encoding type into its own function.	2018-08-02 15:01:38 +02:00
Christian Parpart	5d9320c70b	Disallow loos assembly in Solidity by permanently setting it to SyntaxError (from Warning)	2018-08-02 13:36:05 +01:00
Alex Beregszaszi	6003ed2abd	Merge pull request #4603 from ethereum/smtlib2 ... [SMTLib2] Fix repeated declarations	2018-08-02 12:04:58 +01:00
Leonardo Alt	90f319615f	SMT model variables are sorted and printed as secondary source location	2018-08-01 23:27:46 +02:00
Leonardo Alt	b6a2655513	Replace "value" by "<result>" in the SMT model	2018-08-01 23:27:11 +02:00
Daniel Kirchner	ce7c7aca79	Extend code comment about signatures.	2018-08-01 17:18:17 +02:00
Daniel Kirchner	30d9961efb	Do not exclude public state variables when looking for conflicting declarations.	2018-08-01 14:31:04 +02:00
Alex Beregszaszi	ce99a5ce7f	Merge pull request #4378 from ethereum/noBaseWithoutArguments ... [BREAKING] Disallow calling base constructors without arguments.	2018-08-01 13:18:37 +01:00
chriseth	061ea0cfc6	Correctly determine whether base constructor is called without parentheses.	2018-08-01 12:28:27 +01:00
chriseth	7e5406dd89	Disallow calling base constructors without arguments.	2018-08-01 12:28:27 +01:00
Christian Parpart	38f9667e09	Guard CycleDetector against recursion exhaustion. ... fixes #3935.	2018-08-01 12:02:59 +01:00
chriseth	7a8a243eef	Isolate determining the encoding type into its own function.	2018-08-01 11:55:57 +01:00
chriseth	c8232d9759	Disallow conversion between unrelated contract types.	2018-08-01 11:04:35 +01:00
Alex Beregszaszi	21888e246b	Merge pull request #4507 from ethereum/v050-var-keyword-trace-removals ... Ensures an empty use of var keyword is caught with the proper non-fatal error message	2018-08-01 10:59:26 +01:00
Leonardo Alt	41ac3d6cfb	Remove repeated declarations in Z3 and CVC4 as well	2018-08-01 11:12:56 +02:00
Christian Parpart	a7150f85a6	Ensures an empty use of var keyword is caught with the proper error message.	2018-08-01 09:59:06 +02:00
Leonardo Alt	210fee571f	Fix crash when FunctionType has undeclared type as parameter	2018-07-31 11:17:51 +02:00
Alex Beregszaszi	f74cff622d	Properly explain all the analsys steps in CompilerStack	2018-07-31 00:39:18 +01:00
Alex Beregszaszi	179427fd65	Import dev::solidity namespace in SMTPortfolio	2018-07-27 23:17:17 +01:00
Leonardo Alt	f249f9c86f	[SMTLib2] Fix repeated declarations	2018-07-27 17:34:44 +01:00
Alex Beregszaszi	dea0567e06	Fix unterminated parentheses typo in SMTLib2 ... Found by @leonardoalt	2018-07-27 17:33:53 +01:00
Leonardo Alt	55c1fb60b4	[SMTChecker] Add CheckResult::CONFLICTING	2018-07-27 16:16:26 +01:00
Leonardo Alt	87a38e1abe	[SMTChecker] SMTPortfolio: use all SMT solvers available	2018-07-27 16:15:34 +01:00
Leonardo Alt	b356f6a7f9	Setting timeout to Z3 and CVC4	2018-07-27 16:01:48 +02:00
Leonardo Alt	06dbcb3afe	Only ask for a model if it's SAT	2018-07-27 14:13:22 +02:00
Alex Beregszaszi	ae15b52d93	Merge pull request #4565 from ethereum/smt-stringutils-crash ... Add assert for both branches in mergeVariables in SMTChecker	2018-07-25 11:08:47 +01:00
Alex Beregszaszi	a5a61a0b77	More consistent catch statements ... Also take const& in all cases.	2018-07-25 01:18:09 +01:00
Alex Beregszaszi	d30a6de942	Add better warning on binary operation on non-integer types in SMT Checker	2018-07-24 23:23:54 +01:00
Alex Beregszaszi	278372c13d	Add assert for both branches in mergeVariables in SMTChecker	2018-07-24 22:43:05 +01:00
Leonardo Alt	a2f03ea9e5	Fix abiDecode comment	2018-07-23 23:31:02 +02:00
Alex Beregszaszi	de90290c28	Merge pull request #4527 from ethereum/mappingEnforceStorage ... Enforces explicit data location for mappings	2018-07-23 20:43:38 +01:00
Erik Kundt	c622a1e56c	Enforces data location of local mappings to storage.	2018-07-23 19:30:07 +02:00
Christian Parpart	9f35f0b805	Disallow functions without implementation to use modifiers. This was already the case in the experimental 0.5.0 mode.	2018-07-23 17:29:08 +01:00
chriseth	3fa0ac5822	Do not handle balance member of contract types specially.	2018-07-20 10:50:05 +02:00
chriseth	e3c2f20f6e	Merge pull request #4439 from ethereum/address_members ... [BREAKING] Enforce address members not accessible by contract instance	2018-07-19 09:24:27 +02:00
Leonardo Alt	faa9c221d4	Changes in ExpressionCompiler	2018-07-18 19:51:24 +02:00
Erik Kundt	b0b35e1e6b	Adds warning if function is shadowing a contract.	2018-07-18 14:29:01 +02:00
Erik Kundt	182a0a9551	Disallows old constructor syntax.	2018-07-18 14:29:01 +02:00
chriseth	dfd2fee91d	Suggests external for fallback and interface functions.	2018-07-17 18:07:36 +02:00
Erik Kundt	b5ecfbe5bc	Enforces visibility specifier and updates docs.	2018-07-17 17:44:51 +02:00
Leonardo Alt	563e0fc9a7	Add suggestion to error message	2018-07-17 16:38:36 +01:00
Leonardo Alt	0075f4239a	Address members not accessible by contract instance	2018-07-17 13:33:23 +01:00
Leonardo Alt	fdfdddd8dc	Add missing period in the end of error messages	2018-07-16 16:11:39 +01:00
Alex Beregszaszi	21e97da294	Deprecate the throw statement	2018-07-16 15:33:20 +02:00
Christian Parpart	396bf11858	enforce interface-functions to be external-declared ... - libsolidity: Enforce interface-functions must be external-declared. - Changelog adapted to reflect changes wrt. functions in interfaces. - test: Adjustments according to prior interface-function changes. - tests: Adapting SolidityEndToEndTest to interface-function change. - docs: Adapted documentation to interface-function change.	2018-07-16 12:15:36 +02:00
chriseth	bab4a3975f	Merge pull request #4501 from ethereum/recursiveStructsWithFixedArrays ... Consider fixed-size arrays when checking for recursive structs.	2018-07-13 01:26:50 +02:00
Daniel Kirchner	fc370591f0	Disallow multi variable declarations with mismatching number of values.	2018-07-12 20:33:51 +02:00
Daniel Kirchner	d71a023c0b	Use CycleDetector and account for multi-dimensional arrays.	2018-07-12 20:14:02 +02:00
Daniel Kirchner	d4dfd28694	Consider fixed size array members when checking for recursive structs.	2018-07-12 20:14:02 +02:00
chriseth	5d8a8f7265	Merge pull request #4437 from ethereum/report-empty-var-decls ... [BREAKING] Report empty var tuple decls	2018-07-12 19:22:38 +02:00
chriseth	6dcafac44e	Merge pull request #4447 from hosho/develop ... Fix NatSpec json output for "@notice" and "@dev" tags on contract definitions	2018-07-12 18:42:30 +02:00
chriseth	81271801b4	Merge pull request #4478 from ethereum/requireStorageLocation ... Turn missing storage locations into an error.	2018-07-12 18:00:05 +02:00
Alex Beregszaszi	0dd79bc172	Merge pull request #4479 from ethereum/fixFixedPointCrash ... Fix handling of fixed point types in arithmetics.	2018-07-12 15:04:16 +01:00
Matt Little	4efe3544f7	Fix NatSpec json output for "@notice" and "@dev" tags on contract definitions.	2018-07-12 14:39:13 +02:00
Christian Parpart	cc585138bc	Generates a syntax error when declaring a variable declaration's LHS has no named components	2018-07-12 13:26:52 +02:00
chriseth	fa8102880f	Merge pull request #4428 from ethereum/enforce_staticcall_view ... [BREAKING] Enforce STATICCALL for view and pure	2018-07-12 13:14:02 +02:00
chriseth	576f3ef18c	Merge pull request #4083 from ethereum/variable_stack_slot ... [BREAKING] Allocate local variables according to their scope	2018-07-12 13:01:15 +02:00
Daniel Kirchner	a1f54f4e40	Require storage location.	2018-07-12 12:48:18 +02:00
chriseth	99bee7e233	Merge pull request #4443 from ethereum/double_var_decl_fix ... Fix crash when declaring the same var twice in the same scope	2018-07-12 00:05:32 +02:00
chriseth	2b8091526f	Merge pull request #4472 from ethereum/complexCalldataArraysNotYetImplemented ... Throw unimplemented exception for complex calldata arrays.	2018-07-11 23:48:42 +02:00
chriseth	0c9645c978	Merge pull request #4480 from ethereum/fixZeroWithExponent ... Fix literals with exponents with mantissa of zero.	2018-07-11 23:45:41 +02:00
Christian Parpart	08345209e6	Merge pull request #4404 from ethereum/v050-var-keyword-suggest ... [WIP] v0.5.0 var keyword type suggestion	2018-07-11 16:33:09 +02:00
Daniel Kirchner	e8e5e12ad2	Fix literals with exponents with mantissa of zero.	2018-07-11 15:34:17 +02:00
chriseth	7355298c2f	Fix handling of fixed point types in arithmetics.	2018-07-11 14:56:53 +02:00
Leonardo Alt	38026d3114	Use STATICCALL for view and pure	2018-07-11 14:45:22 +02:00
chriseth	f3abfa81ad	Merge pull request #4454 from ethereum/constructorArgCount ... [BREAKING] Wrong argument count in constructor call	2018-07-11 14:45:05 +02:00
chriseth	238dbe1b99	Merge pull request #4388 from ethereum/noPackedLiterals ... Disallow packed encoding of literals.	2018-07-11 14:28:20 +02:00
Erik Kundt	7c7e154a7b	Improves error with suggestion to remove parantheses.	2018-07-11 01:58:17 +02:00
Erik Kundt	34a031609e	Updates Changelog, syntax test and simplifies type checker.	2018-07-11 01:58:17 +02:00
Erik Kundt	0b960f5a9c	Turns wrong argument count in base constructor call into en error.	2018-07-11 01:56:07 +02:00
Cryptomental	140dbfdbd8	Code, Changelog, ReleaseChecklist: Fix typos. ... Refs: #4442	2018-07-11 00:26:23 +02:00
chriseth	458a4c8aa5	Coding style.	2018-07-10 22:29:53 +02:00
Christian Parpart	1505e28b56	semantics: Suggest auto-deduced type when user declares variable with var keyword.	2018-07-10 22:14:19 +02:00
chriseth	d84976dc87	Merge pull request #4376 from ethereum/fallbackExternal ... Fallback functions have to be external	2018-07-10 21:39:25 +02:00
chriseth	383b88793c	Throw unimplemented exception for complex calldata arrays.	2018-07-10 21:23:20 +02:00
chriseth	12045d2e11	Merge pull request #4464 from cryptomental/bugfix/fix-typos-in-AsmParser-and-TypeChecker ... AsmParser,TypeChecker: Fix typos.	2018-07-10 21:07:56 +02:00
chriseth	6567cd3e51	Merge pull request #4466 from ethereum/tupleNotEmpty ... Disallow empty tuple components.	2018-07-10 21:03:30 +02:00
Leonardo Alt	cee4775a58	Add comment explaining new code	2018-07-10 18:54:46 +02:00
Leonardo Alt	c286cdaa62	Fix crash for double variable declaration in the same scope.	2018-07-10 18:54:46 +02:00
Leonardo Alt	0c5e0e0d59	Added assertion and tests suggestions	2018-07-10 18:39:38 +02:00
Leonardo Alt	b750ca9741	Add more tests and assertions	2018-07-10 18:39:38 +02:00
Leonardo Alt	9d895e002d	Added tests and review suggestions	2018-07-10 18:39:38 +02:00
Leonardo Alt	1f77deada1	[050] Reserving and popping local vars in their scope	2018-07-10 18:39:38 +02:00
chriseth	0e9415bc31	Merge pull request #4468 from ethereum/variableDeclarationClenaup ... Remove mentions of ``var`` in VariableDeclarationStatement comment.	2018-07-10 17:50:02 +02:00
Christian Parpart	8ca69ed8d8	defaulting to v0.5.0 behaviour of unary + operator (disallow); also adapting all tests to it	2018-07-10 16:27:57 +02:00
chriseth	64abfd3e4a	Remove special `(x,)` case from type assignment.	2018-07-10 15:58:46 +02:00
Daniel Kirchner	a6e5a51d61	Disallow empty tuple components.	2018-07-10 15:27:46 +02:00
chriseth	7650905567	Merge pull request #4415 from ethereum/uninitializedStoragePointer ... [BREAKING] Turn uninitialized storage variables into error.	2018-07-10 15:24:01 +02:00
chriseth	187eef36ad	Remove mentions of `var` in VariableDeclarationStatement comment.	2018-07-10 14:55:50 +02:00
Cryptomental	a55abb550d	AsmParser,TypeChecker: Fix typos. ... Fix typos. The change requested as a separate PR during codespell PR. Adapt tests as well. Refs: #4442	2018-07-10 12:33:19 +02:00
Daniel Kirchner	ece9afef8f	Check for matching number of components in TupleType::isImplicitlyConvertibleTo instead of the TypeChecker.	2018-07-10 12:17:01 +02:00
Daniel Kirchner	fe1d5da2a6	Turn uninitialized storage variables into an error.	2018-07-10 11:37:45 +02:00
Leonardo Alt	c1b67a845b	Enforce error on hex number combined with unit denomination	2018-07-09 17:19:41 +02:00
chriseth	f3e0bf1dd8	Merge pull request #4418 from ethereum/initialConstants ... Only allow compile-time constants for constant state variables.	2018-07-05 17:07:32 +02:00
chriseth	c8ac861832	Fix allocation of byte arrays.	2018-07-05 14:18:14 +02:00
chriseth	4a332ab324	Merge pull request #4409 from ethereum/viewPureChecker ... Enforce state mutability in view pure checker.	2018-07-04 14:09:46 +02:00
Leonardo Alt	8202d512e0	Enforcing error on msg.gas and block.blockhash()	2018-07-04 11:42:05 +02:00
Daniel Kirchner	7ea8365ab0	Remove v050 check for enforcing "view" in ViewPureChecker.	2018-07-04 10:14:58 +02:00
chriseth	8ed3da1d5f	Only allow compile-time constants for constant state variables.	2018-07-03 23:03:26 +02:00
chriseth	87241fd58c	Fallback function has to be external.	2018-07-03 22:51:36 +02:00
chriseth	533d5d4b1c	Merge pull request #4379 from ethereum/constructorArgsTwice ... Disallow constructor arguments given multiple times.	2018-07-03 22:49:02 +02:00
Daniel Kirchner	3984beef7d	Remove constant keyword from parser.	2018-07-03 15:31:34 +02:00
Christian Parpart	1486d215b9	libsolidity: turns the var-keyword use from deprecation-warning to an error and include explicit type suggestion	2018-07-03 10:53:09 +02:00
chriseth	f7a9c4203e	Disallow packed encoding of literals.	2018-07-03 01:02:00 +02:00
Daniel Kirchner	9aefe2f118	Remove trailing whitespace in missing visibility warning.	2018-07-02 13:14:58 +02:00
chriseth	85b9d3927a	Merge pull request #4224 from ethereum/revert_wrong_calldata ... [BREAKING] Revert if calldata has wrong size	2018-07-02 12:55:22 +02:00
chriseth	f69e24c85e	Disallow constructor arguments given multiple times.	2018-06-29 16:11:21 +02:00
chriseth	d469df45d8	Merge pull request #4352 from D-Nice/develop ... Fixes storage ref var typo error from 'prefix' to 'suffix'	2018-06-29 12:27:29 +02:00
chriseth	4a842ecc82	Merge pull request #4097 from ethereum/noPackedExceptForPacked ... [BREAKING] call only takes a single argument and does not pad	2018-06-27 18:29:01 +02:00
chriseth	92cb4acd8a	Also mention regular abi.encode in error message.	2018-06-27 15:00:34 +02:00
Alex Beregszaszi	80b7d36187	Remove non-0.5.0 warning for emit keyword (make it mandatory)	2018-06-26 20:00:54 +02:00
chriseth	503eb8caa5	Merge pull request #4342 from rnaby/l/a/Types ... RationalNumberType::isImplicitlyConvertibleTo Refactor	2018-06-26 17:54:09 +02:00
Leonardo Alt	7763d21cc6	Revert if calldata is too short or points out of bounds	2018-06-26 10:27:48 +02:00
Alex Beregszaszi	5aa8c7ed1a	Document the internal API of CompilerStack	2018-06-25 23:51:40 +02:00
Alex Beregszaszi	3fc7da11db	Pull out createCBORMetadata helper	2018-06-25 22:17:33 +02:00
chriseth	033672cc48	Fix: Call functions do not take variable arguments.	2018-06-25 17:17:48 +02:00
chriseth	5cf6fa84ac	Provide better suggestions in error messages with respect to call and hash functions.	2018-06-25 17:17:48 +02:00
chriseth	a55e8c93ce	Save double encode call for sha3.	2018-06-25 17:17:18 +02:00
D-Nice	b2f0d1db43	Fixes storage ref var typo error from 'prefix' to 'suffix'	2018-06-25 11:14:19 -04:00
chriseth	23c4142005	Bare functions take single bytes argument.	2018-06-25 17:01:45 +02:00
chriseth	0e66a1ddde	Single bytes argument. ... In 0.5.0 mode, only accept a single bytes argument for ``.call``, ``keccak256`` and others and do not pad when encoding.	2018-06-25 17:01:45 +02:00
Alex Beregszaszi	6d9a091a8e	Keep the 'if it not used as an address' helper message for all cases of address related warnings	2018-06-25 16:25:21 +02:00
Alex Beregszaszi	48b003d4d4	Better wording for invalid address literal error	2018-06-25 16:17:50 +02:00
Jason Cobb	51567c0513	Change invalid (not exactly 160 bits long) address literal to error	2018-06-25 16:17:50 +02:00
Jason Cobb	3d88eca531	Disallow implicit conversion from rational (literal) to address	2018-06-25 16:17:50 +02:00
Khan M Rashedun-Naby	097a3fabf4	RationalNumberType::isImplicitlyConvertibleTo Refactor	2018-06-24 08:15:25 +06:00
Alex Beregszaszi	72e87423db	Disallow the years unit denomination properly	2018-06-21 20:21:02 +02:00
chriseth	32f2db780c	Merge pull request #4301 from rnaby/TypeChecker ... Simplification of typeSupportedByOldABIEncoder	2018-06-21 18:53:31 +02:00
chriseth	2c456f0e70	Merge pull request #4326 from ethereum/compilerstack-cleanup ... Properly catch optimizer/assembly exception in CompilerStack	2018-06-21 14:14:13 +02:00
chriseth	0d1047181d	Merge pull request #4306 from ethereum/remove_050_workaround_scoping ... [BREAKING] C99 scoping rules by default (remove 050 workaround)	2018-06-21 13:57:59 +02:00
Alex Beregszaszi	7e4bd3e346	Merge pull request #4219 from ethereum/functionTypeNamedArguments ... Turn named return parameters in function types into an error.	2018-06-20 23:51:19 +02:00
Alex Beregszaszi	a392e0f046	Properly catch optimizer/assembly exception in CompilerStack	2018-06-20 23:19:06 +02:00
Khan M Rashedun-Naby	a5f0caa178	Simplification of typeSupportedByOldABIEncoder	2018-06-20 23:16:21 +06:00
Alex Beregszaszi	0a632011be	CompilerStack absolutePath/sanitizePath can be made static	2018-06-20 17:04:22 +02:00
Alex Beregszaszi	dcee8e11ad	Reorder some of the flow in CompilerStack::compileContract for readability	2018-06-20 17:01:17 +02:00
Leonardo Alt	8862b3092b	C99 scoping rules by default	2018-06-20 12:53:38 +02:00
Alex Beregszaszi	a17059573f	Disallow raw callcode (was deprecated in 0.4.12)	2018-06-19 19:31:07 +02:00
Daniel Kirchner	dbfee87860	Return parameters in function types may not be named.	2018-06-18 00:05:06 +02:00
Alex Beregszaszi	4cdb6c809a	Change comments	2018-06-14 09:31:28 +01:00
Alex Beregszaszi	e1d0bfe1ca	JuliaType -> YulType	2018-06-14 09:31:28 +01:00
Alex Beregszaszi	e0d95a6641	Rename internal variable	2018-06-14 09:31:28 +01:00
Alex Beregszaszi	782bc41dbd	Rename JULIA/IULIA to Yul in assembly interface	2018-06-14 09:31:28 +01:00
Christian Parpart	a211b89118	Enforce disallowing empty structs ... This patch enfoces an error when it encounters an empty struct, effectively eliminating the deprecation warning. Also adjust 419_interface_structs to explicitely test for (non-empty) structs, as this behaviour "may" change in the future.	2018-06-14 00:24:43 +01:00
chriseth	014bbc6c97	Merge pull request #4272 from ethereum/assert-break-continue ... Fail if break/continue statements are used outside for/while loops in ContractCompiler	2018-06-13 12:10:39 +02:00
chriseth	1dc28c065d	Properly pad data from calldata.	2018-06-12 18:51:40 +01:00
Alex Beregszaszi	9de45383d8	Disallow sha3/suicide aliases	2018-06-12 18:16:18 +01:00
Alex Beregszaszi	d1e7e9ef5e	Merge pull request #3627 from ethereum/additional-keywords ... [BREAKING] Add new reserved keywords.	2018-06-12 16:33:26 +01:00
Daniel Kirchner	e2f4a9fcf4	Merge pull request #4277 from ethereum/signedRightShift ... Signed Right Shift: Additional test and more explanation.	2018-06-12 17:19:20 +02:00
chriseth	cc62d7ce6a	Merge pull request #4229 from ethereum/smt_storage_vars_refactor ... Refactoring how storage and local variables are managed.	2018-06-12 16:11:05 +02:00
Daniel Kirchner	e4b7b2160e	Add new reserved keywords.	2018-06-12 16:02:53 +02:00
Daniel Kirchner	510f227bd7	Additional test and more explanation.	2018-06-12 15:53:15 +02:00
Leonardo Alt	207d5859d1	Refactoring Declaration -> VariableDeclaration (more precise)	2018-06-12 10:58:50 +02:00
Leonardo Alt	48652c88af	Review comments	2018-06-12 10:58:50 +02:00
Leonardo Alt	678a769cd7	Refactoring how storage and local variables are managed.	2018-06-12 10:58:50 +02:00
Daniel Kirchner	e84b55bd6f	Extend explanatory remark and argue using bitwise operations instead of rounding.	2018-06-12 09:32:19 +01:00
Daniel Kirchner	f33dc92cbd	Use proper SAR for signed right shifts and emulate on pre-constantinople.	2018-06-12 09:32:19 +01:00
Alex Beregszaszi	1d57d74e82	Fail if break/continue statements are used outside for/while loops in ContractCompiler	2018-06-12 00:46:23 +01:00
Erik Kundt	2e9f5d1c98	Introduces emit token and removes identifier workaround.	2018-06-11 21:21:22 +01:00
Alex Beregszaszi	8d38d4d296	Use boost::multiprecision::pow explicitly	2018-06-11 19:31:26 +01:00
Alex Beregszaszi	0f572159ec	Show named argument name in error	2018-06-06 15:59:27 +01:00
chriseth	4073c02cf3	Merge pull request #4208 from ethereum/extract-name-and-type-tests ... Extract name and type tests	2018-06-04 19:54:14 +02:00
chriseth	283cdef98c	Fix view/pure error ordering problem.	2018-06-04 17:00:37 +02:00
chriseth	c59a06bb97	Merge pull request #4213 from ethereum/fixpop ... Fix bug related to byte array pop.	2018-06-04 16:10:56 +02:00
Jason Cobb	6e29775d39	Remove suicide and sha3 assembly instructions	2018-06-04 01:04:48 +01:00
chriseth	7cf36331a6	Fix bug related to byte array pop.	2018-05-31 14:53:33 +02:00
chriseth	0a1a8bfb09	Merge pull request #4172 from ethereum/trailing_dot ... [BREAKING] Disallow trailing dot not followed by number	2018-05-30 18:51:52 +02:00
chriseth	5a73044fa7	Merge pull request #3743 from ethereum/popStorageArray ... pop() for storage arrays	2018-05-30 18:32:08 +02:00
Erik Kundt	fea0d116f7	Fixes assembly bug and adds tests to cover it.	2018-05-30 17:46:43 +02:00
Erik Kundt	98d52beba3	Adds syntax tests, documentation and changelog entry. ... Refines comment for array utility function.	2018-05-30 17:43:20 +02:00
Erik Kundt	34b5eca1f8	Improves assembly and adds more tests.	2018-05-30 17:40:33 +02:00
Leonardo Alt	ac68710789	Disallow trailing dots that are not followed by a number	2018-05-30 15:14:53 +01:00
mingchuan	b7cafcbdf9	Allow using calldata keyword to specify data location	2018-05-30 18:05:55 +08:00
Erik Kundt	7156a01acc	Implements pop() for byte arrays.	2018-05-29 12:53:02 +02:00
bitshift	e9dcfb0b62	Implements pop() for value type arrays.	2018-05-29 12:53:02 +02:00
chriseth	9d5064d04d	Merge pull request #4173 from sifmelcara/add/allow-storage-calldata-suffix ... Allow data location suffix for internal elementary type parsing	2018-05-28 22:52:45 +02:00
chriseth	5ee2ce353e	Merge pull request #4067 from ethereum/050 ... [BREAKING] Version 0.5.0	2018-05-23 18:11:20 +02:00
mingchuan	9865012f7b	Allow data location suffix for internal elementary type parsing	2018-05-22 23:28:12 +08:00
mingchuan	3cd57866a9	Fix assert message about function visibility	2018-05-20 22:29:11 +08:00
Julius Huelsmann	1d3a37faff	Avoid "unneccesary parentheses in declaration of" warning with keeping a temporary variable.	2018-05-17 14:48:15 +02:00
Julius Huelsmann	9e26f5fa0a	Do not catch exceptions by value in StandardCompiler	2018-05-17 14:44:01 +02:00
Daniel Kirchner	1cbc037a45	Update control flow graph.	2018-05-16 18:32:48 +02:00
Daniel Kirchner	f627dc77d0	Fix continue inside do-while.	2018-05-16 18:32:48 +02:00
Daniel Kirchner	5c59d56335	Disallow conversions between bytesX and uintY of different size.	2018-05-16 18:32:47 +02:00
Leonardo Alt	0b6eea0c55	Bool variables should not allow arithmetic comparison	2018-05-16 18:32:47 +02:00
Alex Beregszaszi	221a4d1f1f	Split warning for multi arguments for hash functions	2018-05-16 11:12:25 +02:00
chriseth	894122c508	Warn/enforce single bytes argument for certain builtins (hashing functions). ... In 0.5.0 mode, only accept a single bytes argument for ``.call``, ``keccak256`` and others and do not pad when encoding.	2018-05-16 09:48:03 +02:00
chriseth	3ca6738114	Add assert about source location.	2018-05-16 03:52:24 +02:00
chriseth	67d208d144	Parse multi variable declaration statement.	2018-05-16 03:22:45 +02:00
chriseth	2ba0002998	Merge pull request #4139 from ethereum/abiEncodeIsPure ... ABI encoding functions are pure and should be usable in constants.	2018-05-15 16:59:48 +02:00
chriseth	63861aac4a	Merge pull request #3947 from ethereum/smt_storage ... [SMTChecker] Support to integer and Bool storage vars	2018-05-15 14:54:41 +02:00
chriseth	dac0029d16	ABI encoding functions are pure and should be usable in constants.	2018-05-15 14:45:54 +02:00
chriseth	dce6224052	Merge pull request #4062 from ethereum/revert-variable ... Fix revert with reason coming from a string variable	2018-05-15 14:44:39 +02:00
Leonardo Alt	4117e859eb	[SMTChecker] Declaring all state vars before any function is visited	2018-05-15 14:28:08 +02:00
Leonardo Alt	2dbb35d4a8	[SMTChecker] Support to integer and Bool storage vars	2018-05-15 14:22:50 +02:00
Daniel Kirchner	16e966dea0	Add control flow analyzer and test for uninitialized storage returns.	2018-05-14 20:23:40 +02:00
Daniel Kirchner	995623f0fa	Add control flow graph.	2018-05-14 20:23:40 +02:00
mingchuan	dbd0a7ed60	Fix link error when using boost shared library	2018-05-11 11:20:19 +08:00
Alex Beregszaszi	e96bbe70d4	Assert that mandatory fields in the AST are present in AsmAnalysis	2018-05-10 10:48:48 +02:00
Alex Beregszaszi	c03a29dea8	Fix revert with reason coming from a string variable	2018-05-09 17:53:17 +02:00
Alex Beregszaszi	868d449c38	Merge pull request #4047 from ethereum/refactorToMulti ... Refactor to allow implementing multi variable declarations.	2018-05-09 15:37:19 +01:00
chriseth	fe8f38a7a4	Assert integrity of empty IndexAccessPath structure.	2018-05-09 14:55:36 +02:00
Daniel Kirchner	02380113d4	Use the entire token as source location for parser errors.	2018-05-09 14:08:22 +02:00
chriseth	be54f48197	Further refactor.	2018-05-09 11:48:21 +02:00
chriseth	86b7adc18f	Refactor expression parser.	2018-05-09 11:48:21 +02:00
chriseth	54aa10ce36	Merge pull request #4054 from ethereum/token-names ... Improve parser error messages	2018-05-09 11:06:23 +02:00
chriseth	fe12f05c08	Deprecate wildcard assignments.	2018-05-08 15:13:32 +01:00
njwest	51b4dc3752	fixed grammar in error in CompilerUtils.cpp line 399, 'less variables.' should be 'fewer variables.'	2018-05-06 18:52:12 -04:00
chriseth	150d226603	Merge pull request #4063 from ethereum/emit-non-event ... Show proper error when trying to emit a non-event	2018-05-04 15:02:04 +02:00
Alex Beregszaszi	cc10839073	Have more uniform parser errors	2018-05-04 13:27:05 +01:00
Alex Beregszaszi	c7ee649d80	More user friendly output in case of Identifier and Token keywords	2018-05-04 13:27:05 +01:00
Alex Beregszaszi	882248ce75	Remove code duplication in expectToken	2018-05-04 13:27:05 +01:00
Alex Beregszaszi	252bde8542	Introduce Token::friendlyName() helper	2018-05-04 13:11:23 +01:00
Alex Beregszaszi	e3279d8af8	Display nicer error messages in the parser (display tokens and not internal names)	2018-05-04 12:39:37 +01:00
chriseth	81d61ca086	Merge pull request #4059 from ethereum/parser-simplify ... Simplify the parser expectations	2018-05-04 12:50:12 +02:00
Alex Beregszaszi	ffe7f224a6	Show proper error when trying to emit a non-event	2018-05-04 12:47:01 +02:00
daniel	aa1542a9e1	Change bytes to unsigned in FixedBytesType	2018-05-03 23:11:34 +01:00
Alex Beregszaszi	ed9f80690b	Simplify expectIdentifierToken by using expectToken	2018-05-03 22:10:51 +01:00
Alex Beregszaszi	73c99d15cd	Remove useless helper expectAssignmentOperator in parser	2018-05-03 21:35:38 +01:00
Alex Beregszaszi	b34428249a	Change numBits to unsigned IntegerType	2018-05-02 23:22:25 -07:00
Alex Beregszaszi	2c00ebbee1	Change totalBits and fractionalDigits to unsigned in FixedPointType	2018-05-02 23:22:25 -07:00
chriseth	a856135bbf	Merge pull request #3797 from ethereum/shift-constantinople ... Use native shift instructions on Constantinople	2018-05-02 16:50:15 +02:00
chriseth	8debded743	Revert "BREAKING: Bool variables should not allow arithmetic comparison"	2018-05-02 15:56:59 +02:00
chriseth	42289b642f	Merge pull request #4003 from ethereum/bool_vars_comparison ... BREAKING: Bool variables should not allow arithmetic comparison	2018-05-02 15:56:06 +02:00
Alexander Arlt	f94b793472	Add virtual destructors on base classes.	2018-05-02 13:29:16 +02:00
Alex Beregszaszi	059e232e69	Support shifts in gas estimator	2018-04-30 21:22:59 +01:00
chriseth	2968639406	Removed signed shift right from the utilities.	2018-04-30 20:34:43 +01:00
Alex Beregszaszi	52c9441879	Do not use SAR instead of SDIV in shifts because it rounds differently	2018-04-30 20:34:43 +01:00
Alex Beregszaszi	c3608eaf90	Use native shift instructions in ABIFunctions on Constantinople	2018-04-30 20:34:43 +01:00
Alex Beregszaszi	22bfd3da41	Use native shift instructions on Constantinople	2018-04-30 20:34:43 +01:00
chriseth	d26b6b64c0	Merge pull request #3996 from ethereum/refactorParser ... Refactor parser.	2018-04-30 19:15:11 +02:00
chriseth	15024154ab	Merge pull request #4018 from ethereum/disable-bytes0 ... Disable FixedBytesType(0) aka bytes0	2018-04-30 18:19:07 +02:00
chriseth	9e61b25dc4	Merge pull request #3958 from meowingtwurtle/fixedPointTypes ... Types class changes for fixed points	2018-04-30 15:56:55 +02:00
Alex Beregszaszi	548bf2ff28	Remove unused function smallestTypeForLiteral	2018-04-30 14:35:26 +01:00
Alex Beregszaszi	e0b178e1c5	Disable FixedBytesType(0) aka bytes0	2018-04-30 12:23:30 +01:00
Leonardo Alt	ab251c7e7d	Bool variables should not allow arithmetic comparison	2018-04-27 11:35:58 +02:00
chriseth	d44fb03322	Refactor parser.	2018-04-26 10:59:02 +02:00
Alexander Arlt	3ec667f59b	Add virtual destructor in LValue class.	2018-04-24 23:39:25 +02:00
chriseth	d1e1293fbd	Merge pull request #3981 from ethereum/years-suffix ... The "year" denomination is deprecated	2018-04-24 12:12:03 +02:00
Alex Beregszaszi	258ae8927e	Merge pull request #3970 from elopio/test/docstring-tag-end ... docstring: add missing space	2018-04-24 02:16:27 +01:00
Leo Arias	b74566e4ea	docstring: add missing space	2018-04-23 21:47:53 +00:00
chriseth	e685f9f59e	Merge pull request #3976 from ethereum/emptyTupleComponent ... Empty tuple components should not be possible	2018-04-23 17:35:00 +02:00
Alex Beregszaszi	1ac0090f31	The "year" denomination is deprecated	2018-04-23 16:19:51 +01:00
Erik Kundt	896018c8a3	Treats inline array as an error.	2018-04-23 17:11:41 +02:00
Erik Kundt	b2ff9bc88d	Turns it into warning (error for 0.5.0) and adds Changelog entry.	2018-04-23 17:09:42 +02:00
Erik Kundt	f2b58de92c	Prevents null type from being used in tuple.	2018-04-22 16:54:33 +02:00
Alex Beregszaszi	5423974e87	Remove category check in FixedPointType:binaryOperatorResult as commonType handles the same	2018-04-20 17:54:34 +01:00
Jason Cobb	57003c534a	Types changes for fixed points	2018-04-20 17:53:42 +01:00
Alex Beregszaszi	0493e3b053	Turn deprecated warnings for sha3/suicide into errors (experimental 0.5.0)	2018-04-20 17:40:48 +01:00
Alex Beregszaszi	069ea38916	Make literals an error for tight packing (experimental 0.5.0)	2018-04-20 11:58:16 +01:00
chriseth	676732776e	Merge pull request #3943 from ethereum/smt_remove_branch_warning ... [SMTChecker] Remove 'information is erase' message for if-else	2018-04-20 09:01:59 +02:00
chriseth	2546a274ca	Merge pull request #3941 from ethereum/bytes-contract ... Disallow explicit conversion of bytesXX to contract	2018-04-19 16:10:15 +02:00
Alex Beregszaszi	754d79edfa	Disallow explicit conversion of bytesXX to contract	2018-04-19 15:58:14 +02:00
Leonardo Alt	ba3d16fc58	[SMTChecker] Remove 'information is erase' message for if-else	2018-04-19 09:28:44 +02:00
chriseth	a94945dfe4	Improve error message for failed member lookup.	2018-04-18 22:56:45 +01:00
Alex Beregszaszi	39b7b44a8d	Merge pull request #3923 from ethereum/warnConstructor ... Warn about functions named "constructor".	2018-04-18 22:22:58 +01:00
Alex Beregszaszi	377254d5a8	Merge pull request #3922 from ethereum/smt_sol_unimplementedassert ... [SMTChecker] Using solUnimplementedAssert instead of solAssert	2018-04-18 20:28:47 +01:00
chriseth	4895864302	Warn about functions named "constructor".	2018-04-18 21:23:09 +02:00
chriseth	29a97f1641	Fix name clashes between constructor and fallback function.	2018-04-18 14:24:35 +02:00
Leonardo Alt	78ba34608f	[SMTChecker] Using solUnimplementedAssert instead of solAssert when applicable	2018-04-18 13:17:59 +02:00
Leonardo Alt	ae3350ae03	[SMTChecker] Integration with CVC4	2018-04-17 12:26:58 +01:00
chriseth	3d04d83297	Merge pull request #3868 from ethereum/bytescleanup ... Properly force-clean for shortening bytesXX conversions.	2018-04-16 15:23:36 +02:00
chriseth	533d08517f	Merge pull request #3793 from ethereum/rationalNumberLimit ... Rational number limit	2018-04-16 13:10:50 +02:00
Alex Beregszaszi	0201492bbf	Remove redundant cleanup for abi.encode.	2018-04-16 12:47:38 +02:00
chriseth	4c1d39b7a2	Properly force-clean for shortening bytesXX conversions.	2018-04-16 12:47:38 +02:00
Erik Kundt	33fbf88707	Limits rational numbers to 4096 bits.	2018-04-16 11:45:55 +02:00
chriseth	d8030c9b2a	Merge pull request #3880 from ethereum/addressMemberDocAndWarn ... Improve documentation and warning about accessing contract members in…	2018-04-16 11:05:05 +02:00
chriseth	95c49b367e	Merge pull request #3875 from ethereum/constructorSelfRef ... Stricter check for "this" in constructor.	2018-04-13 18:39:31 +02:00
Daniel Kirchner	05c5ab19fb	Improve documentation and warning about accessing contract members inherited from address.	2018-04-13 18:26:24 +02:00
Daniel Kirchner	be37e3a912	Stricter check for member access to "this" in constructor.	2018-04-13 15:57:13 +02:00
Erik Kundt	8935c0dd2f	Uses short string representation of TypePointer	2018-04-12 21:14:50 +02:00
chriseth	7054defdd6	Merge pull request #3364 from ethereum/revertWithReason ... Revert with reason	2018-04-12 21:01:08 +02:00