cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Disable unused var warning for functions with empty body

Browse Source
This commit is contained in:
Leonardo Alt 2018-12-12 12:02:47 +01:00
parent 85291bcb2d
commit 53537864a2
16 changed files with 14 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
libsolidity/analysis/StaticAnalyzer.cpp
View File

@ -63,21 +63,21 @@ bool StaticAnalyzer::visit(FunctionDefinition const& _function)
void StaticAnalyzer::endVisit(FunctionDefinition const&)
{
m_currentFunction = nullptr;
m_constructor = false;
for (auto const& var: m_localVarUseCount)
if (var.second == 0)
{
if (var.first.second->isCallableParameter())
m_errorReporter.warning(
var.first.second->location(),
"Unused function parameter. Remove or comment out the variable name to silence this warning."
);
else
m_errorReporter.warning(var.first.second->location(), "Unused local variable.");
}
if (m_currentFunction && !m_currentFunction->body().statements().empty())
for (auto const& var: m_localVarUseCount)
if (var.second == 0)
{
if (var.first.second->isCallableParameter())
m_errorReporter.warning(
var.first.second->location(),
"Unused function parameter. Remove or comment out the variable name to silence this warning."
);
else
m_errorReporter.warning(var.first.second->location(), "Unused local variable.");
}
m_localVarUseCount.clear();
m_constructor = false;
m_currentFunction = nullptr;
}
bool StaticAnalyzer::visit(Identifier const& _identifier)

1
test/libsolidity/syntaxTests/nameAndTypeResolution/049_function_external_call_allowed_conversion.sol
View File

@ -7,5 +7,4 @@ contract Test {
function g (C c) external {}
}
// ----
// Warning: (125-128): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (113-141): Function state mutability can be restricted to pure

1
test/libsolidity/syntaxTests/nameAndTypeResolution/051_function_internal_allowed_conversion.sol
View File

@ -9,5 +9,4 @@ contract Test {
}
}
// ----
// Warning: (68-71): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (56-82): Function state mutability can be restricted to pure

1
test/libsolidity/syntaxTests/nameAndTypeResolution/057_legal_override_direct.sol
View File

@ -1,6 +1,5 @@
contract B { function f() public {} }
contract C is B { function f(uint i) public {} }
// ----
// Warning: (67-73): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (13-35): Function state mutability can be restricted to pure
// Warning: (56-84): Function state mutability can be restricted to pure

1
test/libsolidity/syntaxTests/nameAndTypeResolution/058_legal_override_indirect.sol
View File

@ -2,6 +2,5 @@ contract A { function f(uint a) public {} }
contract B { function f() public {} }
contract C is A, B { }
// ----
// Warning: (24-30): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (13-41): Function state mutability can be restricted to pure
// Warning: (57-79): Function state mutability can be restricted to pure

1
test/libsolidity/syntaxTests/nameAndTypeResolution/061_missing_base_constructor_arguments.sol
View File

@ -1,4 +1,3 @@
contract A { constructor(uint a) public { } }
contract B is A { }
// ----
// Warning: (25-31): Unused function parameter. Remove or comment out the variable name to silence this warning.

1
test/libsolidity/syntaxTests/nameAndTypeResolution/062_base_constructor_arguments_override.sol
View File

@ -1,4 +1,3 @@
contract A { constructor(uint a) public { } }
contract B is A { }
// ----
// Warning: (25-31): Unused function parameter. Remove or comment out the variable name to silence this warning.

1
test/libsolidity/syntaxTests/nameAndTypeResolution/216_function_argument_storage_to_mem.sol
View File

@ -6,5 +6,4 @@ contract C {
}
}
// ----
// Warning: (91-106): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (80-122): Function state mutability can be restricted to pure

1
test/libsolidity/syntaxTests/nameAndTypeResolution/437_warn_unused_function_parameter.sol
View File

@ -3,4 +3,3 @@ contract C {
}
}
// ----
// Warning: (28-34): Unused function parameter. Remove or comment out the variable name to silence this warning.

1
test/libsolidity/syntaxTests/nameAndTypeResolution/439_warn_unused_return_parameter.sol
View File

@ -3,4 +3,3 @@ contract C {
}
}
// ----
// Warning: (51-57): Unused function parameter. Remove or comment out the variable name to silence this warning.

3
test/libsolidity/syntaxTests/parsing/empty_function.sol
View File

@ -3,7 +3,4 @@ contract test {
function functionName(bytes20 arg1, address addr) public view returns (int id) { }
}
// ----
// Warning: (58-70): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (72-84): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (107-113): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (36-118): Function state mutability can be restricted to pure

2
test/libsolidity/syntaxTests/parsing/function_normal_comments.sol
View File

@ -4,6 +4,4 @@ contract test {
function functionName(bytes32 input) public returns (bytes32 out) {}
}
// ----
// Warning: (97-110): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (128-139): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (75-143): Function state mutability can be restricted to pure

3
test/libsolidity/syntaxTests/parsing/function_type_as_storage_variable_with_assignment.sol
View File

@ -3,7 +3,4 @@ contract test {
function (uint, uint) internal returns (uint) f1 = f;
}
// ----
// Warning: (31-37): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (39-45): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (63-69): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (20-73): Function state mutability can be restricted to pure

3
test/libsolidity/syntaxTests/parsing/function_type_in_expression.sol
View File

@ -5,9 +5,6 @@ contract test {
}
}
// ----
// Warning: (31-37): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (39-45): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (63-69): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (108-156): Unused local variable.
// Warning: (20-73): Function state mutability can be restricted to pure
// Warning: (78-167): Function state mutability can be restricted to pure

8
test/libsolidity/syntaxTests/parsing/multiple_functions_natspec_documentation.sol
View File

@ -10,14 +10,6 @@ contract test {
function functionName4(bytes32 input) public returns (bytes32 out) {}
}
// ----
// Warning: (97-110): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (128-139): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (203-216): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (234-245): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (304-317): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (335-346): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (410-423): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (441-452): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (74-143): Function state mutability can be restricted to pure
// Warning: (180-249): Function state mutability can be restricted to pure
// Warning: (281-350): Function state mutability can be restricted to pure

2
test/libsolidity/syntaxTests/parsing/single_function_param.sol
View File

@ -3,6 +3,4 @@ contract test {
function functionName(bytes32 input) public returns (bytes32 out) {}
}
// ----
// Warning: (58-71): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (89-100): Unused function parameter. Remove or comment out the variable name to silence this warning.
// Warning: (36-104): Function state mutability can be restricted to pure