cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Change invalid (not exactly 160 bits long) address literal to error

Browse Source
This commit is contained in:
Jason Cobb 2018-02-15 23:24:32 -05:00 committed by Alex Beregszaszi
parent 3d88eca531
commit 51567c0513
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
libsolidity/analysis/TypeChecker.cpp
View File

@ -2287,10 +2287,17 @@ void TypeChecker::endVisit(Literal const& _literal)
if (_literal.looksLikeAddress())
{
if (_literal.passesAddressChecksum())
_literal.annotation().type = make_shared<IntegerType>(160, IntegerType::Modifier::Address);
else
m_errorReporter.warning(
// Assign type here if it even looks like an address. This prevents double error in 050 mode for invalid address
_literal.annotation().type = make_shared<IntegerType>(160, IntegerType::Modifier::Address);
if (_literal.value().length() != 42) // "0x" + 40 hex digits
m_errorReporter.syntaxError(
_literal.location(),
"This looks like an address but is not exactly 20 bytes long. Current length is " +
to_string(_literal.value().length()) + " (should be 42)."
);
else if (!_literal.passesAddressChecksum())
m_errorReporter.syntaxError(
_literal.location(),
"This looks like an address but has an invalid checksum. "
"If this is not used as an address, please prepend '00'. " +