2529 Commits

Author	SHA1	Message	Date
Daniel Kirchner	9b4546c487	Add workarounds for building against CVC4 on ArchLinux.	2018-08-08 19:02:59 +02:00
Alex Beregszaszi	551343ae3e	Merge pull request #4665 from mattaereal/cmake-patch-solver ... cmake option added to make solvers optional	2018-08-08 17:58:01 +01:00
Alex Beregszaszi	9d782cc39c	Merge pull request #4770 from ethereum/throw-codegen ... Remove code generation for Throw statement	2018-08-08 17:55:27 +01:00
Alex Beregszaszi	bb071f3075	Merge pull request #4769 from ethereum/inlineasm-overloading-resolution ... Provide nicer error message when referencing overloaded references	2018-08-08 17:55:10 +01:00
Alex Beregszaszi	a9819aa8bc	Remove code generation for Throw statement ... It is disallowed in the type system.	2018-08-08 17:02:25 +01:00
Matías Aereal Aeón	4b20708c49	cmake flags to make solvers optional. Implementation of #4651	2018-08-08 12:43:57 -03:00
Alex Beregszaszi	9062704054	Merge pull request #4753 from mattaereal/boost-to-string-patch ... Replace boost:lexical_cast<std::string> for std::to_string.	2018-08-08 16:07:25 +01:00
Alex Beregszaszi	3c791d637d	Provide nicer error message when referencing overloaded references	2018-08-08 15:59:24 +01:00
Alex Beregszaszi	efeffa8083	Merge pull request #4761 from ethereum/libsolc-exceptions ... Mark libsolc external C functions as noexcept	2018-08-08 15:56:12 +01:00
Matías Aereal Aeón	e902ce1aa0	Removing std:: from std::to_string and include for boost/lexical_cast	2018-08-08 11:26:30 -03:00
Alex Beregszaszi	1bfb841771	Remove experimental 0.5.0 pragma	2018-08-08 14:05:36 +01:00
chriseth	de8e9114fd	Merge pull request #4740 from ethereum/enforceNumberOfReturnValues ... Disallow empty return in function with return arguments.	2018-08-08 14:59:09 +02:00
Alex Beregszaszi	5b4ad10b3c	Mark StandardCompiler::compile as noexcept ... It has a generic catch statement and shouldn't leak out exceptions.	2018-08-08 13:22:40 +01:00
Christian Parpart	b9222808f6	Cleanup & polish numbers-with-underscores parsing, also improving tests.	2018-08-08 13:38:46 +02:00
chriseth	d0863f4994	Merge pull request #4748 from ethereum/validate-identifier ... Assert that type identifier contains only valid characters	2018-08-08 12:50:45 +02:00
chriseth	fd12c718f6	Merge pull request #4745 from ethereum/nameResolverNoEarlyExit ... Do not stop after the first error in reference resolution.	2018-08-08 12:49:46 +02:00
Alex Beregszaszi	64e3c9913f	Merge pull request #4736 from ethereum/removeFillRight ... Remove remaining instances of ``fillRight``.	2018-08-08 11:27:37 +01:00
Balajiganapathi S	09a36cba02	Add stricter hex underscore rules	2018-08-08 12:05:51 +02:00
Balajiganapathi S	0000bfc604	Allow underscores in numbers.	2018-08-08 12:05:51 +02:00
Matías Aereal Aeón	7dae58cbcc	Replace boost:lexical_cast<std::string> for std::to_string.	2018-08-08 03:55:43 -03:00
Alex Beregszaszi	3064bd17bc	Assert that type identifier contains only valid characters	2018-08-07 22:29:21 +01:00
Alex Beregszaszi	4dc3335cda	Merge pull request #4744 from ethereum/smt-magic-variable ... SMT: do not crash on referencing MagicVariableDeclaration	2018-08-07 21:30:14 +01:00
chriseth	43d6a9d763	Do not stop after the first error in reference resolution.	2018-08-07 22:04:59 +02:00
Alex Beregszaszi	f024efb7ab	SMT: do not crash on referencing MagicVariableDeclaration	2018-08-07 20:43:20 +01:00
Daniel Kirchner	cc83e69469	Disallow empty return expressions in functions with non-empty return parameters.	2018-08-07 20:48:07 +02:00
Daniel Kirchner	b11e39e25e	Remove remaining instances of `fillRight` left over from tuple wildcards assignments.	2018-08-07 18:51:53 +02:00
chriseth	d7756322c0	Merge pull request #4731 from ethereum/interface-enum ... Allow enums in interfaces	2018-08-07 17:20:05 +02:00
chriseth	901550e473	Merge pull request #4692 from ethereum/devcore-path ... Move absolutePath/sanitizePath helpers from CompilerStack to libdevcore	2018-08-07 16:15:49 +02:00
chriseth	a949cffd24	Merge pull request #4699 from ethereum/cleanup_VariableDeclaration ... libsolidity: Remove dead code wrt. VariableDeclaration::canHaveAutoType	2018-08-07 16:14:41 +02:00
chriseth	c61cc98d0d	Merge pull request #4726 from ethereum/moveNothrow ... Make MemberList nothrow move constructible.	2018-08-07 16:11:59 +02:00
Alex Beregszaszi	a765b5b31c	Merge pull request #4720 from ethereum/abi-rational-type-identifier ... Fix type identifiers for RationalNumberType (on negative numbers)	2018-08-07 14:25:11 +01:00
Alex Beregszaszi	13e37df97c	Allow enums in interfaces	2018-08-07 13:28:53 +01:00
Alex Beregszaszi	b0f9fc5af0	Fix type identifiers for RationalNumberType	2018-08-07 13:23:14 +01:00
chriseth	133fd3d302	Make MemberList nothrow move constructible.	2018-08-07 14:20:18 +02:00
Alex Beregszaszi	05cc7e79e1	More precise error message if using non-variables with _slot/_offset	2018-08-07 13:18:54 +01:00
Alex Beregszaszi	eb7b3862ac	Properly handle invalid references used together with _slot and _offset.	2018-08-07 13:18:38 +01:00
Alex Beregszaszi	8b2d630275	Merge pull request #4724 from ethereum/slot-in-assembly ... Do not crash on using _slot and _offset suffixes on their own	2018-08-07 12:55:40 +01:00
Alex Beregszaszi	296ba24f7f	Do not crash on using _slot and _offset suffixes on their own	2018-08-07 12:14:12 +01:00
chriseth	71e26f6adb	Remove clone feature.	2018-08-07 11:10:50 +01:00
Christian Parpart	4c90ddf64a	libsolidity: Remove dead code wrt. VariableDeclaration::canHaveAutoType() ... Closes #4667	2018-08-07 11:34:13 +02:00
Alex Beregszaszi	bd75d4268b	Move fullyQualifiedName to ContractDefinition only	2018-08-06 18:58:27 +02:00
chriseth	276724dedc	Merge pull request #4663 from ethereum/dropConstantAST ... [BREAKING] Drop constant field from JSON AST	2018-08-06 18:55:12 +02:00
Alex Beregszaszi	eccc603291	FixedBytes(0) is invalid, do not check for it in ABIEncoderV2	2018-08-06 16:54:05 +02:00
chriseth	bc73617f5e	Merge pull request #4689 from ethereum/cleanup-050-tests ... Cleanup 0.5.0 test cases	2018-08-06 14:45:31 +02:00
Alex Beregszaszi	3de0b8b7f0	Move absolutePath/sanitizePath helpers from CompilerStack to libdevcore	2018-08-06 12:54:22 +01:00
Alex Beregszaszi	3481d4e2ec	Merge pull request #4690 from ethereum/equalParameterTypes ... Renamed FunctionType::hasEqualArgumentTypes to FunctionType::hasEqual…	2018-08-06 12:50:04 +01:00
Jesse Busman	3fcd62921e	Renamed FunctionType::hasEqualArgumentTypes to FunctionType::hasEqualParameterTypes	2018-08-06 13:05:06 +02:00
Alex Beregszaszi	08e431f94e	Remove unused 050 variable in ReferencesResolver	2018-08-06 12:03:00 +01:00
chriseth	9d03de1f25	Merge pull request #4671 from ethereum/mappingTupleAssignment ... Disallow assignments to mappings within tuple assignments; allow for local variables.	2018-08-06 12:59:16 +02:00
chriseth	3576980710	Merge pull request #4644 from ethereum/event_struct_error ... Disallow structs in events without ABIEncoderV2	2018-08-06 11:44:05 +02:00
chriseth	30f981fc2c	Merge pull request #4681 from ethereum/var-suggestion-crash ... Fix declaration suggestion for var with different number of components	2018-08-06 11:21:54 +02:00
Daniel Kirchner	44374a5846	Remove "constant" from JSON AST.	2018-08-06 11:15:25 +02:00
Alex Beregszaszi	83e6c34526	Fix declaration suggestion for var with different number of components	2018-08-04 15:22:22 +01:00
Christian Parpart	a4ee1dfc83	Merge pull request #4412 from ethereum/v050-reference-resolver-errorTypeForLoose ... [BREAKING] permanently set errorTypeForLoose from Warning to SyntaxError	2018-08-03 19:30:33 +02:00
Daniel Kirchner	f9b90feea0	Review suggestions; to be squashed.	2018-08-03 17:38:06 +02:00
Daniel Kirchner	1e4b5886d6	Allow assignments to local variables of mapping types.	2018-08-03 16:22:03 +02:00
Daniel Kirchner	c0a169ca90	Disallow assignments to mappings within tuple assignments.	2018-08-03 15:46:26 +02:00
Leonardo Alt	20c6cea7bb	Disallow structs in events without ABIEncoderV2	2018-08-03 13:41:27 +02:00
Daniel Kirchner	35c5b7de25	Turn warning about uninitialized storage returns into an error.	2018-08-02 19:34:38 +02:00
chriseth	009a55c82d	Merge pull request #4327 from ethereum/document-internals ... Properly explain all the analsys steps in CompilerStack	2018-08-02 15:07:35 +02:00
chriseth	90a5928b88	Merge pull request #4522 from ethereum/fullEncodingType ... Isolate determining the encoding type into its own function.	2018-08-02 15:01:38 +02:00
Christian Parpart	5d9320c70b	Disallow loos assembly in Solidity by permanently setting it to SyntaxError (from Warning)	2018-08-02 13:36:05 +01:00
Alex Beregszaszi	6003ed2abd	Merge pull request #4603 from ethereum/smtlib2 ... [SMTLib2] Fix repeated declarations	2018-08-02 12:04:58 +01:00
Leonardo Alt	90f319615f	SMT model variables are sorted and printed as secondary source location	2018-08-01 23:27:46 +02:00
Leonardo Alt	b6a2655513	Replace "value" by "<result>" in the SMT model	2018-08-01 23:27:11 +02:00
Daniel Kirchner	ce7c7aca79	Extend code comment about signatures.	2018-08-01 17:18:17 +02:00
Daniel Kirchner	30d9961efb	Do not exclude public state variables when looking for conflicting declarations.	2018-08-01 14:31:04 +02:00
Alex Beregszaszi	ce99a5ce7f	Merge pull request #4378 from ethereum/noBaseWithoutArguments ... [BREAKING] Disallow calling base constructors without arguments.	2018-08-01 13:18:37 +01:00
chriseth	061ea0cfc6	Correctly determine whether base constructor is called without parentheses.	2018-08-01 12:28:27 +01:00
chriseth	7e5406dd89	Disallow calling base constructors without arguments.	2018-08-01 12:28:27 +01:00
Christian Parpart	38f9667e09	Guard CycleDetector against recursion exhaustion. ... fixes #3935.	2018-08-01 12:02:59 +01:00
chriseth	7a8a243eef	Isolate determining the encoding type into its own function.	2018-08-01 11:55:57 +01:00
chriseth	c8232d9759	Disallow conversion between unrelated contract types.	2018-08-01 11:04:35 +01:00
Alex Beregszaszi	21888e246b	Merge pull request #4507 from ethereum/v050-var-keyword-trace-removals ... Ensures an empty use of var keyword is caught with the proper non-fatal error message	2018-08-01 10:59:26 +01:00
Leonardo Alt	41ac3d6cfb	Remove repeated declarations in Z3 and CVC4 as well	2018-08-01 11:12:56 +02:00
Christian Parpart	a7150f85a6	Ensures an empty use of var keyword is caught with the proper error message.	2018-08-01 09:59:06 +02:00
Leonardo Alt	210fee571f	Fix crash when FunctionType has undeclared type as parameter	2018-07-31 11:17:51 +02:00
Alex Beregszaszi	f74cff622d	Properly explain all the analsys steps in CompilerStack	2018-07-31 00:39:18 +01:00
Alex Beregszaszi	179427fd65	Import dev::solidity namespace in SMTPortfolio	2018-07-27 23:17:17 +01:00
Leonardo Alt	f249f9c86f	[SMTLib2] Fix repeated declarations	2018-07-27 17:34:44 +01:00
Alex Beregszaszi	dea0567e06	Fix unterminated parentheses typo in SMTLib2 ... Found by @leonardoalt	2018-07-27 17:33:53 +01:00
Leonardo Alt	55c1fb60b4	[SMTChecker] Add CheckResult::CONFLICTING	2018-07-27 16:16:26 +01:00
Leonardo Alt	87a38e1abe	[SMTChecker] SMTPortfolio: use all SMT solvers available	2018-07-27 16:15:34 +01:00
Leonardo Alt	b356f6a7f9	Setting timeout to Z3 and CVC4	2018-07-27 16:01:48 +02:00
Leonardo Alt	06dbcb3afe	Only ask for a model if it's SAT	2018-07-27 14:13:22 +02:00
Alex Beregszaszi	ae15b52d93	Merge pull request #4565 from ethereum/smt-stringutils-crash ... Add assert for both branches in mergeVariables in SMTChecker	2018-07-25 11:08:47 +01:00
Alex Beregszaszi	a5a61a0b77	More consistent catch statements ... Also take const& in all cases.	2018-07-25 01:18:09 +01:00
Alex Beregszaszi	d30a6de942	Add better warning on binary operation on non-integer types in SMT Checker	2018-07-24 23:23:54 +01:00
Alex Beregszaszi	278372c13d	Add assert for both branches in mergeVariables in SMTChecker	2018-07-24 22:43:05 +01:00
Leonardo Alt	a2f03ea9e5	Fix abiDecode comment	2018-07-23 23:31:02 +02:00
Alex Beregszaszi	de90290c28	Merge pull request #4527 from ethereum/mappingEnforceStorage ... Enforces explicit data location for mappings	2018-07-23 20:43:38 +01:00
Erik Kundt	c622a1e56c	Enforces data location of local mappings to storage.	2018-07-23 19:30:07 +02:00
Christian Parpart	9f35f0b805	Disallow functions without implementation to use modifiers. This was already the case in the experimental 0.5.0 mode.	2018-07-23 17:29:08 +01:00
chriseth	3fa0ac5822	Do not handle balance member of contract types specially.	2018-07-20 10:50:05 +02:00
chriseth	e3c2f20f6e	Merge pull request #4439 from ethereum/address_members ... [BREAKING] Enforce address members not accessible by contract instance	2018-07-19 09:24:27 +02:00
Leonardo Alt	faa9c221d4	Changes in ExpressionCompiler	2018-07-18 19:51:24 +02:00
Erik Kundt	b0b35e1e6b	Adds warning if function is shadowing a contract.	2018-07-18 14:29:01 +02:00
Erik Kundt	182a0a9551	Disallows old constructor syntax.	2018-07-18 14:29:01 +02:00
chriseth	dfd2fee91d	Suggests external for fallback and interface functions.	2018-07-17 18:07:36 +02:00
Erik Kundt	b5ecfbe5bc	Enforces visibility specifier and updates docs.	2018-07-17 17:44:51 +02:00
Leonardo Alt	563e0fc9a7	Add suggestion to error message	2018-07-17 16:38:36 +01:00
Leonardo Alt	0075f4239a	Address members not accessible by contract instance	2018-07-17 13:33:23 +01:00
Leonardo Alt	fdfdddd8dc	Add missing period in the end of error messages	2018-07-16 16:11:39 +01:00
Alex Beregszaszi	21e97da294	Deprecate the throw statement	2018-07-16 15:33:20 +02:00
Christian Parpart	396bf11858	enforce interface-functions to be external-declared ... - libsolidity: Enforce interface-functions must be external-declared. - Changelog adapted to reflect changes wrt. functions in interfaces. - test: Adjustments according to prior interface-function changes. - tests: Adapting SolidityEndToEndTest to interface-function change. - docs: Adapted documentation to interface-function change.	2018-07-16 12:15:36 +02:00
chriseth	bab4a3975f	Merge pull request #4501 from ethereum/recursiveStructsWithFixedArrays ... Consider fixed-size arrays when checking for recursive structs.	2018-07-13 01:26:50 +02:00
Daniel Kirchner	fc370591f0	Disallow multi variable declarations with mismatching number of values.	2018-07-12 20:33:51 +02:00
Daniel Kirchner	d71a023c0b	Use CycleDetector and account for multi-dimensional arrays.	2018-07-12 20:14:02 +02:00
Daniel Kirchner	d4dfd28694	Consider fixed size array members when checking for recursive structs.	2018-07-12 20:14:02 +02:00
chriseth	5d8a8f7265	Merge pull request #4437 from ethereum/report-empty-var-decls ... [BREAKING] Report empty var tuple decls	2018-07-12 19:22:38 +02:00
chriseth	6dcafac44e	Merge pull request #4447 from hosho/develop ... Fix NatSpec json output for "@notice" and "@dev" tags on contract definitions	2018-07-12 18:42:30 +02:00
chriseth	81271801b4	Merge pull request #4478 from ethereum/requireStorageLocation ... Turn missing storage locations into an error.	2018-07-12 18:00:05 +02:00
Alex Beregszaszi	0dd79bc172	Merge pull request #4479 from ethereum/fixFixedPointCrash ... Fix handling of fixed point types in arithmetics.	2018-07-12 15:04:16 +01:00
Matt Little	4efe3544f7	Fix NatSpec json output for "@notice" and "@dev" tags on contract definitions.	2018-07-12 14:39:13 +02:00
Christian Parpart	cc585138bc	Generates a syntax error when declaring a variable declaration's LHS has no named components	2018-07-12 13:26:52 +02:00
chriseth	fa8102880f	Merge pull request #4428 from ethereum/enforce_staticcall_view ... [BREAKING] Enforce STATICCALL for view and pure	2018-07-12 13:14:02 +02:00
chriseth	576f3ef18c	Merge pull request #4083 from ethereum/variable_stack_slot ... [BREAKING] Allocate local variables according to their scope	2018-07-12 13:01:15 +02:00
Daniel Kirchner	a1f54f4e40	Require storage location.	2018-07-12 12:48:18 +02:00
chriseth	99bee7e233	Merge pull request #4443 from ethereum/double_var_decl_fix ... Fix crash when declaring the same var twice in the same scope	2018-07-12 00:05:32 +02:00
chriseth	2b8091526f	Merge pull request #4472 from ethereum/complexCalldataArraysNotYetImplemented ... Throw unimplemented exception for complex calldata arrays.	2018-07-11 23:48:42 +02:00
chriseth	0c9645c978	Merge pull request #4480 from ethereum/fixZeroWithExponent ... Fix literals with exponents with mantissa of zero.	2018-07-11 23:45:41 +02:00
Christian Parpart	08345209e6	Merge pull request #4404 from ethereum/v050-var-keyword-suggest ... [WIP] v0.5.0 var keyword type suggestion	2018-07-11 16:33:09 +02:00
Daniel Kirchner	e8e5e12ad2	Fix literals with exponents with mantissa of zero.	2018-07-11 15:34:17 +02:00
chriseth	7355298c2f	Fix handling of fixed point types in arithmetics.	2018-07-11 14:56:53 +02:00
Leonardo Alt	38026d3114	Use STATICCALL for view and pure	2018-07-11 14:45:22 +02:00
chriseth	f3abfa81ad	Merge pull request #4454 from ethereum/constructorArgCount ... [BREAKING] Wrong argument count in constructor call	2018-07-11 14:45:05 +02:00
chriseth	238dbe1b99	Merge pull request #4388 from ethereum/noPackedLiterals ... Disallow packed encoding of literals.	2018-07-11 14:28:20 +02:00
Erik Kundt	7c7e154a7b	Improves error with suggestion to remove parantheses.	2018-07-11 01:58:17 +02:00
Erik Kundt	34a031609e	Updates Changelog, syntax test and simplifies type checker.	2018-07-11 01:58:17 +02:00
Erik Kundt	0b960f5a9c	Turns wrong argument count in base constructor call into en error.	2018-07-11 01:56:07 +02:00
Cryptomental	140dbfdbd8	Code, Changelog, ReleaseChecklist: Fix typos. ... Refs: #4442	2018-07-11 00:26:23 +02:00
chriseth	458a4c8aa5	Coding style.	2018-07-10 22:29:53 +02:00
Christian Parpart	1505e28b56	semantics: Suggest auto-deduced type when user declares variable with var keyword.	2018-07-10 22:14:19 +02:00
chriseth	d84976dc87	Merge pull request #4376 from ethereum/fallbackExternal ... Fallback functions have to be external	2018-07-10 21:39:25 +02:00
chriseth	383b88793c	Throw unimplemented exception for complex calldata arrays.	2018-07-10 21:23:20 +02:00
chriseth	12045d2e11	Merge pull request #4464 from cryptomental/bugfix/fix-typos-in-AsmParser-and-TypeChecker ... AsmParser,TypeChecker: Fix typos.	2018-07-10 21:07:56 +02:00
chriseth	6567cd3e51	Merge pull request #4466 from ethereum/tupleNotEmpty ... Disallow empty tuple components.	2018-07-10 21:03:30 +02:00
Leonardo Alt	cee4775a58	Add comment explaining new code	2018-07-10 18:54:46 +02:00
Leonardo Alt	c286cdaa62	Fix crash for double variable declaration in the same scope.	2018-07-10 18:54:46 +02:00
Leonardo Alt	0c5e0e0d59	Added assertion and tests suggestions	2018-07-10 18:39:38 +02:00
Leonardo Alt	b750ca9741	Add more tests and assertions	2018-07-10 18:39:38 +02:00
Leonardo Alt	9d895e002d	Added tests and review suggestions	2018-07-10 18:39:38 +02:00
Leonardo Alt	1f77deada1	[050] Reserving and popping local vars in their scope	2018-07-10 18:39:38 +02:00
chriseth	0e9415bc31	Merge pull request #4468 from ethereum/variableDeclarationClenaup ... Remove mentions of ``var`` in VariableDeclarationStatement comment.	2018-07-10 17:50:02 +02:00
Christian Parpart	8ca69ed8d8	defaulting to v0.5.0 behaviour of unary + operator (disallow); also adapting all tests to it	2018-07-10 16:27:57 +02:00
chriseth	64abfd3e4a	Remove special `(x,)` case from type assignment.	2018-07-10 15:58:46 +02:00
Daniel Kirchner	a6e5a51d61	Disallow empty tuple components.	2018-07-10 15:27:46 +02:00
chriseth	7650905567	Merge pull request #4415 from ethereum/uninitializedStoragePointer ... [BREAKING] Turn uninitialized storage variables into error.	2018-07-10 15:24:01 +02:00
chriseth	187eef36ad	Remove mentions of `var` in VariableDeclarationStatement comment.	2018-07-10 14:55:50 +02:00
Cryptomental	a55abb550d	AsmParser,TypeChecker: Fix typos. ... Fix typos. The change requested as a separate PR during codespell PR. Adapt tests as well. Refs: #4442	2018-07-10 12:33:19 +02:00
Daniel Kirchner	ece9afef8f	Check for matching number of components in TupleType::isImplicitlyConvertibleTo instead of the TypeChecker.	2018-07-10 12:17:01 +02:00
Daniel Kirchner	fe1d5da2a6	Turn uninitialized storage variables into an error.	2018-07-10 11:37:45 +02:00
Leonardo Alt	c1b67a845b	Enforce error on hex number combined with unit denomination	2018-07-09 17:19:41 +02:00
chriseth	f3e0bf1dd8	Merge pull request #4418 from ethereum/initialConstants ... Only allow compile-time constants for constant state variables.	2018-07-05 17:07:32 +02:00
chriseth	c8ac861832	Fix allocation of byte arrays.	2018-07-05 14:18:14 +02:00
chriseth	4a332ab324	Merge pull request #4409 from ethereum/viewPureChecker ... Enforce state mutability in view pure checker.	2018-07-04 14:09:46 +02:00
Leonardo Alt	8202d512e0	Enforcing error on msg.gas and block.blockhash()	2018-07-04 11:42:05 +02:00
Daniel Kirchner	7ea8365ab0	Remove v050 check for enforcing "view" in ViewPureChecker.	2018-07-04 10:14:58 +02:00
chriseth	8ed3da1d5f	Only allow compile-time constants for constant state variables.	2018-07-03 23:03:26 +02:00
chriseth	87241fd58c	Fallback function has to be external.	2018-07-03 22:51:36 +02:00
chriseth	533d5d4b1c	Merge pull request #4379 from ethereum/constructorArgsTwice ... Disallow constructor arguments given multiple times.	2018-07-03 22:49:02 +02:00
Daniel Kirchner	3984beef7d	Remove constant keyword from parser.	2018-07-03 15:31:34 +02:00
Christian Parpart	1486d215b9	libsolidity: turns the var-keyword use from deprecation-warning to an error and include explicit type suggestion	2018-07-03 10:53:09 +02:00
chriseth	f7a9c4203e	Disallow packed encoding of literals.	2018-07-03 01:02:00 +02:00
Daniel Kirchner	9aefe2f118	Remove trailing whitespace in missing visibility warning.	2018-07-02 13:14:58 +02:00
chriseth	85b9d3927a	Merge pull request #4224 from ethereum/revert_wrong_calldata ... [BREAKING] Revert if calldata has wrong size	2018-07-02 12:55:22 +02:00
chriseth	f69e24c85e	Disallow constructor arguments given multiple times.	2018-06-29 16:11:21 +02:00
chriseth	d469df45d8	Merge pull request #4352 from D-Nice/develop ... Fixes storage ref var typo error from 'prefix' to 'suffix'	2018-06-29 12:27:29 +02:00
chriseth	4a842ecc82	Merge pull request #4097 from ethereum/noPackedExceptForPacked ... [BREAKING] call only takes a single argument and does not pad	2018-06-27 18:29:01 +02:00
chriseth	92cb4acd8a	Also mention regular abi.encode in error message.	2018-06-27 15:00:34 +02:00
Alex Beregszaszi	80b7d36187	Remove non-0.5.0 warning for emit keyword (make it mandatory)	2018-06-26 20:00:54 +02:00
chriseth	503eb8caa5	Merge pull request #4342 from rnaby/l/a/Types ... RationalNumberType::isImplicitlyConvertibleTo Refactor	2018-06-26 17:54:09 +02:00
Leonardo Alt	7763d21cc6	Revert if calldata is too short or points out of bounds	2018-06-26 10:27:48 +02:00
Alex Beregszaszi	5aa8c7ed1a	Document the internal API of CompilerStack	2018-06-25 23:51:40 +02:00
Alex Beregszaszi	3fc7da11db	Pull out createCBORMetadata helper	2018-06-25 22:17:33 +02:00
chriseth	033672cc48	Fix: Call functions do not take variable arguments.	2018-06-25 17:17:48 +02:00
chriseth	5cf6fa84ac	Provide better suggestions in error messages with respect to call and hash functions.	2018-06-25 17:17:48 +02:00
chriseth	a55e8c93ce	Save double encode call for sha3.	2018-06-25 17:17:18 +02:00
D-Nice	b2f0d1db43	Fixes storage ref var typo error from 'prefix' to 'suffix'	2018-06-25 11:14:19 -04:00
chriseth	23c4142005	Bare functions take single bytes argument.	2018-06-25 17:01:45 +02:00
chriseth	0e66a1ddde	Single bytes argument. ... In 0.5.0 mode, only accept a single bytes argument for ``.call``, ``keccak256`` and others and do not pad when encoding.	2018-06-25 17:01:45 +02:00
Alex Beregszaszi	6d9a091a8e	Keep the 'if it not used as an address' helper message for all cases of address related warnings	2018-06-25 16:25:21 +02:00
Alex Beregszaszi	48b003d4d4	Better wording for invalid address literal error	2018-06-25 16:17:50 +02:00
Jason Cobb	51567c0513	Change invalid (not exactly 160 bits long) address literal to error	2018-06-25 16:17:50 +02:00
Jason Cobb	3d88eca531	Disallow implicit conversion from rational (literal) to address	2018-06-25 16:17:50 +02:00
Khan M Rashedun-Naby	097a3fabf4	RationalNumberType::isImplicitlyConvertibleTo Refactor	2018-06-24 08:15:25 +06:00
Alex Beregszaszi	72e87423db	Disallow the years unit denomination properly	2018-06-21 20:21:02 +02:00
chriseth	32f2db780c	Merge pull request #4301 from rnaby/TypeChecker ... Simplification of typeSupportedByOldABIEncoder	2018-06-21 18:53:31 +02:00
chriseth	2c456f0e70	Merge pull request #4326 from ethereum/compilerstack-cleanup ... Properly catch optimizer/assembly exception in CompilerStack	2018-06-21 14:14:13 +02:00
chriseth	0d1047181d	Merge pull request #4306 from ethereum/remove_050_workaround_scoping ... [BREAKING] C99 scoping rules by default (remove 050 workaround)	2018-06-21 13:57:59 +02:00
Alex Beregszaszi	7e4bd3e346	Merge pull request #4219 from ethereum/functionTypeNamedArguments ... Turn named return parameters in function types into an error.	2018-06-20 23:51:19 +02:00
Alex Beregszaszi	a392e0f046	Properly catch optimizer/assembly exception in CompilerStack	2018-06-20 23:19:06 +02:00
Khan M Rashedun-Naby	a5f0caa178	Simplification of typeSupportedByOldABIEncoder	2018-06-20 23:16:21 +06:00
Alex Beregszaszi	0a632011be	CompilerStack absolutePath/sanitizePath can be made static	2018-06-20 17:04:22 +02:00
Alex Beregszaszi	dcee8e11ad	Reorder some of the flow in CompilerStack::compileContract for readability	2018-06-20 17:01:17 +02:00
Leonardo Alt	8862b3092b	C99 scoping rules by default	2018-06-20 12:53:38 +02:00
Alex Beregszaszi	a17059573f	Disallow raw callcode (was deprecated in 0.4.12)	2018-06-19 19:31:07 +02:00
Daniel Kirchner	dbfee87860	Return parameters in function types may not be named.	2018-06-18 00:05:06 +02:00
Alex Beregszaszi	4cdb6c809a	Change comments	2018-06-14 09:31:28 +01:00
Alex Beregszaszi	e1d0bfe1ca	JuliaType -> YulType	2018-06-14 09:31:28 +01:00
Alex Beregszaszi	e0d95a6641	Rename internal variable	2018-06-14 09:31:28 +01:00
Alex Beregszaszi	782bc41dbd	Rename JULIA/IULIA to Yul in assembly interface	2018-06-14 09:31:28 +01:00
Christian Parpart	a211b89118	Enforce disallowing empty structs ... This patch enfoces an error when it encounters an empty struct, effectively eliminating the deprecation warning. Also adjust 419_interface_structs to explicitely test for (non-empty) structs, as this behaviour "may" change in the future.	2018-06-14 00:24:43 +01:00
chriseth	014bbc6c97	Merge pull request #4272 from ethereum/assert-break-continue ... Fail if break/continue statements are used outside for/while loops in ContractCompiler	2018-06-13 12:10:39 +02:00
chriseth	1dc28c065d	Properly pad data from calldata.	2018-06-12 18:51:40 +01:00
Alex Beregszaszi	9de45383d8	Disallow sha3/suicide aliases	2018-06-12 18:16:18 +01:00
Alex Beregszaszi	d1e7e9ef5e	Merge pull request #3627 from ethereum/additional-keywords ... [BREAKING] Add new reserved keywords.	2018-06-12 16:33:26 +01:00
Daniel Kirchner	e2f4a9fcf4	Merge pull request #4277 from ethereum/signedRightShift ... Signed Right Shift: Additional test and more explanation.	2018-06-12 17:19:20 +02:00
chriseth	cc62d7ce6a	Merge pull request #4229 from ethereum/smt_storage_vars_refactor ... Refactoring how storage and local variables are managed.	2018-06-12 16:11:05 +02:00
Daniel Kirchner	e4b7b2160e	Add new reserved keywords.	2018-06-12 16:02:53 +02:00
Daniel Kirchner	510f227bd7	Additional test and more explanation.	2018-06-12 15:53:15 +02:00
Leonardo Alt	207d5859d1	Refactoring Declaration -> VariableDeclaration (more precise)	2018-06-12 10:58:50 +02:00
Leonardo Alt	48652c88af	Review comments	2018-06-12 10:58:50 +02:00
Leonardo Alt	678a769cd7	Refactoring how storage and local variables are managed.	2018-06-12 10:58:50 +02:00
Daniel Kirchner	e84b55bd6f	Extend explanatory remark and argue using bitwise operations instead of rounding.	2018-06-12 09:32:19 +01:00
Daniel Kirchner	f33dc92cbd	Use proper SAR for signed right shifts and emulate on pre-constantinople.	2018-06-12 09:32:19 +01:00
Alex Beregszaszi	1d57d74e82	Fail if break/continue statements are used outside for/while loops in ContractCompiler	2018-06-12 00:46:23 +01:00
Erik Kundt	2e9f5d1c98	Introduces emit token and removes identifier workaround.	2018-06-11 21:21:22 +01:00
Alex Beregszaszi	8d38d4d296	Use boost::multiprecision::pow explicitly	2018-06-11 19:31:26 +01:00
Alex Beregszaszi	0f572159ec	Show named argument name in error	2018-06-06 15:59:27 +01:00
chriseth	4073c02cf3	Merge pull request #4208 from ethereum/extract-name-and-type-tests ... Extract name and type tests	2018-06-04 19:54:14 +02:00
chriseth	283cdef98c	Fix view/pure error ordering problem.	2018-06-04 17:00:37 +02:00
chriseth	c59a06bb97	Merge pull request #4213 from ethereum/fixpop ... Fix bug related to byte array pop.	2018-06-04 16:10:56 +02:00
Jason Cobb	6e29775d39	Remove suicide and sha3 assembly instructions	2018-06-04 01:04:48 +01:00
chriseth	7cf36331a6	Fix bug related to byte array pop.	2018-05-31 14:53:33 +02:00
chriseth	0a1a8bfb09	Merge pull request #4172 from ethereum/trailing_dot ... [BREAKING] Disallow trailing dot not followed by number	2018-05-30 18:51:52 +02:00
chriseth	5a73044fa7	Merge pull request #3743 from ethereum/popStorageArray ... pop() for storage arrays	2018-05-30 18:32:08 +02:00
Erik Kundt	fea0d116f7	Fixes assembly bug and adds tests to cover it.	2018-05-30 17:46:43 +02:00
Erik Kundt	98d52beba3	Adds syntax tests, documentation and changelog entry. ... Refines comment for array utility function.	2018-05-30 17:43:20 +02:00
Erik Kundt	34b5eca1f8	Improves assembly and adds more tests.	2018-05-30 17:40:33 +02:00
Leonardo Alt	ac68710789	Disallow trailing dots that are not followed by a number	2018-05-30 15:14:53 +01:00
mingchuan	b7cafcbdf9	Allow using calldata keyword to specify data location	2018-05-30 18:05:55 +08:00
Erik Kundt	7156a01acc	Implements pop() for byte arrays.	2018-05-29 12:53:02 +02:00
bitshift	e9dcfb0b62	Implements pop() for value type arrays.	2018-05-29 12:53:02 +02:00
chriseth	9d5064d04d	Merge pull request #4173 from sifmelcara/add/allow-storage-calldata-suffix ... Allow data location suffix for internal elementary type parsing	2018-05-28 22:52:45 +02:00
chriseth	5ee2ce353e	Merge pull request #4067 from ethereum/050 ... [BREAKING] Version 0.5.0	2018-05-23 18:11:20 +02:00
mingchuan	9865012f7b	Allow data location suffix for internal elementary type parsing	2018-05-22 23:28:12 +08:00
mingchuan	3cd57866a9	Fix assert message about function visibility	2018-05-20 22:29:11 +08:00
Julius Huelsmann	1d3a37faff	Avoid "unneccesary parentheses in declaration of" warning with keeping a temporary variable.	2018-05-17 14:48:15 +02:00
Julius Huelsmann	9e26f5fa0a	Do not catch exceptions by value in StandardCompiler	2018-05-17 14:44:01 +02:00
Daniel Kirchner	1cbc037a45	Update control flow graph.	2018-05-16 18:32:48 +02:00
Daniel Kirchner	f627dc77d0	Fix continue inside do-while.	2018-05-16 18:32:48 +02:00
Daniel Kirchner	5c59d56335	Disallow conversions between bytesX and uintY of different size.	2018-05-16 18:32:47 +02:00
Leonardo Alt	0b6eea0c55	Bool variables should not allow arithmetic comparison	2018-05-16 18:32:47 +02:00
Alex Beregszaszi	221a4d1f1f	Split warning for multi arguments for hash functions	2018-05-16 11:12:25 +02:00
chriseth	894122c508	Warn/enforce single bytes argument for certain builtins (hashing functions). ... In 0.5.0 mode, only accept a single bytes argument for ``.call``, ``keccak256`` and others and do not pad when encoding.	2018-05-16 09:48:03 +02:00
chriseth	3ca6738114	Add assert about source location.	2018-05-16 03:52:24 +02:00
chriseth	67d208d144	Parse multi variable declaration statement.	2018-05-16 03:22:45 +02:00
chriseth	2ba0002998	Merge pull request #4139 from ethereum/abiEncodeIsPure ... ABI encoding functions are pure and should be usable in constants.	2018-05-15 16:59:48 +02:00
chriseth	63861aac4a	Merge pull request #3947 from ethereum/smt_storage ... [SMTChecker] Support to integer and Bool storage vars	2018-05-15 14:54:41 +02:00
chriseth	dac0029d16	ABI encoding functions are pure and should be usable in constants.	2018-05-15 14:45:54 +02:00
chriseth	dce6224052	Merge pull request #4062 from ethereum/revert-variable ... Fix revert with reason coming from a string variable	2018-05-15 14:44:39 +02:00
Leonardo Alt	4117e859eb	[SMTChecker] Declaring all state vars before any function is visited	2018-05-15 14:28:08 +02:00
Leonardo Alt	2dbb35d4a8	[SMTChecker] Support to integer and Bool storage vars	2018-05-15 14:22:50 +02:00
Daniel Kirchner	16e966dea0	Add control flow analyzer and test for uninitialized storage returns.	2018-05-14 20:23:40 +02:00
Daniel Kirchner	995623f0fa	Add control flow graph.	2018-05-14 20:23:40 +02:00
mingchuan	dbd0a7ed60	Fix link error when using boost shared library	2018-05-11 11:20:19 +08:00
Alex Beregszaszi	e96bbe70d4	Assert that mandatory fields in the AST are present in AsmAnalysis	2018-05-10 10:48:48 +02:00
Alex Beregszaszi	c03a29dea8	Fix revert with reason coming from a string variable	2018-05-09 17:53:17 +02:00
Alex Beregszaszi	868d449c38	Merge pull request #4047 from ethereum/refactorToMulti ... Refactor to allow implementing multi variable declarations.	2018-05-09 15:37:19 +01:00
chriseth	fe8f38a7a4	Assert integrity of empty IndexAccessPath structure.	2018-05-09 14:55:36 +02:00
Daniel Kirchner	02380113d4	Use the entire token as source location for parser errors.	2018-05-09 14:08:22 +02:00
chriseth	be54f48197	Further refactor.	2018-05-09 11:48:21 +02:00
chriseth	86b7adc18f	Refactor expression parser.	2018-05-09 11:48:21 +02:00
chriseth	54aa10ce36	Merge pull request #4054 from ethereum/token-names ... Improve parser error messages	2018-05-09 11:06:23 +02:00
chriseth	fe12f05c08	Deprecate wildcard assignments.	2018-05-08 15:13:32 +01:00
njwest	51b4dc3752	fixed grammar in error in CompilerUtils.cpp line 399, 'less variables.' should be 'fewer variables.'	2018-05-06 18:52:12 -04:00
chriseth	150d226603	Merge pull request #4063 from ethereum/emit-non-event ... Show proper error when trying to emit a non-event	2018-05-04 15:02:04 +02:00
Alex Beregszaszi	cc10839073	Have more uniform parser errors	2018-05-04 13:27:05 +01:00
Alex Beregszaszi	c7ee649d80	More user friendly output in case of Identifier and Token keywords	2018-05-04 13:27:05 +01:00
Alex Beregszaszi	882248ce75	Remove code duplication in expectToken	2018-05-04 13:27:05 +01:00
Alex Beregszaszi	252bde8542	Introduce Token::friendlyName() helper	2018-05-04 13:11:23 +01:00
Alex Beregszaszi	e3279d8af8	Display nicer error messages in the parser (display tokens and not internal names)	2018-05-04 12:39:37 +01:00
chriseth	81d61ca086	Merge pull request #4059 from ethereum/parser-simplify ... Simplify the parser expectations	2018-05-04 12:50:12 +02:00
Alex Beregszaszi	ffe7f224a6	Show proper error when trying to emit a non-event	2018-05-04 12:47:01 +02:00
daniel	aa1542a9e1	Change bytes to unsigned in FixedBytesType	2018-05-03 23:11:34 +01:00
Alex Beregszaszi	ed9f80690b	Simplify expectIdentifierToken by using expectToken	2018-05-03 22:10:51 +01:00
Alex Beregszaszi	73c99d15cd	Remove useless helper expectAssignmentOperator in parser	2018-05-03 21:35:38 +01:00
Alex Beregszaszi	b34428249a	Change numBits to unsigned IntegerType	2018-05-02 23:22:25 -07:00
Alex Beregszaszi	2c00ebbee1	Change totalBits and fractionalDigits to unsigned in FixedPointType	2018-05-02 23:22:25 -07:00
chriseth	a856135bbf	Merge pull request #3797 from ethereum/shift-constantinople ... Use native shift instructions on Constantinople	2018-05-02 16:50:15 +02:00
chriseth	8debded743	Revert "BREAKING: Bool variables should not allow arithmetic comparison"	2018-05-02 15:56:59 +02:00
chriseth	42289b642f	Merge pull request #4003 from ethereum/bool_vars_comparison ... BREAKING: Bool variables should not allow arithmetic comparison	2018-05-02 15:56:06 +02:00
Alexander Arlt	f94b793472	Add virtual destructors on base classes.	2018-05-02 13:29:16 +02:00
Alex Beregszaszi	059e232e69	Support shifts in gas estimator	2018-04-30 21:22:59 +01:00
chriseth	2968639406	Removed signed shift right from the utilities.	2018-04-30 20:34:43 +01:00
Alex Beregszaszi	52c9441879	Do not use SAR instead of SDIV in shifts because it rounds differently	2018-04-30 20:34:43 +01:00
Alex Beregszaszi	c3608eaf90	Use native shift instructions in ABIFunctions on Constantinople	2018-04-30 20:34:43 +01:00
Alex Beregszaszi	22bfd3da41	Use native shift instructions on Constantinople	2018-04-30 20:34:43 +01:00
chriseth	d26b6b64c0	Merge pull request #3996 from ethereum/refactorParser ... Refactor parser.	2018-04-30 19:15:11 +02:00
chriseth	15024154ab	Merge pull request #4018 from ethereum/disable-bytes0 ... Disable FixedBytesType(0) aka bytes0	2018-04-30 18:19:07 +02:00
chriseth	9e61b25dc4	Merge pull request #3958 from meowingtwurtle/fixedPointTypes ... Types class changes for fixed points	2018-04-30 15:56:55 +02:00
Alex Beregszaszi	548bf2ff28	Remove unused function smallestTypeForLiteral	2018-04-30 14:35:26 +01:00
Alex Beregszaszi	e0b178e1c5	Disable FixedBytesType(0) aka bytes0	2018-04-30 12:23:30 +01:00
Leonardo Alt	ab251c7e7d	Bool variables should not allow arithmetic comparison	2018-04-27 11:35:58 +02:00
chriseth	d44fb03322	Refactor parser.	2018-04-26 10:59:02 +02:00
Alexander Arlt	3ec667f59b	Add virtual destructor in LValue class.	2018-04-24 23:39:25 +02:00
chriseth	d1e1293fbd	Merge pull request #3981 from ethereum/years-suffix ... The "year" denomination is deprecated	2018-04-24 12:12:03 +02:00
Alex Beregszaszi	258ae8927e	Merge pull request #3970 from elopio/test/docstring-tag-end ... docstring: add missing space	2018-04-24 02:16:27 +01:00
Leo Arias	b74566e4ea	docstring: add missing space	2018-04-23 21:47:53 +00:00
chriseth	e685f9f59e	Merge pull request #3976 from ethereum/emptyTupleComponent ... Empty tuple components should not be possible	2018-04-23 17:35:00 +02:00
Alex Beregszaszi	1ac0090f31	The "year" denomination is deprecated	2018-04-23 16:19:51 +01:00
Erik Kundt	896018c8a3	Treats inline array as an error.	2018-04-23 17:11:41 +02:00
Erik Kundt	b2ff9bc88d	Turns it into warning (error for 0.5.0) and adds Changelog entry.	2018-04-23 17:09:42 +02:00
Erik Kundt	f2b58de92c	Prevents null type from being used in tuple.	2018-04-22 16:54:33 +02:00
Alex Beregszaszi	5423974e87	Remove category check in FixedPointType:binaryOperatorResult as commonType handles the same	2018-04-20 17:54:34 +01:00
Jason Cobb	57003c534a	Types changes for fixed points	2018-04-20 17:53:42 +01:00
Alex Beregszaszi	0493e3b053	Turn deprecated warnings for sha3/suicide into errors (experimental 0.5.0)	2018-04-20 17:40:48 +01:00
Alex Beregszaszi	069ea38916	Make literals an error for tight packing (experimental 0.5.0)	2018-04-20 11:58:16 +01:00
chriseth	676732776e	Merge pull request #3943 from ethereum/smt_remove_branch_warning ... [SMTChecker] Remove 'information is erase' message for if-else	2018-04-20 09:01:59 +02:00
chriseth	2546a274ca	Merge pull request #3941 from ethereum/bytes-contract ... Disallow explicit conversion of bytesXX to contract	2018-04-19 16:10:15 +02:00
Alex Beregszaszi	754d79edfa	Disallow explicit conversion of bytesXX to contract	2018-04-19 15:58:14 +02:00
Leonardo Alt	ba3d16fc58	[SMTChecker] Remove 'information is erase' message for if-else	2018-04-19 09:28:44 +02:00
chriseth	a94945dfe4	Improve error message for failed member lookup.	2018-04-18 22:56:45 +01:00
Alex Beregszaszi	39b7b44a8d	Merge pull request #3923 from ethereum/warnConstructor ... Warn about functions named "constructor".	2018-04-18 22:22:58 +01:00
Alex Beregszaszi	377254d5a8	Merge pull request #3922 from ethereum/smt_sol_unimplementedassert ... [SMTChecker] Using solUnimplementedAssert instead of solAssert	2018-04-18 20:28:47 +01:00
chriseth	4895864302	Warn about functions named "constructor".	2018-04-18 21:23:09 +02:00
chriseth	29a97f1641	Fix name clashes between constructor and fallback function.	2018-04-18 14:24:35 +02:00
Leonardo Alt	78ba34608f	[SMTChecker] Using solUnimplementedAssert instead of solAssert when applicable	2018-04-18 13:17:59 +02:00
Leonardo Alt	ae3350ae03	[SMTChecker] Integration with CVC4	2018-04-17 12:26:58 +01:00
chriseth	3d04d83297	Merge pull request #3868 from ethereum/bytescleanup ... Properly force-clean for shortening bytesXX conversions.	2018-04-16 15:23:36 +02:00
chriseth	533d08517f	Merge pull request #3793 from ethereum/rationalNumberLimit ... Rational number limit	2018-04-16 13:10:50 +02:00
Alex Beregszaszi	0201492bbf	Remove redundant cleanup for abi.encode.	2018-04-16 12:47:38 +02:00
chriseth	4c1d39b7a2	Properly force-clean for shortening bytesXX conversions.	2018-04-16 12:47:38 +02:00
Erik Kundt	33fbf88707	Limits rational numbers to 4096 bits.	2018-04-16 11:45:55 +02:00
chriseth	d8030c9b2a	Merge pull request #3880 from ethereum/addressMemberDocAndWarn ... Improve documentation and warning about accessing contract members in…	2018-04-16 11:05:05 +02:00
chriseth	95c49b367e	Merge pull request #3875 from ethereum/constructorSelfRef ... Stricter check for "this" in constructor.	2018-04-13 18:39:31 +02:00
Daniel Kirchner	05c5ab19fb	Improve documentation and warning about accessing contract members inherited from address.	2018-04-13 18:26:24 +02:00
Daniel Kirchner	be37e3a912	Stricter check for member access to "this" in constructor.	2018-04-13 15:57:13 +02:00
Erik Kundt	8935c0dd2f	Uses short string representation of TypePointer	2018-04-12 21:14:50 +02:00
chriseth	7054defdd6	Merge pull request #3364 from ethereum/revertWithReason ... Revert with reason	2018-04-12 21:01:08 +02:00
chriseth	44416d1ac6	Merge pull request #2980 from ethereum/abi-api ... Add abi.encode and abi.encodePacked	2018-04-12 20:55:03 +02:00
chriseth	75b8828666	Allow struct encoding with new encoder.	2018-04-12 16:37:16 +02:00
Daniel Kirchner	6862f22943	Fix internal compiler error when parsing `var` declaration without identifier.	2018-04-12 14:57:14 +02:00
chriseth	4faa839813	Use error signature for revert data.	2018-04-12 13:09:38 +02:00
chriseth	fcb7a27216	Only forward returndata if EVM version supports it.	2018-04-12 13:09:38 +02:00
chriseth	7a9ee69e98	Bubble up error messages.	2018-04-12 13:09:38 +02:00
chriseth	ae1d040285	Allow error string for `require`.	2018-04-12 13:09:37 +02:00
chriseth	012ab37fe3	Code generator for revert with reason string.	2018-04-12 13:09:37 +02:00
chriseth	8ab7dc036a	Register overload for `revert()` that can receive a reason string.	2018-04-12 13:09:37 +02:00
chriseth	f00bb43593	Allow function overloads involving MagicVariableDeclarations.	2018-04-12 13:09:37 +02:00
chriseth	17fc0f54b5	Use FunctionTypePointer (adds `const`).	2018-04-12 13:09:37 +02:00
chriseth	c3dc67d0e0	Merge pull request #3848 from ethereum/constantDivisionByZero ... Error on invalid arithmetic with constant expressions.	2018-04-12 11:49:08 +02:00
chriseth	7343c40283	Check partial function parameters if rest is arbitrary.	2018-04-12 00:10:25 +02:00
Alex Beregszaszi	d56acb68ab	Add abi.encode, abi.encodePacked, abi.encodeWithSelector and abi.encodeWithSignature.	2018-04-11 22:32:10 +02:00
chriseth	b5a696ad48	Properly cope with constructor headers.	2018-04-11 22:00:21 +02:00
chriseth	2ad1acaf72	Warn if modifiers are applied to functions without implementation.	2018-04-11 22:00:21 +02:00
chriseth	6d289783b4	Fix state variable parsing.	2018-04-11 22:00:04 +02:00
chriseth	ae3fca6db2	Merge pull request #3863 from ethereum/fixGasEstimation ... Correctly ignore costs of fallback for other functions.	2018-04-11 21:53:41 +02:00
Daniel Kirchner	daa69df447	Error on invalid arithmetic with constant expressions.	2018-04-11 21:17:10 +02:00
chriseth	928ce08845	Correctly ignore costs of fallback for other functions.	2018-04-11 19:42:34 +01:00
Daniel Kirchner	cb548f6f53	Fix ConstantEvaluator to correctly handle single element tuples.	2018-04-11 18:30:34 +02:00
chriseth	c9bdbcf470	Merge pull request #3309 from ethereum/limit-errors ... Limit the number of errors output in a single run to 256	2018-04-11 16:13:41 +02:00
Jason Cobb	3b7b962b66	Fix bug in typechecking when comparing rational literals	2018-04-11 12:03:08 +02:00
Daniel Kirchner	3eedbc6a9c	Error when using no parentheses in modifier-style constructor calls.	2018-04-10 12:09:34 +02:00
chriseth	b52614116e	Merge pull request #3821 from ethereum/warn-constructor-override ... Warn constructor override	2018-04-10 11:39:31 +02:00
hydai	aaa8edc36d	Fixed typos	2018-04-10 13:41:35 +08:00
Daniel Kirchner	549ba801fb	Use the most derived contract as main location in case of diamond inheritance.	2018-04-09 16:23:18 +02:00
Daniel Kirchner	b918a105a4	Move constructor argument override check to TypeChecker and reuse annotations in ContractCompiler.	2018-04-09 15:26:08 +02:00
Daniel Kirchner	b8fdb666e2	Allow duplicated constructor calls, if no arguments; support for multiple inheritance; backwards compatibility. ... # tmp	2018-04-09 15:26:05 +02:00
Federico Bond	4e037281ac	Error on duplicated super constructor calls	2018-04-09 11:22:35 +02:00
Daniel Kirchner	b2753aa053	Static Analyzer: Fix non-deterministic order of unused variable warnings.	2018-04-06 18:10:26 +02:00
Alex Beregszaszi	43d2954de8	Do not abort excessive warnings, just ignore them.	2018-04-06 14:44:03 +02:00
Alex Beregszaszi	0812d1189a	Ignore warnings when limited errors to 256	2018-04-06 13:52:19 +02:00
Alex Beregszaszi	3730f68d4b	reindent	2018-04-06 13:52:19 +02:00
Alex Beregszaszi	e8be0e61b3	Catch FatalError in CompilerStack::analysis to cover all the analysis tests	2018-04-06 13:52:19 +02:00
Alex Beregszaszi	d5f40c141b	Limit the number of errors output in a single run to 256	2018-04-06 13:52:19 +02:00
chriseth	543e1e19c7	Merge pull request #3831 from ethereum/memory-suffix ... Allow ``memory`` suffix for internal elementary type parsing.	2018-04-05 17:02:43 +02:00
chriseth	4c50ed39d7	Merge pull request #3829 from ethereum/smt_remove_uf ... [SMTChecker] Remove usage of UFs to access SSA vars	2018-04-05 16:07:07 +02:00
chriseth	5b1c0506fa	Allow `memory` suffix for internal elementary type parsing.	2018-04-05 16:06:04 +02:00
Daniel Kirchner	037eba20fc	Merge pull request #3824 from ethereum/baseArgumentsEmptyParenthesis ... Error when using empty parentheses for base class constructors that r…	2018-04-05 14:43:28 +02:00
Leonardo Alt	8d087d1889	[SMTChecker] Removing usage of UFs to access SSA indices	2018-04-05 12:48:58 +02:00
Alex Beregszaszi	36d6c27e68	Merge pull request #3745 from ethereum/fixRecursion ... Fix invalid recursion errors for structs	2018-04-05 12:04:54 +02:00
Daniel Kirchner	96eff0ff6a	Error when using empty parenthesis for base class constructors that require arguments.	2018-04-05 11:52:22 +02:00
chriseth	65f18a18de	More specific push implementation.	2018-04-04 16:50:45 +02:00
chriseth	0cbe55005d	Create empty dynamic memory arrays more efficiently.	2018-04-04 12:37:04 +02:00
Daniel Kirchner	8f66390f56	Set isConstructor to false unconditionally and update to true later for constructors.	2018-04-03 18:21:55 +02:00
Daniel Kirchner	e2dac9ed39	Set header.isConstructor for old style constructors in parseFunctionHeader as well.	2018-04-03 18:21:55 +02:00
Daniel Kirchner	d664a599e6	Constructors are defined using the `constructor` keyword.	2018-04-03 18:21:55 +02:00
Alex Beregszaszi	0edce4b570	Merge pull request #3693 from ethereum/optimizeMLOAD ... Optimize across MLOAD if MSIZE is not used.	2018-04-03 15:58:11 +01:00
chriseth	eb5b18e814	Generalize cycle detection.	2018-04-03 16:29:18 +02:00
chriseth	5bdadff0d8	Fix detection of recursive structs.	2018-04-03 16:27:28 +02:00
Alex Beregszaszi	7753249f64	Merge pull request #3699 from ethereum/interfaceExternalVisibility ... Defaults to external visibility for interfaces.	2018-04-03 15:15:36 +01:00
chriseth	a54fdc495f	Fix: Treat empty base constructor argument list as not provided.	2018-04-03 14:53:48 +02:00
chriseth	6777f7a57f	Optimize across MLOAD if MSIZE is not used.	2018-04-03 14:34:32 +02:00
Erik Kundt	f9efa41749	Makes visibility warning more concise.	2018-04-03 11:16:50 +02:00
bitshift	8fe1cfb12e	Defaults to external visibility for interfaces.	2018-04-03 11:16:44 +02:00
Jason Cobb	e37b619593	Set default fixed point decimal places to 18	2018-03-31 00:56:36 +01:00
chriseth	326d656a55	Merge pull request #3790 from ethereum/empty-structs ... Disallow empty structs	2018-03-30 13:58:35 +02:00
chriseth	5c8a6aac69	Prevent encoding of weird types and support packed encoding of external function types.	2018-03-29 09:57:11 +01:00
chriseth	3bb54e8bd5	Merge pull request #3775 from federicobond/improve-error-fractional-shift ... Improve error message when attempting to shift by fractional number	2018-03-28 11:16:44 +02:00
Alex Beregszaszi	ebb12756ad	Still allow empty structs for non-0.5.0 mode	2018-03-27 15:49:41 +01:00
Alex Beregszaszi	b540ba527a	Disallow empty structs	2018-03-27 15:49:41 +01:00
chriseth	62559cf127	Merge pull request #3681 from ethereum/interface-external ... Allow overriding external functions in interfaces with public in a child	2018-03-27 15:47:59 +02:00
chriseth	59538e9a04	Merge pull request #3686 from ethereum/doNotIncludeItnernal ... Do not include internal functions only used by constructor	2018-03-27 15:28:08 +02:00
Alex Beregszaszi	fab527c414	Add runtimeOnly option to pushCombinedFunctionEntryLabel	2018-03-27 04:00:12 +01:00
chriseth	0a67d616db	Use shortcut for internal function calls to avoid runtime reference.	2018-03-27 04:00:12 +01:00
bitshift	2c56e53046	Changes deprecation and adjusts tests.	2018-03-27 03:30:03 +01:00
bitshift	ed632025fe	Moves blockhash function to global level.	2018-03-27 03:30:03 +01:00
Alex Beregszaszi	8bae2dba7c	Introduce inContractKind helper on FunctionDefinition	2018-03-26 11:37:38 +01:00
Alex Beregszaszi	ef3595b000	Allow overriding external functions in interfaces with public in an implementing contract	2018-03-26 11:35:17 +01:00
Federico Bond	b79531bebf	Improve error message when trying to shift by fractional number	2018-03-22 10:05:49 -03:00
chriseth	c2709a2d8e	Decode dynamic data.	2018-03-21 14:53:29 +00:00
chriseth	cc2f71e4ac	Move dynamic type removal out of the type system.	2018-03-21 14:53:29 +00:00
chriseth	32c94f5059	Simple size check for old ABI decoder.	2018-03-21 14:53:25 +00:00
chriseth	2cdf44f65c	Move the old ABI decoder code.	2018-03-20 15:20:43 +00:00
chriseth	78abe81f08	Merge branch 'develop' into externalFunctionsInLibraries	2018-03-14 18:07:55 +01:00
chriseth	abc7a45230	Merge pull request #3725 from ethereum/blockhashNoCall ... Allow ``block.blockhash`` without it being called.	2018-03-14 18:04:40 +01:00
Alex Beregszaszi	59658afa30	Merge pull request #3722 from ethereum/fixMods ... Fix modifier lookup in libraries.	2018-03-14 17:20:51 +01:00
Daniel Kirchner	0d0c9b8688	DocStringParser: Fix error message for empty parameter description.	2018-03-14 10:14:35 +01:00
chriseth	834d63de2c	Allow `block.blockhash` without being called.	2018-03-13 17:34:21 +01:00
chriseth	eecc26deec	Make external library functions accessible.	2018-03-13 17:18:46 +01:00
chriseth	069b150e42	Bugfix in virtual lookup for modifiers in libraries.	2018-03-13 16:55:41 +01:00
Leonardo Alt	9b64dc501d	[SMTChecker_Bool] Fix PR review comments: method renaming and solAssert	2018-03-12 20:16:47 +01:00
Leonardo Alt	c2d26eb6a2	[SMTChecker_Bool] Fix PR comments; Add support to gt, ge, lt, le. and tests.	2018-03-12 20:16:47 +01:00
Leonardo Alt	6a940f0a99	[SMTChecker] Support to Bool variables	2018-03-12 20:16:47 +01:00
Alex Beregszaszi	a59d6d2e53	Support constantinople in evm-version	2018-03-12 18:13:19 +01:00
chriseth	0649f900ca	Properly skip cleanup if only enlarging storage array.	2018-03-09 14:06:54 +01:00
Alex Beregszaszi	ba8819542f	Merge pull request #3611 from ethereum/warn-using-address-overload ... Warn if using address overloads on contracts	2018-03-06 19:13:55 +01:00
chriseth	baa1526539	Merge pull request #3664 from ethereum/literalsHexUnitSmallFix ... Use double quotes for suggestion about hex literals and denominations.	2018-03-06 19:01:25 +01:00
Alex Beregszaszi	250a6bad8c	Merge pull request #3527 from ethereum/warnLooseAsm ... Warn about using loose assembly.	2018-03-06 18:59:23 +01:00
Daniel Kirchner	b4d38c5491	Use double quotes for suggestion about hex literals and denominations.	2018-03-06 18:09:54 +01:00
chriseth	95ca829750	Merge pull request #3663 from ethereum/gasleftEmscripten ... Add gasleft to FunctionType::richIdentifier().	2018-03-06 18:06:30 +01:00
chriseth	fd1662d1c4	Warn about using loose inline assembly features as experimental 0.5.0 feature.	2018-03-06 17:45:34 +01:00
Daniel Kirchner	fb4d01e2cd	Add gasleft to FunctionType::richIdentifier().	2018-03-06 17:29:04 +01:00
Alex Beregszaszi	14b12ae745	Merge pull request #2966 from ethereum/useStaticCall ... Use STATICCALL for pure function calls.	2018-03-06 17:07:03 +01:00
Alex Beregszaszi	83dacbf669	Merge pull request #3549 from ethereum/fixmultidim ... Properly detect which array and struct types are unsupported by the old ABI encoder.	2018-03-06 15:51:17 +01:00
chriseth	b467116ea8	Use STATICCALL for pure function calls if EVM version supports it and 0.5.0 is activated.	2018-03-06 15:30:18 +01:00
chriseth	f6c0daec14	Merge pull request #3652 from ethereum/gasleft_v2 ... Use StaticAnalyzer to deprecate msg.gas instead of conditionally remo…	2018-03-06 09:26:14 +01:00
Daniel Kirchner	91b13b734d	Use StaticAnalyzer to deprecate msg.gas instead of conditionally removing it in MagicType.	2018-03-05 23:16:26 +01:00
chriseth	9d67e9b4fc	Merge pull request #3640 from AnthonyBroadCrawford/spanning-multiline-message-fix ... moved spanning multi lines message to appear on some lane vs new line…	2018-03-05 22:51:53 +01:00
Anthony Broad-Crawford	174c46d5af	Improved messaging when an error spans multiple lines and updated change log file.	2018-03-05 14:14:14 -06:00
chriseth	be797cb796	Merge pull request #3599 from ethereum/sendAllGasOnByzantium ... Send all gas on byzantium	2018-03-05 20:13:52 +01:00
chriseth	3793aa405b	Merge pull request #3643 from ethereum/gasleft ... Move msg.gas to global function gasleft(). Closes #2971.	2018-03-05 20:11:37 +01:00
chriseth	83fcf007bf	Do not retain any gas in external calls (except if EVM version is set to homestead).	2018-03-05 19:32:12 +01:00
chriseth	f190b27431	Merge pull request #3600 from ethereum/version050IsAnalysisOnly ... Do not warn about 0.5.0 experimental pragma.	2018-03-05 19:28:41 +01:00
Daniel Kirchner	3340053fd9	Style improvements.	2018-03-05 17:00:37 +01:00
chriseth	1ceb0b04c1	Assert that address members are not present on contract types in 0.5.0.	2018-03-05 15:55:02 +01:00
Alex Beregszaszi	fd60c1cf86	Warn if using address overloads on contracts	2018-03-05 15:50:27 +01:00
chriseth	477571e190	Do not warn about 0.5.0 experimental pragma.	2018-03-05 12:14:44 +01:00
chriseth	cd6ffbdf79	Merge pull request #3642 from leonardoalt/fix_z3-46 ... Add z3 performance option	2018-03-05 12:13:39 +01:00
chriseth	6dc137317f	Merge pull request #3569 from ethereum/evmVersion ... EVM version	2018-03-05 12:10:49 +01:00
chriseth	6ec4517929	Use EVM version in gas meter and optimizer.	2018-03-05 11:36:33 +01:00
Daniel Kirchner	c633c0eacb	Move msg.gas to global function gasleft(). Closes #2971.	2018-03-05 11:18:04 +01:00
Leonardo Alt	5d74b862a3	This z3 option is necessary for good solving performance	2018-03-04 14:42:36 +01:00
chriseth	f78d6a9a1e	Merge pull request #3628 from ethereum/literalsHexUnit ... Deprecate using unit denominations in combination with hex numbers.	2018-03-02 11:11:16 +01:00
Daniel Kirchner	454b470cee	Suggest expressions of the form '0x1234 * 1 day' instead of hex numbers with unit denominations.	2018-03-02 10:22:58 +01:00
Alex Beregszaszi	5a54cd5c70	Only warn for shift instructions if not using constantinople	2018-03-01 17:19:35 +01:00
chriseth	4ce0e7775d	Add constantinople.	2018-03-01 17:19:35 +01:00
chriseth	982476f99d	Add TangerineWhistle.	2018-03-01 17:19:35 +01:00