chore: remove liquidation price (est) for now

apps/trading-e2e/src/integration/trading-positions.cy.ts

@@ -41,11 +41,6 @@ describe('positions', { tags: '@smoke' }, () => {
       cy.getByTestId('flash-cell').each(($prices) => {
         cy.wrap($prices).invoke('text').should('not.be.empty');
       });
-
-      cy.get('[col-id="liquidationPrice"]')
-        .should('contain.text', '85,093.38') // entry price
-        .should('contain.text', '0.00'); // liquidation price
-
       cy.get('[col-id="currentLeverage"]').should('contain.text', '0.8');
 
       cy.get('[col-id="marginAccountBalance"]') // margin allocated

libs/positions/src/lib/positions-table.spec.tsx

@@ -92,7 +92,7 @@ it('add color and sign to amount, displays positive notional value', async () =>
   expect(cells[2].classList.contains('text-vega-green-dark')).toBeTruthy();
   expect(cells[2].classList.contains('text-vega-red-dark')).toBeFalsy();
   expect(cells[2].textContent).toEqual('+100');
-  expect(cells[1].textContent).toEqual('123.00');
+  expect(cells[1].textContent).toEqual('1,230');
   await act(async () => {
     result.rerender(
       <PositionsTable rowData={[{ ...singleRow, openVolume: '-100' }]} />
@@ -102,7 +102,7 @@ it('add color and sign to amount, displays positive notional value', async () =>
   expect(cells[2].classList.contains('text-vega-green-dark')).toBeFalsy();
   expect(cells[2].classList.contains('text-vega-red-dark')).toBeTruthy();
   expect(cells[2].textContent?.startsWith('-100')).toBeTruthy();
-  expect(cells[1].textContent).toEqual('123.00');
+  expect(cells[1].textContent).toEqual('1,230');
 });
 
 it('displays mark price', async () => {
@@ -172,7 +172,7 @@ it('displays allocated margin', async () => {
   });
   const cells = screen.getAllByRole('gridcell');
   const cell = cells[8];
-  expect(cell.textContent).toEqual('123,456.00');
+  expect(cell.textContent).toEqual('123,456');
 });
 
 it('displays realised and unrealised PNL', async () => {

libs/positions/src/lib/positions-table.tsx

@@ -14,7 +14,7 @@ import type {
 import { EmptyCell, ProgressBarCell } from '@vegaprotocol/ui-toolkit';
 import {
   PriceFlashCell,
-  addDecimalsFormatNumber,
+  addDecimalsNormalizeNumber,
   volumePrefix,
   t,
   toBigNum,
@@ -72,11 +72,11 @@ export const AmountCell = ({ valueFormatted }: AmountCellProps) => {
         className={classNames('text-right', signedNumberCssClass(openVolume))}
       >
         {volumePrefix(
-          addDecimalsFormatNumber(openVolume, positionDecimalPlaces)
+          addDecimalsNormalizeNumber(openVolume, positionDecimalPlaces)
         )}
       </div>
       <div className="text-right">
-        {addDecimalsFormatNumber(notional, marketDecimalPlaces)}
+        {addDecimalsNormalizeNumber(notional, marketDecimalPlaces)}
       </div>
     </div>
   ) : null;
@@ -116,8 +116,8 @@ const progressBarValueFormatter = ({
   const mid = BigInt(data.markPrice);
   const range = max - min;
   return {
-    low: addDecimalsFormatNumber(min.toString(), data.marketDecimalPlaces),
-    high: addDecimalsFormatNumber(max.toString(), data.marketDecimalPlaces),
+    low: addDecimalsNormalizeNumber(min.toString(), data.marketDecimalPlaces),
+    high: addDecimalsNormalizeNumber(max.toString(), data.marketDecimalPlaces),
     value: range ? Number(((mid - min) * BigInt(100)) / range) : 0,
     intent: data.lowMarginLevel ? Intent.Warning : undefined,
   };
@@ -173,14 +173,17 @@ export const PositionsTable = forwardRef<AgGridReact, Props>(
           }: VegaValueGetterParams<Position, 'notional'>) => {
             return data?.notional === undefined
               ? undefined
-              : toBigNum(data?.notional, data.decimals).toNumber();
+              : toBigNum(data?.notional, data.marketDecimalPlaces).toNumber();
           }}
           valueFormatter={({
             data,
           }: VegaValueFormatterParams<Position, 'notional'>) => {
             return !data
               ? undefined
-              : addDecimalsFormatNumber(data.notional, data.decimals);
+              : addDecimalsNormalizeNumber(
+                  data.notional,
+                  data.marketDecimalPlaces
+                );
           }}
         />
         <AgGridColumn
@@ -205,7 +208,7 @@ export const PositionsTable = forwardRef<AgGridReact, Props>(
             return data?.openVolume === undefined
               ? undefined
               : volumePrefix(
-                  addDecimalsFormatNumber(
+                  addDecimalsNormalizeNumber(
                     data.openVolume,
                     data.positionDecimalPlaces
                   )
@@ -246,7 +249,7 @@ export const PositionsTable = forwardRef<AgGridReact, Props>(
             ) {
               return '-';
             }
-            return addDecimalsFormatNumber(
+            return addDecimalsNormalizeNumber(
               data.markPrice,
               data.marketDecimalPlaces
             );
@@ -284,39 +287,12 @@ export const PositionsTable = forwardRef<AgGridReact, Props>(
             if (!data || node?.rowPinned) {
               return undefined;
             }
-            return addDecimalsFormatNumber(
+            return addDecimalsNormalizeNumber(
               data.averageEntryPrice,
               data.marketDecimalPlaces
             );
           }}
         />
-        <AgGridColumn
-          headerName={t('Liquidation price (est)')}
-          field="liquidationPrice"
-          flex={2}
-          headerTooltip={t(
-            'Liquidation prices are based on the amount of collateral you have available, the risk of your position and the liquidity on the order book. They can change rapidly based on the profit and loss of your positions and any changes to collateral from opening/closing other positions and making deposits/withdrawals.'
-          )}
-          filter="agNumberColumnFilter"
-          valueGetter={({
-            data,
-          }: VegaValueGetterParams<Position, 'liquidationPrice'>) => {
-            return !data
-              ? undefined
-              : toBigNum(
-                  data?.liquidationPrice,
-                  data.marketDecimalPlaces
-                ).toNumber();
-          }}
-          cellRendererSelector={(
-            params: ICellRendererParams
-          ): CellRendererSelectorResult => {
-            return {
-              component: params.node.rowPinned ? EmptyCell : ProgressBarCell,
-            };
-          }}
-          valueFormatter={progressBarValueFormatter}
-        />
         <AgGridColumn
           headerName={t('Leverage')}
           field="currentLeverage"
@@ -363,7 +339,7 @@ export const PositionsTable = forwardRef<AgGridReact, Props>(
             if (!data || node?.rowPinned) {
               return undefined;
             }
-            return addDecimalsFormatNumber(
+            return addDecimalsNormalizeNumber(
               data.marginAccountBalance,
               data.decimals
             );
@@ -387,7 +363,7 @@ export const PositionsTable = forwardRef<AgGridReact, Props>(
           }: VegaValueFormatterParams<Position, 'realisedPNL'>) => {
             return !data
               ? undefined
-              : addDecimalsFormatNumber(data.realisedPNL, data.decimals);
+              : addDecimalsNormalizeNumber(data.realisedPNL, data.decimals);
           }}
           cellRenderer="PriceFlashCell"
           headerTooltip={t(
@@ -412,7 +388,7 @@ export const PositionsTable = forwardRef<AgGridReact, Props>(
           }: VegaValueFormatterParams<Position, 'unrealisedPNL'>) =>
             !data
               ? undefined
-              : addDecimalsFormatNumber(data.unrealisedPNL, data.decimals)
+              : addDecimalsNormalizeNumber(data.unrealisedPNL, data.decimals)
           }
           cellRenderer="PriceFlashCell"
           headerTooltip={t(

libs/positions/src/lib/use-positions-data.tsx

@@ -33,6 +33,8 @@ export const getSummaryRowData = (positions: Position[]) => {
     realisedPNL: summaryRow.realisedPNL.toString(),
     unrealisedPNL: summaryRow.unrealisedPNL.toString(),
     decimals,
+    marketDecimalPlaces: positions[0]?.marketDecimalPlaces || 0,
+    positionDecimalPlaces: positions[0]?.positionDecimalPlaces || 0,
   };
 };