Commit Graph
6223 Commits
Author SHA1 Message Date
ethers 217f33c252 Clearer language as suggested by @axic 2016-11-22 00:47:58 -08:00
ethers feebe3e755 Fallback functions don't always have to be payable 2016-11-17 18:14:26 -08:00
ethers 1d9aee97c2 styleguide: Don't include a whitespace in the fallback function 2016-11-17 18:13:33 -08:00
ethers 549bca1494 Don't include a whitespace in fallback function 2016-11-17 18:09:22 -08:00
ethers 39559c1bb6 styleguide: Ordering of functions
Ordering would help readers identify which functions they can call, and to find the "specials" (constructor and fallback function).  Mixing the "specials" in the middle of the code, as well as internal functions between external and public functions, don't help readers

Based on https://github.com/ConsenSys/MultiSigWallet/issues/19
2016-11-17 18:06:28 -08:00
chriseth b46a14f4a8 Merge pull request #1122 from ethereum/firstClassFunctions
Functions as first-class types.
2016-11-17 17:32:21 +01:00
chriseth 2c14a96820 Some more assertions and style changes. 2016-11-16 15:09:01 +01:00
chriseth 2defe4dcef Documentation: Style update 2016-11-16 14:37:19 +01:00
chriseth eeae91c2a2 Update documentation. 2016-11-16 14:37:19 +01:00
chriseth b3eeb5fcf9 Some more tests. 2016-11-16 14:37:19 +01:00
chriseth e1fec9b287 JSON tests. 2016-11-16 14:37:19 +01:00
chriseth 830f14c3a3 Fix documentation formatting. 2016-11-16 14:37:19 +01:00
chriseth ec31d08775 Change encoding to address-funid and add "function" as ABI type. 2016-11-16 14:37:19 +01:00
chriseth a8e7ed37a1 Disable broken tests that are not useful. 2016-11-16 14:37:19 +01:00
chriseth cb000a5532 Fix setting the tag. 2016-11-16 14:37:19 +01:00
chriseth 390ba085b6 fixup! Simple peephole optimizer that is activated even if not requested. 2016-11-16 14:37:19 +01:00
chriseth 739dabff8b Fix tests. 2016-11-16 14:37:19 +01:00
chriseth 7a292c9a05 Fix parser for function type disambiguity. 2016-11-16 14:37:19 +01:00
chriseth 0335ed4cb4 Simple peephole optimizer that is activated even if not requested. 2016-11-16 14:37:19 +01:00
chriseth 22b4d1b29a Check that no internals are used in any external function type. 2016-11-16 14:37:18 +01:00
Yoichi Hirai f3d0433ec3 test: add a test about external function type taking/returning internal functions 2016-11-16 14:37:18 +01:00
chriseth e51f852504 Converted sub assembly to smart pointer. 2016-11-16 14:37:18 +01:00
chriseth e543bd34c0 Stored combined creation and runtime tags.
Includes a change to Assembly to allow tags from sub-assemblies to be
used.

Sorry, this get a bit bigger than I thought.
2016-11-16 14:37:18 +01:00
chriseth ee3efa67a8 Fix tests. 2016-11-16 14:37:18 +01:00
chriseth 746266b8fc ABI: Use external function. 2016-11-16 14:37:18 +01:00
chriseth 08763a206d Test passing functions as arrays to other contracts. 2016-11-16 14:37:18 +01:00
chriseth 925d674146 Disallow payable internal functions. 2016-11-16 14:37:18 +01:00
chriseth f7a62c1e69 Mention "payable" in the documentation. 2016-11-16 14:37:18 +01:00
chriseth e1df3bd77f Fix tests. 2016-11-16 14:37:18 +01:00
chriseth f21f794f3c delete for function types 2016-11-16 14:37:18 +01:00
Yoichi Hirai c9f9b2ab4d codegen: add a compilation mode and a runtime context to CompilerContext 2016-11-16 14:37:18 +01:00
chriseth 5011d6339a Added function types to the grammar. 2016-11-16 14:37:18 +01:00
chriseth 0e5507c78c Updates to the documentation. 2016-11-16 14:37:18 +01:00
chriseth 47794c1da4 Implement uninitialized storage functions. 2016-11-16 14:37:18 +01:00
chriseth b6992d740a Tests for uninitialized storage functions. 2016-11-16 14:37:18 +01:00
Yoichi Hirai 3158a8ea7b test: add a test for storing an internal function in the constructor and then using the stored function in runtime 2016-11-16 14:37:18 +01:00
chriseth cc847df3c2 Bugfix in code generator. 2016-11-16 14:37:18 +01:00
chriseth 502cc319d7 Documentation examples. 2016-11-16 14:37:18 +01:00
chriseth 87b148494b Tests. 2016-11-16 14:37:18 +01:00
chriseth ff3553a348 Change alignment. 2016-11-16 14:37:18 +01:00
chriseth 679ea2820f Part of the documentation. 2016-11-16 14:37:18 +01:00
chriseth 62492b67e7 Changelog entry and small fixes. 2016-11-16 14:37:18 +01:00
Yoichi Hirai 6172590b87 Add a test around storing functions in an array 2016-11-16 14:37:17 +01:00
Yoichi Hirai 708b7b35ad Add a parser test for arrays containing functions 2016-11-16 14:37:17 +01:00
Yoichi Hirai ab3d1b024d Add tests around calling functions returning functions returning functions 2016-11-16 14:37:17 +01:00
chriseth 95d7555e3c External functions in storage. 2016-11-16 14:37:17 +01:00
chriseth 6f19559de0 Fix some type checks and tests for internal / external function parameters. 2016-11-16 14:37:17 +01:00
chriseth 97a3588701 Function type state variables. 2016-11-16 14:37:17 +01:00
chriseth dd173f83e3 Code generator for function types. 2016-11-16 14:37:17 +01:00
chriseth cc8583ec7d Function types. 2016-11-16 14:37:17 +01:00