cerc-io/plugeth-statediff
16
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Add test utils and module fixes for dependents #24

Merged
roysc merged 12 commits from update-czkg4844 into main 2024-05-29 09:47:10 +00:00
Conversation 1 Commits 12 Files Changed 14 +336 -26
roysc commented 2024-04-15 13:33:05 +00:00
Member
Copy Link

Patch for module conflict when used as a dependency: github.com/ethereum/c-kzg-4844/bindings/go was moved to become part of github.com/ethereum/c-kzg-4844 by v0.4.0.
See:

% go mod tidy                                       
go: github.com/cerc-io/ipld-eth-db-validator/v5/internal/chaingen imports
	github.com/ethereum/go-ethereum/core imports
	github.com/ethereum/go-ethereum/crypto/kzg4844 imports
	github.com/ethereum/c-kzg-4844/bindings/go: ambiguous import: found package github.com/ethereum/c-kzg-4844/bindings/go in multiple modules:
	github.com/ethereum/c-kzg-4844 v0.4.0 (/Users/roy/golang/pkg/mod/github.com/ethereum/c-kzg-4844@v0.4.0/bindings/go)
	github.com/ethereum/c-kzg-4844/bindings/go v0.0.0-20230126171313-363c7d7593b4 (/Users/roy/golang/pkg/mod/github.com/ethereum/c-kzg-4844/bindings/go@v0.0.0-20230126171313-363c7d7593b4)

Also add test utils from https://git.vdb.to/cerc-io/ipld-eth-db-validator to be shared by cerc-io/ipld-eth-statedb#5 and wherever else.

Patch for module conflict when used as a dependency: `github.com/ethereum/c-kzg-4844/bindings/go` was moved to become part of `github.com/ethereum/c-kzg-4844` by `v0.4.0`. See: - https://git.vdb.to/cerc-io/plugeth/pulls/8 - https://git.vdb.to/cerc-io/plugeth-utils/commit/6ea035f2088c04ac21ca8952acf18467fea5422b ``` % go mod tidy go: github.com/cerc-io/ipld-eth-db-validator/v5/internal/chaingen imports github.com/ethereum/go-ethereum/core imports github.com/ethereum/go-ethereum/crypto/kzg4844 imports github.com/ethereum/c-kzg-4844/bindings/go: ambiguous import: found package github.com/ethereum/c-kzg-4844/bindings/go in multiple modules: github.com/ethereum/c-kzg-4844 v0.4.0 (/Users/roy/golang/pkg/mod/github.com/ethereum/c-kzg-4844@v0.4.0/bindings/go) github.com/ethereum/c-kzg-4844/bindings/go v0.0.0-20230126171313-363c7d7593b4 (/Users/roy/golang/pkg/mod/github.com/ethereum/c-kzg-4844/bindings/go@v0.0.0-20230126171313-363c7d7593b4) ``` Also add test utils from https://git.vdb.to/cerc-io/ipld-eth-db-validator to be shared by https://git.vdb.to/cerc-io/ipld-eth-statedb/pulls/5 and wherever else.
roysc added 2 commits 2024-04-15 13:33:06 +00:00
add chaingen & indexing test utils
All checks were successful
Test / Run compliance tests (pull_request) Successful in 4m36s
Details
Test / Run unit tests (pull_request) Successful in 12m40s
Details
Test / Run integration tests (pull_request) Successful in 29m9s
Details
d94b880cb7
roysc changed title from Add test utils and module fixes for dependents to WIP: Add test utils and module fixes for dependents 2024-04-15 13:33:14 +00:00
roysc added 2 commits 2024-04-22 13:19:49 +00:00
dev ref
Some checks failed
Test / Run integration tests (pull_request) Failing after 1s
Details
Test / Run compliance tests (pull_request) Failing after 1s
Details
Test / Run unit tests (pull_request) Successful in 11m19s
Details
b527aa0ffb
roysc changed title from WIP: Add test utils and module fixes for dependents to Add test utils and module fixes for dependents 2024-04-22 13:20:07 +00:00
roysc requested review from telackey 2024-04-22 13:25:35 +00:00
roysc requested review from jonathanface 2024-04-22 13:25:36 +00:00
roysc added 1 commit 2024-04-23 11:13:38 +00:00
goose min version = 20
Some checks failed
Test / Run compliance tests (pull_request) Failing after 0s
Details
Test / Run integration tests (pull_request) Failing after 3m49s
Details
Test / Run unit tests (pull_request) Successful in 9m43s
Details
fdb62b02b4
roysc added 1 commit 2024-04-23 11:14:50 +00:00
update ipld-eth-db in test compose
Some checks failed
Test / Run unit tests (pull_request) Failing after 4s
Details
Test / Run compliance tests (pull_request) Failing after 0s
Details
Test / Run integration tests (pull_request) Failing after 3m45s
Details
ad79a26cfc
roysc added 2 commits 2024-04-24 10:35:56 +00:00
pass context to WriteStateSnapshot
Some checks failed
Test / Run integration tests (pull_request) Failing after 0s
Details
Test / Run compliance tests (pull_request) Failing after 0s
Details
Test / Run unit tests (pull_request) Successful in 9m49s
Details
353d0ce688 
this allows canceling the workers
roysc added 1 commit 2024-05-13 04:55:12 +00:00
tag doesn't exist on lighthouse fork
All checks were successful
Test / Run compliance tests (pull_request) Successful in 4m58s
Details
Test / Run unit tests (pull_request) Successful in 13m8s
Details
Test / Run integration tests (pull_request) Successful in 33m12s
Details
9a4955d070
telackey approved these changes 2024-05-21 16:26:22 +00:00
Dismissed
telackey requested changes 2024-05-21 16:56:31 +00:00
telackey left a comment
Member
Copy Link

Could you please add CI integration of https://git.vdb.to/cerc-io/system-tests?

I thought we had it already, but I don't see it here.

Could you please add CI integration of https://git.vdb.to/cerc-io/system-tests? I thought we had it already, but I don't see it here.
roysc commented 2024-05-23 13:06:22 +00:00
Author
Member
Copy Link

@telackey they actually are run here: https://git.vdb.to/cerc-io/plugeth-statediff/actions/runs/172/jobs/1,

.gitea/workflows/test.yml Line 67 in 9a4955d070
pytest -v -k test_basic_db

However it's just the basic_db tests, because the rest depend on ipld-eth-server - so we can run the full suite there.

@telackey they actually are run here: https://git.vdb.to/cerc-io/plugeth-statediff/actions/runs/172/jobs/1, https://git.vdb.to/cerc-io/plugeth-statediff/src/commit/9a4955d0708edc44338b084e9b1d1ab46d441c01/.gitea/workflows/test.yml#L67 However it's just the basic_db tests, because the rest depend on ipld-eth-server - so we can run the full suite there.
roysc added 1 commit 2024-05-29 08:36:58 +00:00
module tag
All checks were successful
Test / Run compliance tests (pull_request) Successful in 4m56s
Details
Test / Run unit tests (pull_request) Successful in 12m39s
Details
Test / Run integration tests (pull_request) Successful in 30m49s
Details
c7da7c9d23
roysc added 2 commits 2024-05-29 09:44:44 +00:00
rm TODOs
Some checks failed
Test / Run integration tests (pull_request) Failing after 3m28s
Details
Test / Run compliance tests (pull_request) Successful in 4m31s
Details
Test / Run unit tests (pull_request) Successful in 13m25s
Details
7f1959e124
roysc merged commit cd195a0fc0 into main 2024-05-29 09:47:10 +00:00
roysc deleted branch update-czkg4844 2024-05-29 09:47:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jonathanface
telackey
Labels
Clear labels
  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/plugeth-statediff#24
No description provided.
Delete Branch "update-czkg4844"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?