cerc-io/ipld-eth-server
12
0
Fork 1
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 37 Wiki Activity

Geth 1.13 (Deneb/Cancun) update #264

Merged
roysc merged 14 commits from update-geth-1.13 into v5 2024-05-29 12:29:57 +00:00
Conversation 3 Commits 14 Files Changed 32
+2111 -2960
roysc commented 2024-04-22 10:23:13 +00:00
Owner
Copy Link
Copy Source

Most notable change is the updates to the test contracts: due to https://eips.ethereum.org/EIPS/eip-6780, SELFDESTRUCT no longer destroys a contract (outside of the creating transaction), so CREATE2 can no longer redeploy contracts to the same address.

The rest is mainly various refactors.

Depends on:

Most notable change is the updates to the test contracts: due to https://eips.ethereum.org/EIPS/eip-6780, SELFDESTRUCT no longer destroys a contract (outside of the creating transaction), so CREATE2 can no longer redeploy contracts to the same address. The rest is mainly various refactors. Depends on: - https://git.vdb.to/cerc-io/plugeth-statediff/pulls/24 - https://git.vdb.to/cerc-io/ipld-eth-statedb/pulls/5 - https://git.vdb.to/cerc-io/ipfs-ethdb/pulls/3 - https://git.vdb.to/cerc-io/eth-ipfs-state-validator/pulls/7
roysc added 9 commits 2024-04-22 10:23:14 +00:00
rm unused makefile 60003b654d
rm unused validate cmd 93140bff1b
update code e8d146ab73
update tests 7a7c468d51
docker updates d8ece9ee40 
ignore build/
update deps d9e6452db5
update contracts 5406c8b644 
upgrade deployer solc, node, modules

rm selfdestruct (EIP-6780)

redeploy to same address is no longer possible
test fixes 319a331d03
update version
Test the stack. / Run unit tests (pull_request) Successful in 5m30s
Details
Test the stack. / Run integration tests (pull_request) Successful in 54m25s
Details
8769670122
roysc marked the pull request as ready for review 2024-04-22 13:09:19 +00:00
roysc requested review from telackey 2024-04-22 13:09:28 +00:00
roysc requested review from jonathanface 2024-04-22 13:09:29 +00:00
roysc added 2 commits 2024-04-23 14:35:18 +00:00
fix github.com/ethereum/c-kzg-4844 48d5e79151
rm unused - this is in plugeth-statediff now anyway
Test the stack. / Run unit tests (pull_request) Successful in 5m48s
Details
Test the stack. / Run integration tests (pull_request) Successful in 53m31s
Details
63cfd0ef91
roysc marked the pull request as work in progress 2024-05-06 10:48:38 +00:00
roysc commented 2024-05-06 10:49:15 +00:00
Author
Owner
Copy Link
Copy Source

This needs some work to handle withdrawals.

This needs some work to handle withdrawals.
roysc added 2 commits 2024-05-09 12:43:50 +00:00
simplify integ test script fc58ee47f4
placeholder withdrawal handling
Test the stack. / Run unit tests (pull_request) Has been cancelled
Details
Test the stack. / Run integration tests (pull_request) Has been cancelled
Details
c71f2f4071
roysc force-pushed update-geth-1.13 from c71f2f4071 to 8c274d0ad4 2024-05-09 12:44:49 +00:00 Compare
roysc marked the pull request as ready for review 2024-05-09 12:45:17 +00:00
telackey commented 2024-05-21 16:44:57 +00:00
Contributor
Copy Link
Copy Source

This all looks reasonable. Have you tried integrating the system tests yet https://git.vdb.to/cerc-io/system-tests?

I think it would be valuable, in addition to our other testing, to make sure that is in CI on both the plugeth-statediff and ipld-eth-server repos at least.

This all looks reasonable. Have you tried integrating the system tests yet https://git.vdb.to/cerc-io/system-tests? I think it would be valuable, in addition to our other testing, to make sure that is in CI on both the plugeth-statediff and ipld-eth-server repos at least.
roysc commented 2024-05-23 12:59:06 +00:00
Author
Owner
Copy Link
Copy Source

I was actually thinking of including them with #265, and adding a way to induce validator withdrawals to test that they are indexed. I will add a TODO there.

I was actually thinking of including them with https://git.vdb.to/cerc-io/ipld-eth-server/pulls/265, and adding a way to induce validator withdrawals to test that they are indexed. I will add a TODO there.
roysc added 1 commit 2024-05-29 10:44:08 +00:00
module tags
Test the stack. / Run unit tests (pull_request) Successful in 5m22s
Details
Test the stack. / Run integration tests (pull_request) Successful in 51m25s
Details
67bb7e55e7
roysc merged commit 688b5c817a into v5 2024-05-29 12:29:56 +00:00
roysc deleted branch update-geth-1.13 2024-05-29 12:29:57 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
telackey
jonathanface
Labels
Clear labels
Epic
Integration tests
bug
Something isn't working
 critical
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 v5
wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#264