cerc-io/eth-iterator-utils
12
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix tracker.Restore test, add CT workflow #5

Merged
roysc merged 4 commits from fix-restore-test into main 2024-07-08 07:19:02 +00:00
Conversation 0 Commits 4 Files Changed 4
+43 -9
roysc commented 2024-07-07 06:10:19 +00:00
Owner
Copy Link
Copy Source

The unit test for Restore had failing corner cases, due to the NodeIterator constructor only allowing initialization at even-length paths. I couldn't find a cleaner solution than just allowing a possible node of overlap in the test.

Also:

  • adds a CT workflow
  • don't mutate input path in rewindPath
The unit test for Restore had failing corner cases, due to the `NodeIterator` constructor only allowing initialization at even-length paths. I couldn't find a cleaner solution than just allowing a possible node of overlap in the test. Also: - adds a CT workflow - don't mutate input path in `rewindPath`
dboreham was assigned by roysc 2024-07-07 06:10:19 +00:00
telackey was assigned by roysc 2024-07-07 06:10:19 +00:00
roysc added 5 commits 2024-07-07 06:10:20 +00:00
fix restore test cacec4add2
rewindPath shouldn't modify arg dc812b80bd
upgrade go 1.21 4b1dd89dbe
add unit test workflow a5cf8c42e9
extra runs for tracker test fedeb4e4ae
roysc added 1 commit 2024-07-07 06:13:50 +00:00
godoc to trigger action
Test / Run unit tests (pull_request) Successful in 3m29s
Details
c075acace4
roysc changed title from Fix `Restore` test, add CT workflow to Fix tracker.Restore test, add CT workflow 2024-07-08 06:15:24 +00:00
roysc force-pushed fix-restore-test from c075acace4 to ec6b6821b9 2024-07-08 06:53:13 +00:00 Compare
roysc merged commit ec6b6821b9 into main 2024-07-08 07:19:02 +00:00
roysc deleted branch fix-restore-test 2024-07-08 07:19:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees telackey dboreham
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/eth-iterator-utils#5