Felix Lange
995fab2ebc
p2p: fix yet another disconnect hang
...
Peer.readLoop will only terminate if the connection is closed. Fix the
hang by closing the connection before waiting for readLoop to terminate.
This also removes the british disconnect procedure where we're waiting
for the remote end to close the connection. I have confirmed with
@subtly that cpp-ethereum doesn't adhere to it either.
2015-04-13 17:34:08 +02:00
Felix Lange
79a6782c1c
p2p: fix goroutine leak when handshake read fails
...
This regression was introduced in b3c058a9e4
2015-04-13 17:06:19 +02:00
Felix Lange
faa2747809
Merge pull request #690 from karalabe/whisper-cleanup
...
Whisper cleanup, part 1
2015-04-13 13:39:59 +02:00
Péter Szilágyi
5467e7b312
whisper: fix comment entity capitalizations
2015-04-12 14:34:53 +03:00
Jeffrey Wilcke
61db7a71dd
Merge pull request #695 from ethersphere/frontier/blockpool
...
bugfixes for headsection deadlocks
2015-04-11 10:46:34 +02:00
zelig
406feee570
bugfixes for headsection deadlocks
...
- switchC initialised as closed
- move select in setChainInfoFromBlock out of peer lock
2015-04-11 04:58:53 +01:00
obscuren
f047699afb
Updated glog
2015-04-10 19:59:07 +02:00
obscuren
3aa5437a10
Set input to nil for create
2015-04-10 19:59:01 +02:00
obscuren
36fe11378c
Bump
2015-04-10 18:21:27 +02:00
obscuren
eb75a77151
Merge branch 'develop' of github.com-obscure:ethereum/go-ethereum into develop
2015-04-10 18:21:09 +02:00
Jeffrey Wilcke
6107b53de0
Merge pull request #692 from ethersphere/frontier/blockpool
...
td update from node + bugfix
2015-04-10 18:20:23 +02:00
obscuren
5d4f69f483
Merge branch 'develop' of github.com-obscure:ethereum/go-ethereum into develop
2015-04-10 17:59:38 +02:00
Jeffrey Wilcke
92fbb61625
Merge pull request #691 from fjl/discovery-fixes
...
p2p: a bunch of fixes
2015-04-10 17:59:32 +02:00
obscuren
3d29805322
Added pprof
2015-04-10 17:38:06 +02:00
zelig
da7332a731
td update from node
...
- reorg and simplify AddBlock
- introduce nodeCache
- TestPeerPromotionByTdOnBlock unskipped and passes
- move switchC/idleC channel creation around: solves deadlock (now respects the contract with section process: either can activate or complete at any one time)
2015-04-10 16:36:40 +01:00
Felix Lange
c5332537f5
p2p: limit number of lingering inbound pre-handshake connections
...
This is supposed to apply some back pressure so Server is not accepting
more connections than it can actually handle. The current limit is 50.
This doesn't really need to be configurable, but we'll see how it
behaves in our test nodes and adjust accordingly.
2015-04-10 17:24:41 +02:00
Felix Lange
56977c225e
p2p: use RLock instead of Lock for pre-dial checks
2015-04-10 17:23:09 +02:00
Felix Lange
b3c058a9e4
p2p: improve disconnect signaling at handshake time
...
As of this commit, p2p will disconnect nodes directly after the
encryption handshake if too many peer connections are active.
Errors in the protocol handshake packet are now handled more politely
by sending a disconnect packet before closing the connection.
2015-04-10 16:57:56 +02:00
Péter Szilágyi
f8a4cd7ec1
xeth/whisper, ui/qt/qwhisper: fix API update breaks.
2015-04-10 17:03:08 +03:00
Péter Szilágyi
0e4f21fc37
whisper: polish the Envelope a bit, prep for tests.
2015-04-10 16:52:01 +03:00
Péter Szilágyi
7d8ce53eca
whisper: polish the messages, fix some bugs, tests
...
Bugs fixed:
- Use randomly generated flags as the spec required.
- During envelope opening check the first bit only for signature.
2015-04-10 15:53:21 +03:00
Felix Lange
99a1db2d40
p2p: don't mess with the socket deadline in Peer.readLoop
...
netWrapper already sets a read deadline in ReadMsg.
2015-04-10 13:26:28 +02:00
Felix Lange
145330fdf2
p2p: properly decrement peer wait group counter for setup errors
2015-04-10 13:26:27 +02:00
Felix Lange
f1d710af00
p2p: fix Peer shutdown deadlocks
...
There were multiple synchronization issues in the disconnect handling,
all caused by the odd special-casing of Peer.readLoop errors. Remove the
special handling of read errors and make readLoop part of the Peer
WaitGroup.
Thanks to @Gustav-Simonsson for pointing at arrows in a diagram
and playing rubber-duck.
2015-04-10 13:26:27 +02:00
Felix Lange
22d1f0faf1
p2p: improve peer selection logic
...
This commit introduces a new (temporary) peer selection
strategy based on random lookups.
While we're here, also implement the TODOs in dialLoop.
2015-04-10 13:26:27 +02:00
Felix Lange
7be05b4b9d
p2p/discover: don't log packet content
2015-04-10 13:26:27 +02:00
Felix Lange
9cd8c96157
p2p/discover: make packet processing less concurrent
2015-04-10 13:26:27 +02:00
Péter Szilágyi
7e54a9c07f
whisper: rename test file according to Go style
2015-04-10 13:46:08 +03:00
Péter Szilágyi
a4c8e947b0
whisper: make the test app runnable & do something inside
2015-04-10 13:42:49 +03:00
obscuren
fc1d1f9afd
Merge branch 'develop' of github.com-obscure:ethereum/go-ethereum into develop
2015-04-10 11:03:46 +02:00
obscuren
3755cfccb3
Skipped td test
2015-04-10 11:03:36 +02:00
Jeffrey Wilcke
20fd60902b
Merge pull request #687 from karalabe/develop
...
xeth: fix #640 , panic converting nil recipient to hex.
2015-04-10 11:02:25 +02:00
Péter Szilágyi
d1729acd2b
cmd/mist: fix another nil recipient address panic.
2015-04-10 11:43:08 +03:00
Péter Szilágyi
b2b1241dd7
cmd/mist: fix #640 , panic converting nil recipient to hex.
...
Fetching the recipient address from a transaction was changed to return nil
instead of a zero-address, but this code path was not updated, so whenever
a contract was created, a nil panic occured.
2015-04-10 11:20:04 +03:00
Jeffrey Wilcke
4de1e1609a
Merge pull request #682 from bas-vk/issue_567
...
bugfix as a result of PR 671
2015-04-09 23:42:17 +02:00
Bas van Kervel
dc2b9fd458
bugfix as a result of PR 671
2015-04-09 20:06:27 +02:00
obscuren
ec9fbf09aa
Added some quotes ....
2015-04-09 18:24:22 +02:00
obscuren
9f5d24be31
glog
2015-04-09 18:16:22 +02:00
obscuren
b0f40beea6
Added proper contract for registrar
2015-04-09 17:59:05 +02:00
obscuren
ab015959e1
bump
2015-04-09 17:54:20 +02:00
obscuren
2747df3df1
added contracts
2015-04-09 17:42:43 +02:00
obscuren
01ee012197
Merge branch 'ethersphere-frontier/blockpool' into develop
2015-04-09 17:40:28 +02:00
obscuren
764a802eaa
Disabled TD check
...
@zelig: Temporarily commented out TD check untill the rest of the network has
been fixed.
2015-04-09 17:39:02 +02:00
obscuren
663fd8f849
Moved log to debug
2015-04-09 17:19:05 +02:00
obscuren
46898f1e55
Merge branch 'frontier/blockpool' of https://github.com/ethersphere/go-ethereum into ethersphere-frontier/blockpool
2015-04-09 16:54:32 +02:00
obscuren
0636e17dbe
Added default registrar
2015-04-09 16:37:04 +02:00
zelig
be25396340
separate lock for blacklist
2015-04-09 13:58:35 +01:00
zelig
a009132c24
oops peer unlocked before return - fixes deadlock
2015-04-09 13:58:35 +01:00
zelig
0e2bc23148
uncomment future block TD check, add test for skipping TD check on future block
2015-04-09 13:58:35 +01:00
zelig
e55747a074
fix deadlock issue in AddBlock
...
- add peer switch channel arg to activateChain - no peer locking within
- proper locking in AddBlock - fixes deadlock issue
- comment out TD check and skip incorrect TD test again for hotfix
2015-04-09 13:58:35 +01:00
