Merge pull request #18371 from jeremyschlatter/patch-1

core/types: update incorrect comment
This commit is contained in:
Péter Szilágyi 2019-01-04 10:14:17 +02:00 committed by GitHub
commit c1c4301121
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -234,7 +234,7 @@ func (tx *Transaction) AsMessage(s Signer) (Message, error) {
} }
// WithSignature returns a new transaction with the given signature. // WithSignature returns a new transaction with the given signature.
// This signature needs to be formatted as described in the yellow paper (v+27). // This signature needs to be in the [R || S || V] format where V is 0 or 1.
func (tx *Transaction) WithSignature(signer Signer, sig []byte) (*Transaction, error) { func (tx *Transaction) WithSignature(signer Signer, sig []byte) (*Transaction, error) {
r, s, v, err := signer.SignatureValues(tx, sig) r, s, v, err := signer.SignatureValues(tx, sig)
if err != nil { if err != nil {