run all

* first pass use tests/sdk-tests/run-tests.sh in github action

* - -> _

* diagnostic env step

* diagnostic env step

* diagnostic env step does not support cwd

* checkout not preserved between actions

* ./ missing

* start built containers

* missing unmarshalling of content bytes before encoding and generation of CID

* unchecked error complaint from linter

* golang linting is really picky

* utils/json test for comparing known, but deprecated method to new implementation

* try curl (retval 0) instead of wget (retval 8) for 404 that is returned

* missing curl for health check

* use feature branch for laconic-sdk... UNDO THIS LATER

* checkout is done from inside of container, rather than copied in from filesystem. checking out dev branch for now

* docker network inspect for diagnostic

* docker network inspect for diagnostic missing arg

* listen on 0.0.0.0 specfically

* trying localhost

* try host mode network

* host mode breaks name resolution of containers

* manual service check in laconicd container for diagnostic

* revert ListenAndServe

* sleep and docker logs... appears endpoint is not coming up maybe?

* disable fail_ci on codecov error... it is unstable

* turn codecov back to fail on error true to avoid invisible failure.

* Cleanup for whitespace and require.NoError in test

* new json util test, turning off codecov fails CI, and gitignore for test artifacts

.github/workflows/docker-image.yml

@@ -1,4 +1,4 @@
-name: Publish onn release
+name: Publish on release
 on:
   release:
     types: [published]

.github/workflows/test.yml

@@ -36,7 +36,7 @@ jobs:
       - uses: codecov/codecov-action@v3
         with:
           file: ./coverage.txt
-          fail_ci_if_error: true
+          fail_ci_if_error: false
         if: env.GIT_DIFF
 
   test-importer:
@@ -81,6 +81,30 @@ jobs:
           make test-rpc
         if: env.GIT_DIFF
 
+  sdk_tests:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Checkout laconic-sdk
+        uses: actions/checkout@v3
+        with:
+          path: "./laconic-sdk/"
+          repository: cerc-io/laconic-sdk
+          fetch-depth: 0
+          ref: jest_timeout
+      - name: Environment
+        run: ls -tlh && env
+      - name: build containers scripts
+        working-directory: tests/sdk_tests
+        run: ./build-laconicd-container.sh && ./build-sdk-test-container.sh
+      - name: start containers
+        working-directory: tests/sdk_tests
+        run: docker compose up -d
+      - name: run-tests.sh
+        working-directory: tests/sdk_tests
+        run: ./run-all-tests.sh
+
+
   # integration_tests:
   #   runs-on: ubuntu-latest
   #   steps:

.gitignore

@@ -50,6 +50,7 @@ coverage.txt
 sim_log_file
 tests/**/tmp/*
 yarn.lock
+x/auction/client/testutil/bidder-bafyre*
 
 # Vagrant
 .vagrant/

Dockerfile

@@ -20,7 +20,7 @@ RUN make build
 FROM alpine:3.17.0
 
 # Install ca-certificates
-RUN apk add --update ca-certificates jq
+RUN apk add --update ca-certificates jq curl
 WORKDIR /
 
 # Copy over binaries from the build-env

README.md

@@ -15,6 +15,14 @@ The Source of Proof. Laconic is a next generation data availability & verifiabil
 make install
 ```
 
+## Usage
+
+To quickly get started with a single node fixture, run:
+
+```bash
+./init.sh
+```
+
 ## Community
 
 The following chat channels and forums are a great spot to ask questions about Ethermint:

go.mod

@@ -18,6 +18,7 @@ require (
 	github.com/deckarep/golang-set v1.8.0
 	github.com/ethereum/go-ethereum v1.10.26
 	github.com/gibson042/canonicaljson-go v1.0.3
+	github.com/go-chi/chi/v5 v5.0.7
 	github.com/gogo/protobuf v1.3.3
 	github.com/golang/protobuf v1.5.2
 	github.com/gorilla/mux v1.8.0

go.sum

@@ -367,6 +367,8 @@ github.com/gin-gonic/gin v1.7.0/go.mod h1:jD2toBW3GZUr5UMcdrwQA10I7RuaFOl/SGeDjX
 github.com/glycerine/go-unsnap-stream v0.0.0-20180323001048-9f0cb55181dd/go.mod h1:/20jfyN9Y5QPEAprSgKAUr+glWDY39ZiUEAYOEv5dsE=
 github.com/glycerine/goconvey v0.0.0-20190410193231-58a59202ab31/go.mod h1:Ogl1Tioa0aV7gstGFO7KhffUsb9M4ydbEbbxpcEDc24=
 github.com/go-chi/chi/v5 v5.0.0/go.mod h1:BBug9lr0cqtdAhsu6R4AAdvufI0/XBzAQSsUqJpoZOs=
+github.com/go-chi/chi/v5 v5.0.7 h1:rDTPXLDHGATaeHvVlLcR4Qe0zftYethFucbjVQ1PxU8=
+github.com/go-chi/chi/v5 v5.0.7/go.mod h1:DslCQbL2OYiznFReuXYUmQ2hGd1aDpCnlMNITLSKoi8=
 github.com/go-gl/glfw v0.0.0-20190409004039-e6da0acd62b1/go.mod h1:vR7hzQXu2zJy9AVAgeJqvqgH9Q5CA+iKCZ2gyEVpxRU=
 github.com/go-gl/glfw/v3.3/glfw v0.0.0-20191125211704-12ad95a8df72/go.mod h1:tQ2UAYgL5IevRw8kRxooKSPJfGvJ9fJQFa0TUsXzTg8=
 github.com/go-gl/glfw/v3.3/glfw v0.0.0-20200222043503-6f7a984d4dc4/go.mod h1:tQ2UAYgL5IevRw8kRxooKSPJfGvJ9fJQFa0TUsXzTg8=

gql/graphiql.go

@@ -0,0 +1,165 @@
+package gql
+
+import (
+	"html/template"
+	"net/http"
+)
+
+// GraphiQL is an in-browser IDE for exploring GraphiQL APIs.
+// This handler returns GraphiQL when requested.
+//
+// For more information, see https://github.com/graphql/graphiql.
+
+func PlaygroundHandler(apiURL string) http.HandlerFunc {
+	return func(w http.ResponseWriter, r *http.Request) {
+		if r.Method != "GET" {
+			http.Error(w, "only GET requests are supported", http.StatusMethodNotAllowed)
+			return
+		}
+		w.Header().Set("Content-Type", "text/html")
+		err := page.Execute(w, map[string]interface{}{
+			"apiURL": apiURL,
+		})
+		if err != nil {
+			panic(err)
+		}
+	}
+}
+
+// https://github.com/graphql/graphiql/blob/main/examples/graphiql-cdn/index.html
+var page = template.Must(template.New("graphiql").Parse(`
+<!DOCTYPE html>
+<html lang="en">
+  <head>
+    <title>GraphiQL</title>
+    <style>
+      body {
+        height: 100%;
+        margin: 0;
+        width: 100%;
+        overflow: hidden;
+      }
+
+      #graphiql {
+        height: 100vh;
+      }
+    </style>
+
+    <!--
+      This GraphiQL example depends on Promise and fetch, which are available in
+      modern browsers, but can be "polyfilled" for older browsers.
+      GraphiQL itself depends on React DOM.
+      If you do not want to rely on a CDN, you can host these files locally or
+      include them directly in your favored resource bundler.
+    -->
+    <script
+      src="https://unpkg.com/react@17/umd/react.development.js"
+      integrity="sha512-Vf2xGDzpqUOEIKO+X2rgTLWPY+65++WPwCHkX2nFMu9IcstumPsf/uKKRd5prX3wOu8Q0GBylRpsDB26R6ExOg=="
+      crossorigin="anonymous"
+    ></script>
+    <script
+      src="https://unpkg.com/react-dom@17/umd/react-dom.development.js"
+      integrity="sha512-Wr9OKCTtq1anK0hq5bY3X/AvDI5EflDSAh0mE9gma+4hl+kXdTJPKZ3TwLMBcrgUeoY0s3dq9JjhCQc7vddtFg=="
+      crossorigin="anonymous"
+    ></script>
+
+    <!--
+      These two files can be found in the npm module, however you may wish to
+      copy them directly into your environment, or perhaps include them in your
+      favored resource bundler.
+     -->
+    <link rel="stylesheet" href="https://unpkg.com/graphiql/graphiql.min.css" />
+  </head>
+
+  <body>
+    <div id="graphiql">Loading...</div>
+    <script
+      src="https://unpkg.com/graphiql/graphiql.min.js"
+      type="application/javascript"
+    ></script>
+    <script>
+      // https://github.com/graphql/graphiql/blob/main/packages/graphiql/resources/renderExample.js
+      
+      // Parse the search string to get url parameters.
+      var search = window.location.search;
+      var parameters = {};
+      search
+        .substr(1)
+        .split('&')
+        .forEach(function (entry) {
+          var eq = entry.indexOf('=');
+          if (eq >= 0) {
+            parameters[decodeURIComponent(entry.slice(0, eq))] = decodeURIComponent(
+              entry.slice(eq + 1),
+            );
+          }
+        });
+      
+      // When the query and variables string is edited, update the URL bar so
+      // that it can be easily shared.
+      function onEditQuery(newQuery) {
+        parameters.query = newQuery;
+        updateURL();
+      }
+      
+      function onEditVariables(newVariables) {
+        parameters.variables = newVariables;
+        updateURL();
+      }
+      
+      function onEditHeaders(newHeaders) {
+        parameters.headers = newHeaders;
+        updateURL();
+      }
+      
+      function onTabChange(tabsState) {
+        const activeTab = tabsState.tabs[tabsState.activeTabIndex];
+        parameters.query = activeTab.query;
+        parameters.variables = activeTab.variables;
+        parameters.headers = activeTab.headers;
+        updateURL();
+      }
+      
+      function updateURL() {
+        var newSearch =
+          '?' +
+          Object.keys(parameters)
+            .filter(function (key) {
+              return Boolean(parameters[key]);
+            })
+            .map(function (key) {
+              return (
+                encodeURIComponent(key) + '=' + encodeURIComponent(parameters[key])
+              );
+            })
+            .join('&');
+        history.replaceState(null, null, newSearch);
+      }
+      
+      // Render <GraphiQL /> into the body.
+      // See the README in the top level of this module to learn more about
+      // how you can customize GraphiQL by providing different values or
+      // additional child elements.
+      ReactDOM.render(
+        React.createElement(GraphiQL, {
+          fetcher: GraphiQL.createFetcher({
+            url: {{.apiURL}}
+          }),
+          query: parameters.query,
+          variables: parameters.variables,
+          headers: parameters.headers,
+          defaultHeaders: parameters.defaultHeaders,
+          onEditQuery: onEditQuery,
+          onEditVariables: onEditVariables,
+          onEditHeaders: onEditHeaders,
+          defaultEditorToolsVisibility: true,
+          isHeadersEditorEnabled: true,
+          shouldPersistHeaders: true,
+          onTabChange,
+        }),
+        document.getElementById('graphiql'),
+      );
+    </script>
+  </body>
+</html>
+`))

gql/server.go

@@ -5,9 +5,10 @@ import (
 	"net/http"
 
 	"github.com/99designs/gqlgen/graphql/handler"
-	"github.com/99designs/gqlgen/graphql/playground"
 	"github.com/cosmos/cosmos-sdk/client"
 	"github.com/ethereum/go-ethereum/log"
+	"github.com/go-chi/chi/v5"
+	"github.com/rs/cors"
 	"github.com/spf13/viper"
 )
 
@@ -16,6 +17,16 @@ func Server(ctx client.Context) {
 	if !viper.GetBool("gql-server") {
 		return
 	}
+
+	router := chi.NewRouter()
+
+	// Add CORS middleware around every request
+	// See https://github.com/rs/cors for full option listing
+	router.Use(cors.New(cors.Options{
+		AllowedOrigins: []string{"*"},
+		Debug:          false,
+	}).Handler)
+
 	logFile := viper.GetString("log-file")
 
 	port := viper.GetString("gql-port")
@@ -25,20 +36,20 @@ func Server(ctx client.Context) {
 		logFile: logFile,
 	}}))
 
-	http.Handle("/", playground.Handler("GraphQL playground", "/api"))
+	router.Handle("/", PlaygroundHandler("/api"))
 
 	if viper.GetBool("gql-playground") {
 		apiBase := viper.GetString("gql-playground-api-base")
 
-		http.Handle("/webui", playground.Handler("GraphQL playground", apiBase+"/api"))
-		http.Handle("/console", playground.Handler("GraphQL playground", apiBase+"/graphql"))
+		router.Handle("/webui", PlaygroundHandler(apiBase+"/api"))
+		router.Handle("/console", PlaygroundHandler(apiBase+"/graphql"))
 	}
 
-	http.Handle("/api", srv)
-	http.Handle("/graphql", srv)
+	router.Handle("/api", srv)
+	router.Handle("/graphql", srv)
 
 	log.Info("Connect to GraphQL playground", "url", fmt.Sprintf("http://localhost:%s", port))
-	err := http.ListenAndServe(":"+port, nil) //nolint: all
+	err := http.ListenAndServe(":"+port, router) //nolint: all
 	if err != nil {
 		panic(err)
 	}

testnet/validator upgrade 0.6.0 - 0.7.0.md

@@ -0,0 +1,178 @@
+# Validator Upgrade Guide for laconic_81337-5 Testnet v0.6.0 -> v0.7.0
+
+This guide assumes you have followed the instructions to crete a systemd service or docker container validator node v0.6.0 and you perform the upgrade on a machine running v0.6.0
+
+It is highly recommended to make the backup of your datadir after you stop v0.6.0 and before you start v0.7.0. Unless you changed your datadir, it should be located in `~/.laconicd`
+
+## Systemd service
+Skip this section if you use docker
+
+This is very similar to building v0.6.0. We keep v 0.6.0 running until v0.7.0 is built and only after the successful build we should replace 0.6.0 binary with v0.7.0. This is to avoid jailing your validator for long downtime.
+The general upgrade plan is the following:
+  1. Install Go v1.19.5 (we used 1.18 for v0.6.0)
+  2. Remove old copy of the github repository and build directory
+  3. Download the latest laconicd repository and checkout v0.7.0
+  4. Build laconicd binary (but not install in this moment)
+  5. Stop laconicd systemd service
+  6. Install recently built new version of laconicd
+  7. Start laconicd service
+
+>***You have ~10 minutes after step 5 to complete steps 6 and 7 before your validator is jailed for downtime. Getting jailed for downtime is not a disaster, however would require manual unjailing.***
+
+
+
+### Install Go 1.19
+
+```sh
+# Update Ubuntu
+sudo apt update
+sudo apt upgrade -y
+
+# Install required software packages
+sudo apt install git curl build-essential make jq -y
+
+# Remove any existing installation of `go`
+sudo rm -rf /usr/local/go
+
+# Install Go version 1.19.5
+curl https://dl.google.com/go/go1.19.5.linux-amd64.tar.gz | sudo tar -C/usr/local -zxvf -
+
+```
+
+Check the version of go installed
+
+```sh
+go version
+
+# Should return something like: go version go1.19.5 linux/amd64
+```
+
+---
+
+### Remove old copy of `laconicd` build
+
+>Attention should be paid that the directory mentioned below is `~/laconicd` and NOT `~/.laconicd`. The latter is the data directory containing all your node data and configuration and it must be kept during the upgrade.
+
+```sh
+# Remove the previous build directory
+cd ~
+rm -rf laconicd
+```
+
+---
+
+### Download `laconicd` repository
+```sh
+git clone https://github.com/cerc-io/laconicd.git
+cd laconicd
+
+# Checkout 0.7.0 branch
+git fetch --all
+git checkout v0.7.0
+```
+
+---
+
+### Build the new version of `laconicd`
+
+```sh
+# Build laconic (but not install at this moment)
+make VERSION=v0.7.0 build
+```
+
+---
+
+### Stop `laconicd` systemd service
+
+```sh
+sudo systemctl stop laconicd
+```
+
+>***Make sure the service is stopped***
+
+```sh
+sudo systemctl status laconicd
+```
+
+---
+
+### Install new `laconicd` version
+
+```sh
+make VERSION=v0.7.0 install
+```
+
+Verify your installation
+
+```sh
+laconicd version
+```
+This should return `0.7.0`
+
+---
+
+### Start `laconicd` systemd service
+
+```sh
+sudo systemctl start laconicd
+```
+
+Verify that the node joined the network and produces new blocks
+
+```sh
+journalctl -f -u laconicd
+```
+
+
+---
+
+## Docker container
+
+Upgrade plan:
+  1. Stop running v0.6.0 container
+  2. Delete v0.6.0 container
+  3. Create v0.7.0 container
+  4. Start v0.7.0 container
+
+>***You have ~10 minutes to complete the upgrade procedure before your validator is jailed for downtime. Getting jailed for downtime is not a disaster, however would require manual unjailing.***
+
+### Stop running v0.6.0 container
+```sh
+docker stop laconic-testnet-5
+```
+
+---
+
+### Delete v0.6.0 container
+```sh
+docker rm laconic-testnet-5
+```
+
+---
+
+### Create v0.7.0 container
+```sh
+docker create --name laconic-testnet-5 \
+--restart always \
+-v ~/.laconicd:/root/.laconicd \
+-p 26656:26656 \
+-p 127.0.0.1:26657:26657 \
+-p 127.0.0.1:26660:26660 \
+git.vdb.to/cerc-io/laconicd/laconicd:v0.7.0 \
+laconicd start --gql-playground --gql-server --log_level=warn
+```
+
+---
+
+### Start v0.7.0 container
+```sh
+docker start laconic-testnet-5
+```
+
+Verify that the node joined the network and produces new blocks
+
+```sh
+docker logs -f laconic-testnet-5
+```
+
+---

tests/sdk_tests/Dockerfile-sdk

@@ -47,6 +47,7 @@ WORKDIR /app
 RUN \
     git clone https://github.com/cerc-io/laconic-sdk.git \
     && cd laconic-sdk \
+    && git checkout auction_nameservice_tests \
     && yarn install
 
 WORKDIR /app/laconic-sdk

tests/sdk_tests/docker-compose.yml

@@ -2,11 +2,14 @@ services:
   laconicd:
     restart: unless-stopped
     image: cerc-io/laconicd:local-test
+    environment:
+      - TEST_AUCTION_ENABLED=true
+      - TEST_REGISTRY_EXPIRY=true
     command: ["sh", "/docker-entrypoint-scripts.d/create-fixturenet.sh"]
     volumes:
             - ../../init.sh:/docker-entrypoint-scripts.d/create-fixturenet.sh
     healthcheck:
-      test: ["CMD", "wget", "-nv", "-t1", "--spider", "http://localhost:6060"]
+      test: ["CMD", "curl", "-v", "http://127.0.0.1:6060"]
       interval: 1s
       timeout: 5s
       retries: 30

tests/sdk_tests/run-all-tests.sh

@@ -0,0 +1,18 @@
+#!/usr/bin/env bash
+if [ -n "$CERC_SCRIPT_DEBUG" ]; then
+    set -x
+fi
+# Get the key from laconicd
+laconicd_key=$( docker compose exec laconicd echo y | docker compose exec laconicd laconicd keys export mykey --unarmored-hex --unsafe )
+# Set parameters for the test suite
+cosmos_chain_id=laconic_9000-1
+laconicd_rest_endpoint=http://laconicd:1317
+laconicd_gql_endpoint=http://laconicd:9473/api
+# Run tests
+docker network inspect sdk_tests_default
+sleep 30s
+
+docker compose exec sdk-test-runner sh -c "COSMOS_CHAIN_ID=${cosmos_chain_id} LACONICD_REST_ENDPOINT=${laconicd_rest_endpoint} LACONICD_GQL_ENDPOINT=${laconicd_gql_endpoint} PRIVATE_KEY=${laconicd_key} yarn test"
+docker compose exec sdk-test-runner sh -c "COSMOS_CHAIN_ID=${cosmos_chain_id} LACONICD_REST_ENDPOINT=${laconicd_rest_endpoint} LACONICD_GQL_ENDPOINT=${laconicd_gql_endpoint} PRIVATE_KEY=${laconicd_key} yarn test:auctions"
+docker compose exec sdk-test-runner sh -c "COSMOS_CHAIN_ID=${cosmos_chain_id} LACONICD_REST_ENDPOINT=${laconicd_rest_endpoint} LACONICD_GQL_ENDPOINT=${laconicd_gql_endpoint} PRIVATE_KEY=${laconicd_key} yarn test:nameservice-expiry"
+docker logs sdk_tests-laconicd-1

tests/sdk_tests/run-tests.sh

@@ -9,4 +9,10 @@ cosmos_chain_id=laconic_9000-1
 laconicd_rest_endpoint=http://laconicd:1317
 laconicd_gql_endpoint=http://laconicd:9473/api
 # Run tests
+docker network inspect sdk_tests_default
+sleep 30s
+docker logs laconicd
+docker compose exec laconicd sh -c "curl http://127.0.0.1:9473/api"
+docker compose exec laconicd sh -c "curl http://localhost:9473/api"
+
 docker compose exec sdk-test-runner sh -c "COSMOS_CHAIN_ID=${cosmos_chain_id} LACONICD_REST_ENDPOINT=${laconicd_rest_endpoint} LACONICD_GQL_ENDPOINT=${laconicd_gql_endpoint} PRIVATE_KEY=${laconicd_key} yarn test"

utils/json.go

@@ -8,17 +8,16 @@ import (
 	"bytes"
 	"errors"
 
-	"github.com/ipld/go-ipld-prime/codec/dagcbor"
-	"github.com/ipld/go-ipld-prime/fluent"
-	"github.com/ipld/go-ipld-prime/linking"
-	cidlink "github.com/ipld/go-ipld-prime/linking/cid"
-	"github.com/ipld/go-ipld-prime/multicodec"
-	"github.com/ipld/go-ipld-prime/storage/memstore"
-
 	canonicalJson "github.com/gibson042/canonicaljson-go"
 	"github.com/ipfs/go-cid"
 	cbor "github.com/ipfs/go-ipld-cbor"
+	"github.com/ipld/go-ipld-prime/codec/dagcbor"
+	"github.com/ipld/go-ipld-prime/codec/dagjson"
+	"github.com/ipld/go-ipld-prime/linking"
+	cidlink "github.com/ipld/go-ipld-prime/linking/cid"
+	"github.com/ipld/go-ipld-prime/multicodec"
 	basicnode "github.com/ipld/go-ipld-prime/node/basic"
+	"github.com/ipld/go-ipld-prime/storage/memstore"
 	mh "github.com/multiformats/go-multihash"
 )
 
@@ -68,7 +67,17 @@ func GetAttributeAsString(obj map[string]interface{}, attr string) (string, erro
 }
 
 // CIDFromJSONBytesUsingIpldPrime returns CID (dagcbor) for json (as bytes).
+// This is combination of samples for unmarshalling and linking
+// see: https://pkg.go.dev/github.com/ipld/go-ipld-prime
 func CIDFromJSONBytesUsingIpldPrime(content []byte) (string, error) {
+	np := basicnode.Prototype.Any                       // Pick a stle for the in-memory data.
+	nb := np.NewBuilder()                               // Create a builder.
+	err := dagjson.Decode(nb, bytes.NewReader(content)) // Hand the builder to decoding -- decoding will fill it in!
+	if err != nil {
+		return "", err
+	}
+	n := nb.Build() // Call 'Build' to get the resulting Node.  (It's immutable!)
+
 	lsys := cidlink.DefaultLinkSystem()
 
 	// We want to store the serialized data somewhere.
@@ -87,14 +96,6 @@ func CIDFromJSONBytesUsingIpldPrime(content []byte) (string, error) {
 		MhLength: 32,   // sha2-256 hash has a 32-byte sum.
 	}}
 
-	// And we need some data to link to!  Here's a quick piece of example data:
-	n, err := fluent.Build(basicnode.Prototype.Any, func(na fluent.NodeAssembler) {
-		na.AssignBytes(content)
-	})
-	if err != nil {
-		return "", err
-	}
-
 	// Now: time to apply the LinkSystem, and do the actual store operation!
 	lnk, err := lsys.Store(
 		linking.LinkContext{}, // The zero value is fine.  Configure it it you want cancellability or other features.

utils/json_test.go

@@ -0,0 +1,35 @@
+package utils
+
+import (
+	"github.com/stretchr/testify/require"
+	"testing"
+)
+
+func TestAndValidateCIDGeneration(t *testing.T) {
+	testCases := []struct {
+		name     string
+		content  string
+		expected string
+	}{
+		// empty string and empty json blows up
+		// {
+		//  	"empty string", "", "bafyreiengp2sbi6ez34a2jctv34bwyjl7yoliteleaswgcwtqzrhmpyt2m",
+		// },
+		// {
+		//		"empty json", "{}", "bafyreihpfkdvib5muloxlj5b3tgdwibjdcu3zdsuhyft33z7gtgnlzlkpm",
+		// },
+
+		{
+			"test record", "{\"build_artifact_cid\":\"QmP8jTG1m9GSDJLCbeWhVSVgEzCPPwXRdCRuJtQ5Tz9Kc9\",\"repo_registration_record_cid\":\"QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D\",\"tls_cert_cid\":\"QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR\",\"type\":\"WebsiteRegistrationRecord\",\"url\":\"https://cerc.io\",\"version\":\"0.0.1\"}",
+			"bafyreiek4hnoqmits66bjyxswapplweuoqe4en2ux6u772o4y3askpd3ny",
+		},
+	}
+
+	for _, tc := range testCases {
+		deprecatedAndCorrect, _ := CIDFromJSONBytes([]byte(tc.content))
+		newImpl, err := CIDFromJSONBytesUsingIpldPrime([]byte(tc.content))
+		require.NoError(t, err)
+		require.Equal(t, deprecatedAndCorrect, newImpl, tc.name)
+		require.Equal(t, tc.expected, newImpl)
+	}
+}

x/registry/keeper/keeper.go

@@ -111,7 +111,7 @@ func (k Keeper) GetRecord(ctx sdk.Context, id string) (record types.Record) {
 	store := ctx.KVStore(k.storeKey)
 	result := store.Get(GetRecordIndexKey(id))
 	k.cdc.MustUnmarshal(result, &record)
-	return record
+	return recordObjToRecord(store, record)
 }
 
 // ListRecords - get all records.