Merge pull request #107 from surajssd/port-checking

Abstracted port checking function

pkg/transformer/kubernetes/k8sutils.go

@@ -213,3 +213,12 @@ func convertToVersion(objs []runtime.Object) ([]runtime.Object, error) {
 
 	return ret, nil
 }
+
+func PortsExist(name string, service kobject.ServiceConfig) bool {
+	if len(service.Port) == 0 {
+		logrus.Warningf("[%s] Service cannot be created because of missing port.", name)
+		return false
+	} else {
+		return true
+	}
+}

pkg/transformer/kubernetes/kubernetes.go

@@ -314,11 +314,10 @@ func (k *Kubernetes) Transform(komposeObject kobject.KomposeObject, opt kobject.
 		}
 
 		// If ports not provided in configuration we will not make service
-		if len(ports) == 0 {
-			logrus.Warningf("[%s] Service cannot be created because of missing port.", name)
-		} else {
+		if PortsExist(name, service) {
 			objects = append(objects, sc)
 		}
+
 		allobjects = append(allobjects, objects...)
 	}
 

pkg/transformer/openshift/openshift.go

@@ -153,9 +153,7 @@ func (k *OpenShift) Transform(komposeObject kobject.KomposeObject, opt kobject.C
 		}
 
 		// If ports not provided in configuration we will not make service
-		if len(ports) == 0 {
-			logrus.Warningf("[%s] Service cannot be created because of missing port.", name)
-		} else {
+		if kubernetes.PortsExist(name, service) {
 			objects = append(objects, sc)
 		}
 		allobjects = append(allobjects, objects...)