Thomas E Lackey
b22c72e715
Some checks failed
Lint Checks / Run linter (push) Successful in 45s
Publish / Build and publish (push) Successful in 1m22s
K8s Deploy Test / Run deploy test suite on kind/k8s (push) Failing after 3m20s
Deploy Test / Run deploy test suite (push) Successful in 5m28s
Webapp Test / Run webapp test suite (push) Successful in 4m28s
Smoke Test / Run basic test suite (push) Successful in 4m58s
In kind, when we bind-mount a host directory it is first mounted into the kind container at /mnt, then into the pod at the desired location. We accidentally picked this up for full-blown k8s, and were creating volumes at /mnt. This changes the behavior for both kind and regular k8s so that bind mounts are only allowed if a fully-qualified path is specified. If no path is specified at all, a default storageClass is assumed to be present, and the volume managed by a provisioner. Eg, for kind, the default provisioner is: https://github.com/rancher/local-path-provisioner ``` stack: test deploy-to: k8s-kind config: test-variable-1: test-value-1 network: ports: test: - '80' volumes: # this will be bind-mounted to a host-path test-data-bind: /srv/data # this will be managed by the k8s node test-data-auto: configmaps: test-config: ./configmap/test-config ``` Reviewed-on: #741 Co-authored-by: Thomas E Lackey <telackey@bozemanpass.com> Co-committed-by: Thomas E Lackey <telackey@bozemanpass.com>
64 lines
2.6 KiB
Python
64 lines
2.6 KiB
Python
# Copyright © 2023 Vulcanize
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU Affero General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU Affero General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU Affero General Public License
|
|
# along with this program. If not, see <http:#www.gnu.org/licenses/>.
|
|
|
|
from typing import Set
|
|
|
|
from python_on_whales import DockerClient
|
|
|
|
from stack_orchestrator import constants
|
|
from stack_orchestrator.opts import opts
|
|
from stack_orchestrator.deploy.deployment_context import DeploymentContext
|
|
from stack_orchestrator.deploy.deploy_types import DeployCommandContext
|
|
from stack_orchestrator.deploy.deploy_util import images_for_deployment
|
|
|
|
|
|
def _image_needs_pushed(image: str):
|
|
# TODO: this needs to be more intelligent
|
|
return image.endswith(":local")
|
|
|
|
|
|
def remote_tag_for_image(image: str, remote_repo_url: str):
|
|
# Turns image tags of the form: foo/bar:local into remote.repo/org/bar:deploy
|
|
major_parts = image.split("/", 2)
|
|
image_name_with_version = major_parts[1] if 2 == len(major_parts) else major_parts[0]
|
|
(image_name, image_version) = image_name_with_version.split(":")
|
|
if image_version == "local":
|
|
return f"{remote_repo_url}/{image_name}:deploy"
|
|
else:
|
|
return image
|
|
|
|
|
|
# TODO: needs lots of error handling
|
|
def push_images_operation(command_context: DeployCommandContext, deployment_context: DeploymentContext):
|
|
# Get the list of images for the stack
|
|
cluster_context = command_context.cluster_context
|
|
images: Set[str] = images_for_deployment(cluster_context.compose_files)
|
|
# Tag the images for the remote repo
|
|
remote_repo_url = deployment_context.spec.obj[constants.image_registry_key]
|
|
docker = DockerClient()
|
|
for image in images:
|
|
if _image_needs_pushed(image):
|
|
remote_tag = remote_tag_for_image(image, remote_repo_url)
|
|
if opts.o.verbose:
|
|
print(f"Tagging {image} to {remote_tag}")
|
|
docker.image.tag(image, remote_tag)
|
|
# Run docker push commands to upload
|
|
for image in images:
|
|
if _image_needs_pushed(image):
|
|
remote_tag = remote_tag_for_image(image, remote_repo_url)
|
|
if opts.o.verbose:
|
|
print(f"Pushing image {remote_tag}")
|
|
docker.image.push(remote_tag)
|