For k8s, use provisioner-managed volumes when an absolute host path is not specified. #741

Merged

telackey merged 8 commits from telackey/autopv into main 2024-02-14 21:45:03 +00:00

Conversation 0 Commits 8 Files Changed 11 +266 -106

telackey commented 2024-02-14 02:16:22 +00:00

Member

Copy Link

In kind, when we bind-mount a host directory it is first mounted into the kind container at /mnt, then into the pod at the desired location.

We accidentally picked this up for full-blown k8s, and were creating volumes at /mnt. This changes the behavior for both kind and regular k8s so that bind mounts are only allowed if a fully-qualified path is specified. If no path is specified at all, a default storageClass is assumed to be present, and the volume managed by a provisioner.

Eg, for kind, the default provisioner is: https://github.com/rancher/local-path-provisioner

stack: test
deploy-to: k8s-kind
config:
  test-variable-1: test-value-1
network:
  ports:
    test:
     - '80'
volumes:
  # this will be bind-mounted to a host-path
  test-data-bind: /srv/data
  # this will be managed by the k8s node
  test-data-auto:
configmaps:
  test-config: ./configmap/test-config

In kind, when we bind-mount a host directory it is first mounted into the kind container at /mnt, then into the pod at the desired location. We accidentally picked this up for full-blown k8s, and were creating volumes at /mnt. This changes the behavior for both kind and regular k8s so that bind mounts are only allowed if a fully-qualified path is specified. If no path is specified at all, a default storageClass is assumed to be present, and the volume managed by a provisioner. Eg, for kind, the default provisioner is: https://github.com/rancher/local-path-provisioner ``` stack: test deploy-to: k8s-kind config: test-variable-1: test-value-1 network: ports: test: - '80' volumes: # this will be bind-mounted to a host-path test-data-bind: /srv/data # this will be managed by the k8s node test-data-auto: configmaps: test-config: ./configmap/test-config ```

telackey added 1 commit 2024-02-14 02:16:23 +00:00

For k8s, use provisioner-managed volumes when an absolute host path is not specified. 2b535b25db

telackey added 1 commit 2024-02-14 02:22:47 +00:00

plural 0d59c5d06e

telackey added 1 commit 2024-02-14 02:26:39 +00:00

flake8 210ec4f1d9

telackey changed title from WIP: For k8s, use provisioner-managed volumes when an absolute host path is not specified. to For k8s, use provisioner-managed volumes when an absolute host path is not specified. 2024-02-14 02:47:12 +00:00

telackey added 1 commit 2024-02-14 02:51:01 +00:00

Fix test d82350c040

telackey requested review from dboreham 2024-02-14 02:57:16 +00:00

telackey added 1 commit 2024-02-14 04:20:06 +00:00

Add comment. 6411f12770

telackey added 1 commit 2024-02-14 21:27:14 +00:00

Honor the --delete-volumes flag. 88d8bab8b2

telackey added 1 commit 2024-02-14 21:29:19 +00:00

Rename function 063effeab9

telackey added 1 commit 2024-02-14 21:35:57 +00:00

lint eac1cf0246

telackey merged commit b22c72e715 into main 2024-02-14 21:45:03 +00:00

telackey deleted branch telackey/autopv 2024-02-14 21:45:03 +00:00

telackey referenced this issue from a commit 2024-02-14 21:45:04 +00:00

For k8s, use provisioner-managed volumes when an absolute host path is not specified. (#741)

Sign in to join this conversation.

Reviewers

No reviewers

dboreham

Labels

Clear labels   

bug

Something isn't working

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

feature

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

in progress

  

invalid

This doesn't seem right

  

question

Further information is requested

  

wontfix

This will not be worked on

  

Copied from Github

An issue or PR manually copied from GitHub.

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No Label

bug

documentation

duplicate

enhancement

feature

good first issue

help wanted

in progress

invalid

question

wontfix

Copied from Github

Kind/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#741

No description provided.