cerc-io/stack-orchestrator
17
1
Fork 3
Code Issues 113 Pull Requests 18 Actions Packages Projects Releases 480 Wiki Activity

Honor DOCKER_DEFAULT_PLATFORM with fetch-containers #944

Open
telackey wants to merge 1 commits from telackey/defaultplatform into main
pull from: telackey/defaultplatform
merge into: cerc-io:main
Conversation 0 Commits 1 Files Changed 1 +13 -7
telackey commented 2024-08-29 19:58:00 +00:00
Member
Copy Link

Docker allows overriding the current platform by setting DOCKER_DEFAULT_PLATFORM. This updates fetch-containers to honor that when set, rather than auto-detect the platform.

Docker allows overriding the current platform by setting `DOCKER_DEFAULT_PLATFORM`. This updates `fetch-containers` to honor that when set, rather than auto-detect the platform.
telackey added 1 commit 2024-08-29 19:58:02 +00:00
Honor DOCKER_DEFAULT_PLATFORM
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 39s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 6m1s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 5m33s
Details
K8s Deployment Control Test / Run deployment control suite on kind/k8s (pull_request) Successful in 7m39s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 9m0s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m16s
Details
4e5b5ff031
telackey requested review from dboreham 2024-08-29 21:08:19 +00:00
telackey changed title from WIP: Honor DOCKER_DEFAULT_PLATFORM to Honor DOCKER_DEFAULT_PLATFORM when fetching images 2024-08-29 21:08:34 +00:00
telackey changed title from Honor DOCKER_DEFAULT_PLATFORM when fetching images to Honor DOCKER_DEFAULT_PLATFORM with `fetch-containers` 2024-08-29 21:09:12 +00:00
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 39s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 6m1s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 5m33s
Details
K8s Deployment Control Test / Run deployment control suite on kind/k8s (pull_request) Successful in 7m39s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 9m0s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m16s
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin telackey/defaultplatform:telackey/defaultplatform
git checkout telackey/defaultplatform
Sign in to join this conversation.
Reviewers
No reviewers
dboreham
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#944
No description provided.
Delete Branch "telackey/defaultplatform"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?