cerc-io/stack-orchestrator
17
1
Fork 3
Code Issues 112 Pull Requests 19 Actions Packages Projects Releases 480 Wiki Activity

[WIP] nextjs config file options #879

Closed
VPhung24 wants to merge 5 commits from viv/nextjs-config-files into main
pull from: viv/nextjs-config-files
merge into: cerc-io:main
Conversation 3 Commits 5 Files Changed 1 +25 -21
VPhung24 commented 2024-07-21 22:44:42 +00:00
Owner
Copy Link

nextjs may have nextjs.config.js and nextjs.config.mjs lets account for that

  • todo: tests
nextjs may have `nextjs.config.js` and `nextjs.config.mjs` lets account for that - todo: tests
VPhung24 added 1 commit 2024-07-21 22:44:43 +00:00
nextjs config file options
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 40s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m17s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m36s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m19s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 7m51s
Details
b1659823fb
dboreham commented 2024-07-22 04:38:23 +00:00
Owner
Copy Link

Looks useful. I would encourage adding a couple lines of comments to the code (or if that is unappealing, to this PR) explaining what's being done. E.g. is running code formatting on the config file done to make it reliably transformable later?

Looks useful. I would encourage adding a couple lines of comments to the code (or if that is unappealing, to this PR) explaining what's being done. E.g. is running code formatting on the config file done to make it reliably transformable later?
👍 1
VPhung24 added 2 commits 2024-07-22 13:38:53 +00:00 
This reverts commit b1659823fb.
format
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 41s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m35s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m18s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m5s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 7m34s
Details
32cbdc9008
VPhung24 added 1 commit 2024-07-22 13:52:29 +00:00
comments on js-beautify
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 36s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m41s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m53s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m14s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 8m51s
Details
13303c3f7a
VPhung24 added 1 commit 2024-07-22 13:53:40 +00:00
comments on js-beautify
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 43s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m37s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m45s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m56s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 8m44s
Details
725be0dd22
VPhung24 commented 2024-07-22 13:55:43 +00:00
Author
Owner
Copy Link

Looks useful. I would encourage adding a couple lines of comments to the code (or if that is unappealing, to this PR) explaining what's being done. E.g. is running code formatting on the config file done to make it reliably transformable later?

updated with on line 45. Let me know if you had something else in mind.

# js-beautify formats NEXTJS_CONFIG_FILE (ie next.config.js / next.config.mjs) so we can reliably transformable later
js-beautify next.config.dist > "$NEXTJS_CONFIG_FILE"
echo "" >> "$NEXTJS_CONFIG_FILE"
> Looks useful. I would encourage adding a couple lines of comments to the code (or if that is unappealing, to this PR) explaining what's being done. E.g. is running code formatting on the config file done to make it reliably transformable later? updated with on line 45. Let me know if you had something else in mind. ```zsh # js-beautify formats NEXTJS_CONFIG_FILE (ie next.config.js / next.config.mjs) so we can reliably transformable later js-beautify next.config.dist > "$NEXTJS_CONFIG_FILE" echo "" >> "$NEXTJS_CONFIG_FILE" ```
VPhung24 requested review from dboreham 2024-07-22 13:56:06 +00:00
VPhung24 requested review from telackey 2024-07-22 13:56:07 +00:00
telackey commented 2024-08-05 20:53:32 +00:00
Member
Copy Link

Superseded by #890

Superseded by https://git.vdb.to/cerc-io/stack-orchestrator/pulls/890
telackey closed this pull request 2024-08-05 20:53:33 +00:00
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 43s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m37s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m45s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m56s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 8m44s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
dboreham
telackey
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#879
No description provided.
Delete Branch "viv/nextjs-config-files"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?