cerc-io/stack-orchestrator
12
1
Fork 3
Code Issues 112 Pull Requests 23 Actions Packages Projects Releases 483 Wiki Activity

Add --fqdn-policy option to deploy-webapp-from-registry. #802

Merged
dboreham merged 1 commits from telackey/fqdn2 into main 2024-04-15 12:20:37 +00:00
Conversation 0 Commits 1 Files Changed 1 +18 -8
telackey commented 2024-04-12 22:01:01 +00:00
Contributor
Copy Link

This add a new option --fqdn-policy to the deploy-webapp-from-registry.

The default policy, prohibit means that ApplicationDeploymentRequests which specify a FQDN will be rejected. The allow policy will cause them to be processed. The preexisting policy will only process them if an existing DnsRecord exists in the registry with the correct ownership.

The latter would be useful in conjunction with a pre-checking scheme in the UI (eg, that the DNS entry is properly configured, the domain is under the control of the requestor, etc.) Only after all the checks were successful would the DnsRecord be created, allowing for ApplicationDeploymentRequests to use it.

This add a new option `--fqdn-policy` to the `deploy-webapp-from-registry`. The default policy, `prohibit` means that `ApplicationDeploymentRequests` which specify a FQDN will be rejected. The `allow` policy will cause them to be processed. The `preexisting` policy will only process them if an existing `DnsRecord` exists in the registry with the correct ownership. The latter would be useful in conjunction with a pre-checking scheme in the UI (eg, that the DNS entry is properly configured, the domain is under the control of the requestor, etc.) Only after all the checks were successful would the `DnsRecord` be created, allowing for `ApplicationDeploymentRequests` to use it.
telackey added 1 commit 2024-04-12 22:01:02 +00:00
Add --fqdn-policy option to deploy-webapp-from-registry.
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 46s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 5m6s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 6m16s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m56s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 9m16s
Details
367a173287
telackey requested review from dboreham 2024-04-12 22:01:19 +00:00
telackey self-assigned this 2024-04-12 22:01:32 +00:00
dboreham approved these changes 2024-04-15 12:20:12 +00:00
dboreham merged commit 4126f2fc43 into main 2024-04-15 12:20:37 +00:00
telackey deleted branch telackey/fqdn2 2024-04-15 18:07:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dboreham
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
telackey
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#802
No description provided.
Delete Branch "telackey/fqdn2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?