cerc-io/stack-orchestrator
16
1
Fork 1
Code Issues 87 Pull Requests 14 Actions Packages Projects Releases 434 Wiki Activity

WIP: Add support for bun as a webapp package manager #800

Draft
VPhung24 wants to merge 1 commits from VPhung24/bun-for-nextjs-and-webapps into main
pull from: VPhung24/bun-for-nextjs-and-webapps
merge into: cerc-io:main
Conversation 1 Commits 1 Files Changed 6 +12
VPhung24 commented 2024-04-12 02:35:18 +00:00
Owner
Copy Link

This is working off pull request "Add support for pnpm as a webapp build tool. #767" that adds pnpm package manager support for nextjs & webapps.

bun default build output directory (defined as CERC_BUILD_OUTPUT_DIR) is dist which should already be handled with pnpm support in the previously mentioned pull request

Installing bun using npm following our previous pnpm installation

npm install -g bun

We'll be using bun as a package manager that works with Node.js projects as defined in bun's docs

The bun CLI contains a Node.js-compatible package manager designed to be a dramatically faster replacement for npm, yarn, and pnpm. It's a standalone tool that will work in pre-existing Node.js projects; if your project has a package.json, bun install can help you speed up your workflow.

To test next.js apps using node.js and compatibility with all four packager managers -- npm, yarn, pnpm, and bun -- use the branches of snowball's nextjs-package-manager-example-app repo: nextjs-package-manager/npm, nextjs-package-manager/yarn, nextjs-package-manager/pnpm, nextjs-package-manager/bun.

This is working off pull request "[Add support for pnpm as a webapp build tool. #767](https://git.vdb.to/cerc-io/stack-orchestrator/pulls/767/files)" that adds `pnpm` package manager support for `nextjs` & `webapps`. `bun` default build output directory (defined as `CERC_BUILD_OUTPUT_DIR`) is `dist` which should already be handled with `pnpm` support in the previously mentioned [pull request](https://git.vdb.to/cerc-io/stack-orchestrator/pulls/767/files) Installing `bun` using `npm` following our previous `pnpm` installation ```zsh npm install -g bun ``` We'll be using `bun` as a package manager that works with `Node.js` projects as defined in bun's [docs](https://bun.sh/docs/cli/install) > The bun CLI contains a Node.js-compatible package manager designed to be a dramatically faster replacement for npm, yarn, and pnpm. It's a standalone tool that will work in pre-existing Node.js projects; if your project has a package.json, bun install can help you speed up your workflow. To test `next.js` apps using `node.js` and compatibility with all four packager managers -- `npm`, `yarn`, `pnpm`, and `bun` -- use the branches of snowball's [nextjs-package-manager-example-app](https://git.vdb.to/snowball/nextjs-package-manager-example-app) repo: `nextjs-package-manager/npm`, `nextjs-package-manager/yarn`, `nextjs-package-manager/pnpm`, `nextjs-package-manager/bun`.
VPhung24 added 1 commit 2024-04-12 02:35:19 +00:00
bun package management support for nextjs & webapps
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 38s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 4m57s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 9m18s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m42s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m40s
Details
fa2e0b8cf0
VPhung24 requested review from dboreham 2024-04-12 02:35:28 +00:00
VPhung24 added the
enhancement
help wanted
 labels 2024-04-12 02:35:41 +00:00
jonathanface reviewed 2024-04-12 02:41:31 +00:00
stack_orchestrator/data/container-build/cerc-nextjs-base/Dockerfile
@ -29,2 +29,4 @@
# Install pnpm
&& su ${USERNAME} -c "umask 0002 && npm install -g pnpm" \
# Install bun
&& su ${USERNAME} -c "umask 0002 && npm install -g bun@1.1.x" \
jonathanface commented 2024-04-12 02:41:31 +00:00
Owner
Copy Link

couldn't all these npm installs be combined?

su ${USERNAME} -c "umask 0002 && npm install -g bun@1.1.x semver pnpm"

I don't actually know if it would work, just an idea

couldn't all these npm installs be combined? `su ${USERNAME} -c "umask 0002 && npm install -g bun@1.1.x semver pnpm"` I don't actually know if it would work, just an idea
❤️ 1
VPhung24 commented 2024-04-12 05:28:51 +00:00
Author
Owner
Copy Link

As a guest contributor (plus as my first pull request and docker noob), I followed @telackey (approved by @dboreham) code style from the pnpm pull request & current code.

@telackey @dboreham your call.

As a guest contributor (plus as my first pull request and docker noob), I followed @telackey (approved by @dboreham) code style from the [pnpm pull request](https://git.vdb.to/cerc-io/stack-orchestrator/pulls/767/files) & current code. @telackey @dboreham your call.
dboreham commented 2024-04-15 13:11:48 +00:00
Owner
Copy Link

Running npm several times is probably not much slower than running it once to install several packages.
The more important issue is to run all the commands in the same docker layer, which is being done.

Running npm several times is probably not much slower than running it once to install several packages. The more important issue is to run all the commands in the same docker layer, which _is_ being done.
VPhung24 requested review from telackey 2024-04-12 05:29:23 +00:00
VPhung24 self-assigned this 2024-04-12 05:29:34 +00:00
VPhung24 changed title from bun package management support for nextjs & webapps to Add support for bun as a webapp package manager 2024-04-12 05:38:28 +00:00
dboreham changed title from Add support for bun as a webapp package manager to WIP: Add support for bun as a webapp package manager 2024-04-12 13:51:07 +00:00
dboreham commented 2024-04-12 13:56:26 +00:00
Owner
Copy Link

Hi, this should be tested using a test like this one: https://git.vdb.to/cerc-io/stack-orchestrator/src/branch/main/tests/webapp-test/run-webapp-test.sh (can be run manually first, then we can talk about making a CI version).

Currently the CI test uses this repo for its target app : https://git.vdb.to/cerc-io/test-progressive-web-app but perhaps we should switch to the multi-branch test app cited above now that we have three package managers to test?

Hi, this should be tested using a test like this one: https://git.vdb.to/cerc-io/stack-orchestrator/src/branch/main/tests/webapp-test/run-webapp-test.sh (can be run manually first, then we can talk about making a CI version). Currently the CI test uses this repo for its target app : https://git.vdb.to/cerc-io/test-progressive-web-app but perhaps we should switch to the multi-branch test app cited above now that we have three package managers to test?
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 38s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 4m57s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 9m18s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m42s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m40s
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin VPhung24/bun-for-nextjs-and-webapps:VPhung24/bun-for-nextjs-and-webapps
git checkout VPhung24/bun-for-nextjs-and-webapps
Sign in to join this conversation.
Reviewers
No reviewers
dboreham
telackey
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
VPhung24
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#800
No description provided.
Delete Branch "VPhung24/bun-for-nextjs-and-webapps"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?