Add support for bun as a webapp package manager #800
Dismiss Review
Are you sure you want to dismiss this review?
Labels
Clear labels
K8s
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Something isn't working
Improvements or additions to documentation
This issue or pull request already exists
New feature or request
Good for newcomers
Extra attention is needed
This doesn't seem right
Further information is requested
This will not be worked on
An issue or PR manually copied from GitHub.
Breaking change that won't be backward compatible
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No due date set.
Dependencies
No dependencies set.
Reference: cerc-io/stack-orchestrator#800
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
This is working off pull request "Add support for pnpm as a webapp build tool. #767" that adds
pnpmpackage manager support fornextjs&webapps.bundefault build output directory (defined asCERC_BUILD_OUTPUT_DIR) isdistwhich should already be handled withpnpmsupport in the previously mentioned pull requestInstalling
bunusingnpmfollowing our previouspnpminstallationWe'll be using
bunas a package manager that works withNode.jsprojects as defined in bun's docsTo test
next.jsapps usingnode.jsand compatibility with all four packager managers --npm,yarn,pnpm, andbun-- use the branches of snowball's nextjs-package-manager-example-app repo:nextjs-package-manager/npm,nextjs-package-manager/yarn,nextjs-package-manager/pnpm,nextjs-package-manager/bun.@@ -29,2 +29,4 @@# Install pnpm&& su ${USERNAME} -c "umask 0002 && npm install -g pnpm" \# Install bun&& su ${USERNAME} -c "umask 0002 && npm install -g bun@1.1.x" \couldn't all these npm installs be combined?
su ${USERNAME} -c "umask 0002 && npm install -g bun@1.1.x semver pnpm"I don't actually know if it would work, just an idea
As a guest contributor (plus as my first pull request and docker noob), I followed @telackey (approved by @dboreham) code style from the pnpm pull request & current code.
@telackey @dboreham your call.
Running npm several times is probably not much slower than running it once to install several packages.
The more important issue is to run all the commands in the same docker layer, which is being done.
bun package management support for nextjs & webappsto Add support for bun as a webapp package managerHi, this should be tested using a test like this one: https://git.vdb.to/cerc-io/stack-orchestrator/src/branch/main/tests/webapp-test/run-webapp-test.sh (can be run manually first, then we can talk about making a CI version).
Currently the CI test uses this repo for its target app : https://git.vdb.to/cerc-io/test-progressive-web-app but perhaps we should switch to the multi-branch test app cited above now that we have three package managers to test?