Check for existing tag in remote repo before building. #764

Merged

telackey merged 14 commits from telackey/remotetag into main 2024-02-24 03:22:51 +00:00

Conversation 0 Commits 14 Files Changed 3

+53 -10

telackey commented 2024-02-23 20:38:05 +00:00

Contributor

Copy Link

Copy Source

webapps are meant to be build-once/deploy-many, but we were rebuilding them for every request. This changes that, so that we rebuild only for every unique ApplicationRecord.

When we push the image, we now tag it according to its ApplicationRecord.

We don't want to use that tag directly in the compose file for the deployment, however, as the deployment needs to be able to adjust to new builds w/o re-writing the file all the time. Instead, we use a per-deployment unique tag (same as before), we just update what image it references as needed.

webapps are meant to be build-once/deploy-many, but we were rebuilding them for every request. This changes that, so that we rebuild only for every unique ApplicationRecord. When we push the image, we now tag it according to its ApplicationRecord. We don't want to use that tag directly in the compose file for the deployment, however, as the deployment needs to be able to adjust to new builds w/o re-writing the file all the time. Instead, we use a per-deployment unique tag (same as before), we just update what image it references as needed.

telackey added 1 commit 2024-02-23 20:38:06 +00:00

WIP: Check for existing tag in remote repo before building. 2d8cc09e6f

telackey added 1 commit 2024-02-23 21:22:25 +00:00

refactor 2a34f43678

telackey added 2 commits 2024-02-24 00:02:20 +00:00

g a408d24905

Remote tag check f06b5ec6a2

telackey added 1 commit 2024-02-24 00:06:20 +00:00

lint d8f5d41261

telackey added 1 commit 2024-02-24 00:52:45 +00:00

Working b0d003cc01

telackey added 1 commit 2024-02-24 00:59:52 +00:00

Add comment. 61d254cd6c

telackey marked the pull request as ready for review 2024-02-24 01:00:23 +00:00

telackey requested review from dboreham 2024-02-24 01:37:29 +00:00

telackey added 1 commit 2024-02-24 01:41:09 +00:00

Refactor 3194ebf8a6

telackey added 1 commit 2024-02-24 01:53:03 +00:00

push-images will only use the compose-defined tag a54e9c43a0

telackey added 1 commit 2024-02-24 01:53:44 +00:00

comment 8efe753ca4

telackey added 1 commit 2024-02-24 01:54:07 +00:00

fmt f27248b508

telackey added 1 commit 2024-02-24 02:54:13 +00:00

logging 694590ed56

telackey added 1 commit 2024-02-24 02:58:41 +00:00

refactor 39bf0e2795

telackey added 1 commit 2024-02-24 03:20:41 +00:00

Merge branch 'main' into telackey/remotetag d38d1f192c

telackey merged commit a0413659f7 into main 2024-02-24 03:22:51 +00:00

telackey deleted branch telackey/remotetag 2024-02-24 03:22:51 +00:00

telackey referenced this issue from a commit 2024-02-24 03:22:51 +00:00

Check for existing tag in remote repo before building. (#764)

This repo is archived. You cannot comment on pull requests.

Reviewers

No Reviewers

dboreham

Labels

Clear labels

K8s

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

feature

good first issue

Good for newcomers

help wanted

Extra attention is needed

in progress

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

Copied from Github

An issue or PR manually copied from GitHub.

Kind/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Reviewed

Confirmed

Issue has been confirmed

Reviewed

Duplicate

This issue or pull request already exists

Reviewed

Invalid

Invalid issue

Reviewed

Won't Fix

This issue won't be fixed

Status

Abandoned

Somebody has started to work on this but abandoned work

Status

Blocked

Something is blocking this issue or pull request

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay

No Assignees

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#764