cerc-io/stack-orchestrator
Archived
12
1
Fork 3
Code Issues 117 Pull Requests 25 Actions Packages Projects Releases 493 Wiki Activity

Updates for running IPLD-ETH CI tests #414

Merged
telackey merged 8 commits from roy/ipld-eth-ci into main 2023-05-31 08:10:59 +00:00
Conversation 9 Commits 8 Files Changed 12
+31 -23
roysc commented 2023-05-28 09:29:58 +00:00
Owner
Copy Link
Copy Source

A few patches needed to make this work in CI for our IPLD-ETH projects, e.g. on https://github.com/cerc-io/ipld-eth-server/pull/238.

May resolve https://github.com/cerc-io/stack-orchestrator/issues/416

A few patches needed to make this work in CI for our IPLD-ETH projects, e.g. on https://github.com/cerc-io/ipld-eth-server/pull/238. May resolve https://github.com/cerc-io/stack-orchestrator/issues/416
dboreham left a comment
Contributor

I don't see -modern images for lcli (only for lighthouse) : https://hub.docker.com/r/sigp/lcli/tags

I don't see -modern images for lcli (only for lighthouse) : https://hub.docker.com/r/sigp/lcli/tags
roysc commented 2023-05-29 13:54:59 +00:00
Author
Owner
Copy Link
Copy Source

Yeah, seems lcli is always published with PORTABLE=true

Yeah, seems lcli is always published with [PORTABLE=true](https://github.com/sigp/lighthouse/blob/c547a11b0da48db6fdd03bca2c6ce2448bbcc3a9/.github/workflows/docker.yml#L145)
app/data/container-build/cerc-lighthouse/Dockerfile
@@ -1,4 +1,5 @@
FROM sigp/lighthouse:v4.1.0-modern
ARG TAG_SUFFIX="-modern"
FROM sigp/lighthouse:v4.1.0${TAG_SUFFIX}
dboreham commented 2023-05-30 12:01:10 +00:00
Contributor

Remove -modern suffix default since that tag isn't used for this image?

Remove `-modern` suffix default since that tag isn't used for this image?
tests/fixturenet-eth/run-test.sh
@@ -5,3 +5,3 @@
fi
set -e
echo "Running stack-orchestrator Ethereum fixturenet test"
dboreham commented 2023-05-30 12:02:21 +00:00
Contributor

set -e was necessary, no?

`set -e` was necessary, no?
tests/fixturenet-eth/run-test.sh
@@ -5,3 +5,3 @@
fi
set -e
echo "Running stack-orchestrator Ethereum fixturenet test"
roysc commented 2023-05-30 12:14:24 +00:00
Author
Owner

Already set on line 2 :)

Already set on line 2 :)
tests/fixturenet-eth/run-test.sh
@@ -5,3 +5,3 @@
fi
set -e
echo "Running stack-orchestrator Ethereum fixturenet test"
dboreham commented 2023-05-30 12:15:39 +00:00
Contributor

The magic of context diffs without enough context ;)

The magic of context diffs without enough context ;)
app/data/container-build/cerc-lighthouse/Dockerfile
@@ -1,4 +1,5 @@
FROM sigp/lighthouse:v4.1.0-modern
ARG TAG_SUFFIX="-modern"
FROM sigp/lighthouse:v4.1.0${TAG_SUFFIX}
roysc commented 2023-05-30 12:22:47 +00:00
Author
Owner

Not sure I follow - this currently uses modern, should we default to not using it?

Not sure I follow - this currently uses `modern`, should we default to not using it?
app/data/container-build/cerc-lighthouse/Dockerfile
@@ -1,4 +1,5 @@
FROM sigp/lighthouse:v4.1.0-modern
ARG TAG_SUFFIX="-modern"
FROM sigp/lighthouse:v4.1.0${TAG_SUFFIX}
dboreham commented 2023-05-30 12:26:05 +00:00
Contributor

Bah, looking at the wrong image. I thought this was lcli.

Bah, looking at the wrong image. I thought this was lcli.
dboreham approved these changes 2023-05-30 12:27:16 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
telackey
roysc
dboreham
Labels
Clear labels
K8s
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 in progress
invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
3 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#414