cerc-io/stack-orchestrator
17
1
Fork 3
Code Issues 114 Pull Requests 20 Actions Packages Projects Releases 481 Wiki Activity

Update webapp deployment flow for supporting custom domains #963

Merged
ashwin merged 3 commits from deep-stack/stack-orchestrator:pm-custom-domains into main 2025-02-04 13:26:33 +00:00
Conversation 0 Commits 3 Files Changed 2 +15
prathamesh commented 2025-01-30 06:07:34 +00:00
Member
Copy Link

Part of https://www.notion.so/Support-custom-domains-in-deploy-laconic-com-18aa6b22d4728067a44ae27090c02ce5 and cerc-io/snowballtools-base#47

  • Set value (IP address for A resource) in the DNS records
  • Update deploy-webapp-from-registry command with an option to pass k8s cluster IP address (only required with fqdn policy allow)
Part of https://www.notion.so/Support-custom-domains-in-deploy-laconic-com-18aa6b22d4728067a44ae27090c02ce5 and https://git.vdb.to/cerc-io/snowballtools-base/issues/47 - Set `value` (IP address for `A` resource) in the DNS records - Update `deploy-webapp-from-registry` command with an option to pass k8s cluster IP address (only required with fqdn policy `allow`)
prathamesh added 2 commits 2025-01-30 06:07:35 +00:00
Require IP input with allow FQDN policy
Some checks failed
Lint Checks / Run linter (pull_request) Successful in 36s
Details
Deploy Test / Run deploy test suite (pull_request) Failing after 1m12s
Details
K8s Deployment Control Test / Run deployment control suite on kind/k8s (pull_request) Failing after 1m17s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Failing after 1m19s
Details
Webapp Test / Run webapp test suite (pull_request) Failing after 1m20s
Details
Smoke Test / Run basic test suite (pull_request) Failing after 1m11s
Details
27a6470ad9
prathamesh added 1 commit 2025-01-30 06:19:05 +00:00
Fix function arg type
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 38s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m26s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 5m10s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m19s
Details
K8s Deployment Control Test / Run deployment control suite on kind/k8s (pull_request) Successful in 7m7s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 7m56s
Details
a085ca8756
prathamesh changed title from [WIP] Update webapp deployment flow for supporting custom domains to Update webapp deployment flow for supporting custom domains 2025-01-30 13:46:00 +00:00
ashwin approved these changes 2025-01-31 10:37:24 +00:00
ashwin merged commit 873a6d472c into main 2025-02-04 13:26:33 +00:00
ashwin deleted branch pm-custom-domains 2025-02-04 13:26:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ashwin
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#963
No description provided.
Delete Branch "deep-stack/stack-orchestrator:pm-custom-domains"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?