Require IP input with allow FQDN policy
Some checks failed
Lint Checks / Run linter (pull_request) Successful in 36s
Deploy Test / Run deploy test suite (pull_request) Failing after 1m12s
K8s Deployment Control Test / Run deployment control suite on kind/k8s (pull_request) Failing after 1m17s
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Failing after 1m19s
Webapp Test / Run webapp test suite (pull_request) Failing after 1m20s
Smoke Test / Run basic test suite (pull_request) Failing after 1m11s

This commit is contained in:
Prathamesh Musale 2025-01-30 11:33:33 +05:30
parent 53a96defe0
commit 27a6470ad9
2 changed files with 10 additions and 2 deletions

View File

@ -433,6 +433,13 @@ def command( # noqa: C901
)
sys.exit(2)
if fqdn_policy == "allow" and not ip:
print(
"--ip is required with 'allow' fqdn-policy",
file=sys.stderr,
)
sys.exit(2)
tempdir = tempfile.mkdtemp()
gpg = gnupg.GPG(gnupghome=tempdir)

View File

@ -688,7 +688,7 @@ def publish_deployment(
deployment_lrn,
dns_record,
dns_lrn,
dns_value: str,
dns_value: str | None,
deployment_dir,
app_deployment_request=None,
webapp_deployer_record=None,
@ -717,12 +717,13 @@ def publish_deployment(
"version": dns_ver,
"name": fqdn,
"resource_type": "A",
"value": dns_value,
"meta": {"so": uniq.hex},
}
}
if app_deployment_request:
new_dns_record["record"]["request"] = app_deployment_request.id
if dns_value:
new_dns_record["record"]["value"] = dns_value
if logger:
logger.log("Publishing DnsRecord.")