cerc-io/stack-orchestrator
16
1
Fork 1
Code Issues 88 Pull Requests 11 Actions Packages Projects Releases 442 Wiki Activity

Check for existing tag in remote repo before building. #764

Merged
telackey merged 14 commits from telackey/remotetag into main 2024-02-24 03:22:51 +00:00
Conversation 0 Commits 14 Files Changed 3 +53 -10
telackey commented 2024-02-23 20:38:05 +00:00
Member
Copy Link

webapps are meant to be build-once/deploy-many, but we were rebuilding them for every request. This changes that, so that we rebuild only for every unique ApplicationRecord.

When we push the image, we now tag it according to its ApplicationRecord.

We don't want to use that tag directly in the compose file for the deployment, however, as the deployment needs to be able to adjust to new builds w/o re-writing the file all the time. Instead, we use a per-deployment unique tag (same as before), we just update what image it references as needed.

webapps are meant to be build-once/deploy-many, but we were rebuilding them for every request. This changes that, so that we rebuild only for every unique ApplicationRecord. When we push the image, we now tag it according to its ApplicationRecord. We don't want to use that tag directly in the compose file for the deployment, however, as the deployment needs to be able to adjust to new builds w/o re-writing the file all the time. Instead, we use a per-deployment unique tag (same as before), we just update what image it references as needed.
telackey added 1 commit 2024-02-23 20:38:06 +00:00
WIP: Check for existing tag in remote repo before building.
Some checks failed
Lint Checks / Run linter (pull_request) Failing after 24s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 4m33s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 6m30s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 5m34s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 3m44s
Details
2d8cc09e6f
telackey added 1 commit 2024-02-23 21:22:25 +00:00
refactor
Some checks failed
Lint Checks / Run linter (pull_request) Failing after 47s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m35s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 12m38s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 5m6s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 5m50s
Details
2a34f43678
telackey added 2 commits 2024-02-24 00:02:20 +00:00
Remote tag check
Some checks failed
Lint Checks / Run linter (pull_request) Failing after 53s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m59s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 6m55s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 7m0s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 3m38s
Details
f06b5ec6a2
telackey added 1 commit 2024-02-24 00:06:20 +00:00
lint
Some checks failed
Lint Checks / Run linter (pull_request) Failing after 33s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 3m43s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m55s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m51s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 7m4s
Details
d8f5d41261
telackey added 1 commit 2024-02-24 00:52:45 +00:00
Working
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 55s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 4m19s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 5m21s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 5m24s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 6m29s
Details
b0d003cc01
telackey added 1 commit 2024-02-24 00:59:52 +00:00
Add comment.
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 52s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m9s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 6m15s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 5m30s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 7m0s
Details
61d254cd6c
telackey changed title from WIP: Check for existing tag in remote repo before building. to Check for existing tag in remote repo before building. 2024-02-24 01:00:23 +00:00
telackey requested review from dboreham 2024-02-24 01:37:29 +00:00
telackey added 1 commit 2024-02-24 01:41:09 +00:00
Refactor
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 29s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 2m53s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 4m16s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 2m50s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 9m11s
Details
3194ebf8a6
telackey added 1 commit 2024-02-24 01:53:03 +00:00
push-images will only use the compose-defined tag
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 26s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 2m59s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 4m19s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 5m9s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 9m44s
Details
a54e9c43a0
telackey added 1 commit 2024-02-24 01:53:44 +00:00
comment
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 26s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 4m35s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 5m2s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 6m13s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 3m1s
Details
8efe753ca4
telackey added 1 commit 2024-02-24 01:54:07 +00:00
fmt
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 38s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 3m11s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 2m50s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m30s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 9m20s
Details
f27248b508
telackey added 1 commit 2024-02-24 02:54:13 +00:00
logging
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 25s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m0s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 5m33s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 3m14s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m22s
Details
694590ed56
telackey added 1 commit 2024-02-24 02:58:41 +00:00
refactor
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 34s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m17s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 3m25s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 6m20s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m58s
Details
39bf0e2795
telackey added 1 commit 2024-02-24 03:20:41 +00:00
Merge branch 'main' into telackey/remotetag
Some checks failed
Lint Checks / Run linter (pull_request) Successful in 49s
Details
Webapp Test / Run webapp test suite (pull_request) Failing after 2m22s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 6m55s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 2m52s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Failing after 8m19s
Details
d38d1f192c
telackey merged commit a0413659f7 into main 2024-02-24 03:22:51 +00:00
telackey deleted branch telackey/remotetag 2024-02-24 03:22:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dboreham
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#764
No description provided.
Delete Branch "telackey/remotetag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?