cerc-io/stack-orchestrator
17
1
Fork 2
Code Issues 112 Pull Requests 15 Actions Packages Projects Releases 473 Wiki Activity

Updates for running IPLD-ETH CI tests #414

Merged
telackey merged 8 commits from roy/ipld-eth-ci into main 2023-05-31 08:10:59 +00:00
Conversation 1 Commits 8 Files Changed 12 +31 -23
roysc commented 2023-05-28 09:29:58 +00:00
Member
Copy Link

A few patches needed to make this work in CI for our IPLD-ETH projects, e.g. on https://github.com/cerc-io/ipld-eth-server/pull/238.

May resolve https://github.com/cerc-io/stack-orchestrator/issues/416

A few patches needed to make this work in CI for our IPLD-ETH projects, e.g. on https://github.com/cerc-io/ipld-eth-server/pull/238. May resolve https://github.com/cerc-io/stack-orchestrator/issues/416
telackey reviewed 2023-05-28 09:29:58 +00:00
dboreham reviewed 2023-05-29 13:38:54 +00:00
dboreham left a comment
Owner
Copy Link

I don't see -modern images for lcli (only for lighthouse) : https://hub.docker.com/r/sigp/lcli/tags

I don't see -modern images for lcli (only for lighthouse) : https://hub.docker.com/r/sigp/lcli/tags
roysc commented 2023-05-29 13:54:59 +00:00
Author
Member
Copy Link

Yeah, seems lcli is always published with PORTABLE=true

Yeah, seems lcli is always published with [PORTABLE=true](https://github.com/sigp/lighthouse/blob/c547a11b0da48db6fdd03bca2c6ce2448bbcc3a9/.github/workflows/docker.yml#L145)
dboreham requested changes 2023-05-30 12:02:38 +00:00
app/data/container-build/cerc-lighthouse/Dockerfile
@ -1,4 +1,5 @@
FROM sigp/lighthouse:v4.1.0-modern
ARG TAG_SUFFIX="-modern"
FROM sigp/lighthouse:v4.1.0${TAG_SUFFIX}
dboreham commented 2023-05-30 12:01:10 +00:00
Owner
Copy Link

Remove -modern suffix default since that tag isn't used for this image?

Remove `-modern` suffix default since that tag isn't used for this image?
tests/fixturenet-eth/run-test.sh
@ -5,3 +5,3 @@
fi
set -e
echo "Running stack-orchestrator Ethereum fixturenet test"
dboreham commented 2023-05-30 12:02:21 +00:00
Owner
Copy Link

set -e was necessary, no?

`set -e` was necessary, no?
roysc reviewed 2023-05-30 12:14:24 +00:00
tests/fixturenet-eth/run-test.sh
@ -5,3 +5,3 @@
fi
set -e
echo "Running stack-orchestrator Ethereum fixturenet test"
roysc commented 2023-05-30 12:14:24 +00:00
Author
Member
Copy Link

Already set on line 2 :)

Already set on line 2 :)
dboreham reviewed 2023-05-30 12:15:40 +00:00
tests/fixturenet-eth/run-test.sh
@ -5,3 +5,3 @@
fi
set -e
echo "Running stack-orchestrator Ethereum fixturenet test"
dboreham commented 2023-05-30 12:15:39 +00:00
Owner
Copy Link

The magic of context diffs without enough context ;)

The magic of context diffs without enough context ;)
roysc reviewed 2023-05-30 12:22:47 +00:00
app/data/container-build/cerc-lighthouse/Dockerfile
@ -1,4 +1,5 @@
FROM sigp/lighthouse:v4.1.0-modern
ARG TAG_SUFFIX="-modern"
FROM sigp/lighthouse:v4.1.0${TAG_SUFFIX}
roysc commented 2023-05-30 12:22:47 +00:00
Author
Member
Copy Link

Not sure I follow - this currently uses modern, should we default to not using it?

Not sure I follow - this currently uses `modern`, should we default to not using it?
dboreham reviewed 2023-05-30 12:26:05 +00:00
app/data/container-build/cerc-lighthouse/Dockerfile
@ -1,4 +1,5 @@
FROM sigp/lighthouse:v4.1.0-modern
ARG TAG_SUFFIX="-modern"
FROM sigp/lighthouse:v4.1.0${TAG_SUFFIX}
dboreham commented 2023-05-30 12:26:05 +00:00
Owner
Copy Link

Bah, looking at the wrong image. I thought this was lcli.

Bah, looking at the wrong image. I thought this was lcli.
dboreham approved these changes 2023-05-30 12:27:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
telackey
dboreham
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#414
No description provided.
Delete Branch "roy/ipld-eth-ci"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?