fix(deploy): merge volumes from stack init() instead of overwriting

Previously, volumes defined in a stack's commands.py init() function were being overwritten by volumes discovered from compose files. This prevented stacks from adding infrastructure volumes like caddy-data that aren't defined in the compose files. Now volumes are merged, with init() volumes taking precedence over compose-discovered defaults. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Merge pull request 'Add --update flag to deploy create' (#984 ) from roysc/deployment-create-sync into main
2026-01-31 18:23:20 -05:00 · 2026-01-31 22:46:40 +00:00
1 changed files with 4 additions and 1 deletions
@@ -468,7 +468,10 @@ def init_operation(
            else:
                volume_descriptors[named_volume] = f"./data/{named_volume}"
        if volume_descriptors:
-            spec_file_content["volumes"] = volume_descriptors
+            # Merge with existing volumes from stack init()
+            # init() volumes take precedence over compose defaults
+            orig_volumes = spec_file_content.get("volumes", {})
+            spec_file_content["volumes"] = {**volume_descriptors, **orig_volumes}
        if configmap_descriptors:
            spec_file_content["configmaps"] = configmap_descriptors
Author	SHA1	Message	Date
A. F. DudleyandClaude Opus 4.5	76c0c17c3b	fix(deploy): merge volumes from stack init() instead of overwriting Lint Checks / Run linter (push) Successful in 14s Details Lint Checks / Run linter (pull_request) Successful in 16s Details Deploy Test / Run deploy test suite (pull_request) Successful in 2m23s Details Webapp Test / Run webapp test suite (pull_request) Successful in 4m5s Details Smoke Test / Run basic test suite (pull_request) Successful in 4m7s Details K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 6m51s Details K8s Deployment Control Test / Run deployment control suite on kind/k8s (pull_request) Successful in 2m0s Details Previously, volumes defined in a stack's commands.py init() function were being overwritten by volumes discovered from compose files. This prevented stacks from adding infrastructure volumes like caddy-data that aren't defined in the compose files. Now volumes are merged, with init() volumes taking precedence over compose-discovered defaults. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-01-31 18:23:20 -05:00
AFDudley	6a2bbae250	Merge pull request 'Add `--update` flag to `deploy create`' (#984 ) from roysc/deployment-create-sync into main Lint Checks / Run linter (push) Successful in 17s Details Publish / Build and publish (push) Successful in 31s Details External Stack Test / Run external stack test suite (push) Failing after 2m11s Details Deploy Test / Run deploy test suite (push) Successful in 2m12s Details Webapp Test / Run webapp test suite (push) Successful in 4m2s Details Database Test / Run database hosting test on kind/k8s (push) Successful in 4m12s Details Smoke Test / Run basic test suite (push) Successful in 4m1s Details Reviewed-on: #984 Reviewed-by: AFDudley <afdudley@noreply.git.vdb.to>	2026-01-31 22:46:40 +00:00