Commit Graph

23135 Commits

Author SHA1 Message Date
Nikola Matic
cca1b460c9 Unpeg fixed dependency from elementfi external test 2022-12-15 16:45:44 +01:00
Kamil Śliwak
e06f3b2c46
Merge pull request #13806 from ethereum/fix-pooltogether-failing-test
Pin v4-core dependecy to fix failing exteral pooltogether test
2022-12-15 14:40:52 +01:00
Nikola Matic
ab78f69bf5 Pin v4-core dependecy to fix failing exteral pooltogether test 2022-12-15 12:53:57 +01:00
Kamil Śliwak
37e935f025
Merge pull request #13803 from kuzdogan/docs-favicon
[docs]: Add Solidity favicon
2022-12-14 23:37:47 +01:00
Kaan Uzdogan
a98bb41bd3 Add Solidity favicon to docs 2022-12-14 18:15:50 +01:00
Kamil Śliwak
e769c79813
Merge pull request #13741 from ethereum/consistent-bound-function-terminology
Consistent terminology for attached/bound functions
2022-12-14 14:53:47 +01:00
John Kane
f5858a118d
docs(resources.rst): update editor extensions
Update the editor extensions section of the resources page:

1. Remove the Atom section - as Atom is being deprecated on
   2022-12-15. See https://github.blog/2022-06-08-sunsetting-atom/.
2. Update the vim syntax plugins - remove the tomlion extension as
   no longer maintained, add the thesis and TovarishFin forks of
   the tomlion vim syntax highlighter as these are both maintained.
3. add/rename vscode extensions - add truffle and remix extensions,
   rename the two Solidity extensions to include the authors for
   disambiguation.
4. Clarify the Visual Studio Code title by including `VS Code` in
   brackets, as many people only know it as `VS Code`.
5. Use Sublime Text's full name.

Co-authored-by: franzihei <41991517+franzihei@users.noreply.github.com>
Co-authored-by: Nuno Santos <nunofilipesantos@gmail.com>
2022-12-12 10:02:54 +00:00
Kamil Śliwak
a9fe05e8c0
Merge pull request #13793 from ethereum/increase-asancli-codecov-ci-resoure
Increase CI resource_class of t_ubu_asan_cli and t_ubu_codecov tests
2022-12-09 21:15:48 +01:00
Rodrigo Q. Saramago
1f1b5910dc
Change base image of t_ubu_asan_cli and t_ubu_codecov to image with
higher resource_class
2022-12-09 13:38:25 +01:00
Kamil Śliwak
b49dac7a8e
Merge pull request #13784 from minebuu/patch-2
Fixed typo in abi.encodeWithSignature description
2022-12-08 14:01:47 +01:00
Soham Zemse
fa78e0f3d4 feat: allow named parameters in mapping types
Co-authored-by: Hari <webmail.hari@gmail.com>

test: add parser and abi test cases

docs: add example on using named parameters for mappings

- Add changelog

feat: update antlr grammar to allow named parameters in mappings

fix: prevent conflicting mapping parameter names

ref: change order of mapping initializers

test: update expectations and fix build

test: add more tests

fix: use common error & code for conflicting params

fix: issue with accessing nested mapping

test: add conflicting params tests for more nested levels

Update libsolidity/analysis/DeclarationTypeChecker.cpp

Co-authored-by: Nikola Matić <nikola.matic@ethereum.org>

fix: error reported with the same code twice

test: add more tests for 3 level nested mapping

Address review comments
2022-12-08 11:56:58 +01:00
Kamil Śliwak
abbf2cb6d6 using-for-rst: Make it clearer where snippets are just examples 2022-12-07 19:31:44 +01:00
wechman
c2e6452b90 using-for.rst: Clarify which library functions can be used with using for 2022-12-07 19:31:44 +01:00
Kamil Śliwak
71506bd3b3 Consistent terminology for attached/bound functions (file rename) 2022-12-07 19:31:44 +01:00
wechman
64a4f32bc2 Consistent terminology for attached/bound functions 2022-12-07 19:31:41 +01:00
Nikola Matić
1c8745c54a
Merge pull request #12274 from ethereum/reuseKeccak
Re-use knowledge about keccak calls.
2022-12-07 08:59:25 -05:00
chriseth
79c52b3c9e Re-use knowledge about keccak calls.
Re-use knowledge about keccak calls.

Update gas cost.

More tests.

Fix bug.

Update libyul/optimiser/DataFlowAnalyzer.cpp

Remove util prefixes

fix test

More test cases.

Add Changelog entry
2022-12-07 14:16:13 +01:00
Minebuu
41b3f0521b
Fixed typo in abi.encodeWithSignature description
In the description of abi.encodeWithSignature, a right parenthesis is missing in the function argument of abi.encodeWithSelector.
2022-12-07 14:18:04 +09:00
Nikola Matić
591df04211
Merge pull request #13760 from ethereum/addoptimizorclub
Add optimizor club benchmark.
2022-12-02 13:27:42 -05:00
chriseth
0cf7236729 Add optimizor club benchmark. 2022-12-02 18:40:49 +01:00
Kamil Śliwak
867a68d798
Merge pull request #13770 from ethereum/docs-yul-updates
[DOCS] Remove mentions of Yul being experimental from docs
2022-12-02 18:28:06 +01:00
franzihei
a9bd337fac
Update yul.rst 2022-12-02 17:17:33 +01:00
chriseth
5e74e95b67 Update test/benchmarks/run.sh
Co-authored-by: Kamil Śliwak <kamil.sliwak@codepoets.it>
2022-12-02 14:08:41 +01:00
chriseth
a0f8cc922f Add optimizor club benchmark. 2022-12-02 14:08:41 +01:00
Daniel
056c4593e3
Merge pull request #13771 from ethereum/enable-stale-action-draft-pr
Remove exempt of draft PRs in stale action
2022-12-01 19:31:36 +01:00
Rodrigo Q. Saramago
523aad175e
Remove exempt of draft PRs in stale action 2022-12-01 18:23:03 +01:00
Daniel
a9f8a77817
Merge pull request #13709 from ChrisXXXXXXX/patch-2
Separate node for every `if` and `case` body in the Yul CFG
2022-12-01 17:04:41 +01:00
ChrisXXXXXXX
feade14fd6 Update ControlFlowSideEffectsCollector.cpp
There are errors in the function void ControlFlowBuilder::operator()(If const& _if) and function void ControlFlowBuilder::operator()(Switch const& _switch) when calculating CFG.
1. In the function void ControlFlowBuilder::operator()(If const& _if), the if.condion block is not the same block as the if.then block. The original code is calculated as one same block.
2. The switch.expression block are not the same block as all the cases block in cases, the original code is calculated as one same block.
This can cause some potential problems during the optimization phase.
2022-12-01 16:06:02 +01:00
Daniel
851cc09742
Merge pull request #13516 from ethereum/fix-yul-interpreter-memory-access
Fix memory expansion semantics in the yul interpreter.
2022-12-01 15:42:41 +01:00
Kamil Śliwak
c6ee18a507
Merge pull request #13744 from ethereum/review-checklist-update-for-external-prs
Update the review checklist to address common external PR problems
2022-11-30 18:20:41 +01:00
Nikola Matić
68686b5e26
Merge pull request #13768 from ethereum/prb-math-fix
Quick fix of prb-math external tests
2022-11-30 11:17:17 -05:00
Rodrigo Q. Saramago
0fb04432fa
Quick fix of prb-math 2022-11-30 16:24:44 +01:00
Leo
ca204c8b05
Merge pull request #13762 from ethereum/smt_fix_delete
Fix internal error when deleting struct member of function type
2022-11-30 13:52:12 +01:00
Leo Alt
77698f8108 Fix internal error when deleting struct member of function type 2022-11-30 12:47:32 +01:00
Kamil Śliwak
40b24850d2
Merge pull request #13766 from ethereum/fix-spurious-unreachable-warning-in-semvermatcher
Fix spurious unreachable warning in `SemVerMatcher`
2022-11-30 00:41:17 +01:00
Sabnock
dbc1bc1515
Array member clarification (#13763)
* clarify array members

Co-authored-by: Kamil Śliwak <cameel2@gmail.com>
2022-11-30 00:39:57 +01:00
Kamil Śliwak
fdf4ec581f Update the review checklist to address common external PR problems 2022-11-29 23:41:16 +01:00
Kamil Śliwak
d0fb8c2e87 Fix another instance of the spurious unreachable warning, this time in SemVerMatcher 2022-11-29 23:26:22 +01:00
Kamil Śliwak
d2dd84ad4b
Merge pull request #13758 from ethereum/close-stale-issues
Prefer old issues/prs and only issues already labeled as stale
2022-11-29 17:32:08 +01:00
Rodrigo Q. Saramago
35f4456be2
Ensure that stale label is not removed from processed ancient issues 2022-11-29 14:38:33 +01:00
Rodrigo Q. Saramago
e31488ff7c
Prefer old issues/prs and only issues already labeled as stale
Co-authored-by: Kamil Śliwak <kamil.sliwak@codepoets.it>
2022-11-29 14:19:56 +01:00
Leo
7cb76ee515
Merge pull request #13761 from ethereum/smt_fix_user
Fix internal error when using user defined value types in map/struct
2022-11-29 13:52:53 +01:00
Leo Alt
608b424afc Fix internal error when using user defined value types as mapping indices or struct members. 2022-11-29 13:04:01 +01:00
Leo
cc8baf7ea8
Merge pull request #13754 from ethereum/smt_fix_assignment
Fix internal error in assignment chains
2022-11-29 11:58:36 +01:00
Kamil Śliwak
7070a1721f
Merge pull request #13755 from ethereum/smt_fix_nondet
Make isoltest not check SMTChecker counterexamples by default
2022-11-28 22:45:07 +01:00
Leo
d5b8f74fa0
Merge pull request #13757 from ethereum/fix_emscripten_hash
Fix emscripten docker hash
2022-11-28 21:57:35 +01:00
Leo Alt
15b062e466 Fix emscripten docker hash 2022-11-28 21:06:51 +01:00
Leo Alt
be8b05e6bf Make isoltest not check SMTChecker counterexamples by default. 2022-11-28 20:55:15 +01:00
Kamil Śliwak
3f17e0e1ca
Merge pull request #13753 from ethereum/close-stale-rename
Rename close stale action
2022-11-28 19:39:50 +01:00
Kamil Śliwak
1373aef249
Merge pull request #13745 from ethereum/close-stale-issues
Close stale issues
2022-11-28 19:39:44 +01:00