Commit Graph

20488 Commits

Author SHA1 Message Date
chriseth
c55d173a28
Merge pull request #11479 from ethereum/fix-ice-when-assigning-implicitly-convertible-function-array-to-storage
Fix ICE when assigning implicitly convertible function array to storage
2021-06-03 10:52:21 +02:00
chriseth
b00027724a
Merge pull request #11478 from ethereum/fix-ice-when-calling-invalid-external-function-type
Treat invalid external function type as a fatal error
2021-06-03 09:00:38 +02:00
chriseth
93936129f1
Merge pull request #11476 from ethereum/fix-ice-on-library-bound-to-literal
Fix ICE in IR when a library is bound to a literal
2021-06-03 08:58:00 +02:00
Kamil Śliwak
ccf658b0e8 Fix assertion preventing assignment of arrays of implicitly convertible function types 2021-06-03 08:56:02 +02:00
chriseth
3c350a63f1
Merge pull request #11472 from ethereum/make-super-skip-unimplemented-functions
Make `super` skip unimplemented functions
2021-06-03 08:37:04 +02:00
Kamil Śliwak
4a19c7e495 Treat invalid external function type as a fatal error to prevent the type from being used
- `returnParameterTypesWithoutDynamicTypes()` assumes it won't encounter such types.
2021-06-02 21:44:39 +02:00
Kamil Śliwak
d96cc3469a FunctionDefinition.resolveVirtual(): Skip unimplemented functions when lookup happens via super 2021-06-02 16:16:15 +02:00
Kamil Śliwak
67e87147b4 Extra asserts, test renaming, test for super in modifiers 2021-06-02 16:15:51 +02:00
Kamil Śliwak
3c7112ed2b Remove the assertion against functions bound to types for which should not be possible
- The list was wrong - we do support string and int literals
- The assertion was meant to guard against silently skipping over types for which there is no special handling. The current code handles everything in a generic way though and likely will not have to be adjusted for newly added types so the risk of that happening is low.
2021-06-02 13:59:42 +02:00
chriseth
4cbf9ff74c
Merge pull request #10143 from ethereum/issue-10084
ControlFlowAnalyser: Also consider called functions in a flow
2021-06-01 19:34:56 +02:00
Leonardo
21cd76d7d0
Merge pull request #11474 from ethereum/smt_fix_bytes_to_fixed_bytes
[SMTChecker] Fix conversion from bytes to fixed bytes
2021-06-01 19:03:14 +02:00
Leonardo
6cea110952
Merge pull request #11467 from ethereum/smt_fix_external_call_from_constructor
[SMTChecker] Fix ICE on external calls from constructor
2021-06-01 18:48:47 +02:00
Leo Alt
bf21cd400c Fix conversion from bytes to fixed bytes 2021-06-01 17:55:18 +02:00
Mathias Baumann
56ebea8b2f ControlFlowAnalyser: Also consider called functions in a flow 2021-06-01 15:54:37 +02:00
Leonardo
4df51020da
Merge pull request #11465 from ethereum/smt_add_modules_tests
Add SMTChecker tests with modules
2021-06-01 15:41:26 +02:00
Leo Alt
547a6915ad Fix ICE on external calls from constructor 2021-06-01 14:21:48 +02:00
Leo Alt
97a7c5429b Add SMTChecker tests with modules 2021-06-01 13:35:44 +02:00
Leo Alt
8eb28b10cb Add SMTChecker tests with modules 2021-06-01 13:35:10 +02:00
chriseth
7d1df95176
Merge pull request #11441 from ethereum/sourceLocationOfBlocks
Properly set source location of bare blocks.
2021-05-31 20:31:50 +02:00
chriseth
0623658ddd Properly set source location of bare blocks. 2021-05-31 18:28:17 +02:00
Kamil Śliwak
ececf7fec9
Merge pull request #11460 from ethereum/fix_typo
Fix typo.
2021-05-31 17:45:18 +02:00
Alexander Arlt
376836a7fb Fix typo. 2021-05-31 10:07:26 -05:00
Alex Beregszaszi
7eed8b69e9
Merge pull request #11459 from ethereum/yulFixedPointTypesAssertions
[Sol->Yul] Adding assertion in order to give better error messages for fixed point types
2021-05-31 15:32:14 +01:00
Harikrishnan Mulackal
8ecf79474b
Merge pull request #11458 from ethereum/event_indexed_mixed
Add test with event where indexed parameters are not the first.
2021-05-31 16:19:52 +02:00
Djordje Mijovic
17eaa11657 [Sol->Yul] Adding assertion in order to give better error messages for fixed point types. 2021-05-31 15:54:37 +02:00
chriseth
3dfa68a574
Merge pull request #11456 from ethereum/ice-abstract-contract-mapping-constructor
Fix ICE related to mapping types in abstract contract constructor
2021-05-31 15:35:26 +02:00
chriseth
28aad7e0b4 Add test with event where indexed parameters are not the first. 2021-05-31 15:19:56 +02:00
hrkrshnn
138873d918 Fix ICE related to mapping types in abstract contract constructor 2021-05-31 14:56:49 +02:00
chriseth
c09dc6144c
Merge pull request #11050 from ethereum/isoltest-effects-events
[isoltest] Add support for events using call side-effects.
2021-05-31 14:38:14 +02:00
chriseth
6dd5bcd3f0
Merge pull request #11454 from ethereum/data-location-error
Error message: try-catch parameter cannot be in storage.
2021-05-31 14:31:01 +02:00
chriseth
48d2597057
Merge pull request #11457 from ethereum/docs-genindex-url-fix
docs: Fix for broken genindex.html URLs
2021-05-31 14:29:56 +02:00
Christian Parpart
d102c6c0d5 docs: Fixes link to genindex.html when clicked from within a page behind internals/ directory structure. 2021-05-31 14:17:58 +02:00
hrkrshnn
f582d48f7b Error message: try-catch parameter cannot be in storage. 2021-05-31 11:25:08 +02:00
chriseth
29a995b937
Merge pull request #11433 from ethereum/panic-dedup
Insert a call to panic function in legacy codegen (and not inline it every single time)
2021-05-31 11:23:30 +02:00
Alexander Arlt
85e3fcb1bf [isoltest] Extract event specific end-to-end tests. 2021-05-27 23:21:55 -05:00
Alexander Arlt
ec86e3e9ae [isoltest] Add support for events using call side-effects. 2021-05-27 23:21:55 -05:00
Alex Beregszaszi
47167a42a7 Update tests 2021-05-27 18:31:54 +01:00
Alex Beregszaszi
cc8d341e28 Include utility functions in ExpressionCompiler tests 2021-05-27 18:31:54 +01:00
Alex Beregszaszi
c436785686 Insert a call to panic function in legacy codegen (and not inline it every single time) 2021-05-27 18:29:46 +01:00
chriseth
2f0df8f054
Merge pull request #11449 from ethereum/checkNamespaceStyle
Check for style of namespace.
2021-05-27 18:08:09 +02:00
Harikrishnan Mulackal
9cffaddadc
Merge pull request #11448 from ethereum/docs-staticcall-value
[DOCS] Clarification about value option for staticcall.
2021-05-27 17:52:21 +02:00
chriseth
62ec8117d9
Merge pull request #11388 from fulldecent/patch-20
Fix comparison of bit shifts (unchecked overflow) to arithmetic (checked overflow)
2021-05-27 17:42:42 +02:00
chriseth
d305c219d8 Fix namespace styles. 2021-05-27 17:41:04 +02:00
chriseth
033559206c Check for style of namespace. 2021-05-27 17:38:27 +02:00
William Entriken
74d5c51303 Fix comparison of bit shifts (unchecked overflow) to arithmetic (checked overflow)
Co-authored-by: Daniel Kirchner <daniel@ekpyron.org>

Co-authored-by: Harikrishnan Mulackal <webmail.hari@gmail.com>
2021-05-27 17:20:27 +02:00
Leonardo
a87998494a
Merge pull request #11289 from ethereum/smt_fix_chcsmtlib2interface
[SMTChecker] Fix CHCSmtLib2Interface
2021-05-27 11:50:36 +02:00
hrkrshnn
b8d5d5744e Clarification about value option for staticcall. 2021-05-27 11:21:15 +02:00
chriseth
5672646bd7
Merge pull request #11439 from ethereum/docs-indexed-event-parameter-clarification
[docs] Clarification about indexed event parameters
2021-05-27 11:12:29 +02:00
Leo Alt
f7b045b886 review 2021-05-26 22:12:49 +02:00
Leo Alt
d828aeee23 Update test nondet 2021-05-26 22:12:49 +02:00