Merge pull request #11449 from ethereum/checkNamespaceStyle

Check for style of namespace.

liblangutil/Scanner.cpp

@@ -62,7 +62,8 @@
 
 using namespace std;
 
-namespace solidity::langutil {
+namespace solidity::langutil
+{
 
 string to_string(ScannerError _errorCode)
 {

libsolidity/analysis/ControlFlowBuilder.h

@@ -26,7 +26,8 @@
 #include <array>
 #include <memory>
 
-namespace solidity::frontend {
+namespace solidity::frontend
+{
 
 /** Helper class that builds the control flow of a function or modifier.
  * Modifiers are not yet applied to the functions. This is done in a second

libsolidity/codegen/Compiler.h

@@ -31,7 +31,8 @@
 #include <functional>
 #include <ostream>
 
-namespace solidity::frontend {
+namespace solidity::frontend
+{
 
 class Compiler
 {

libsolidity/codegen/CompilerContext.h

@@ -47,7 +47,8 @@
 #include <queue>
 #include <utility>
 
-namespace solidity::frontend {
+namespace solidity::frontend
+{
 
 class Compiler;
 

libsolidity/codegen/CompilerUtils.h

@@ -29,7 +29,8 @@
 #include <libsolidity/codegen/CompilerContext.h>
 #include <libsolidity/codegen/CompilerContext.h>
 
-namespace solidity::frontend {
+namespace solidity::frontend
+{
 
 class Type; // forward
 

libsolidity/codegen/ExpressionCompiler.h

@@ -39,7 +39,8 @@ namespace solidity::evmasm
 class AssemblyItem; // forward
 }
 
-namespace solidity::frontend {
+namespace solidity::frontend
+{
 
 // forward declarations
 class CompilerContext;

libsolutil/JSON.h

@@ -27,7 +27,8 @@
 
 #include <string>
 
-namespace solidity::util {
+namespace solidity::util
+{
 
 /// Removes members with null value recursively from (@a _json).
 Json::Value removeNullMembers(Json::Value _json);

libyul/AsmParser.cpp

@@ -40,7 +40,8 @@ using namespace solidity::util;
 using namespace solidity::langutil;
 using namespace solidity::yul;
 
-namespace {
+namespace
+{
 
 [[nodiscard]]
 shared_ptr<DebugData const> updateLocationEndFrom(

libyul/optimiser/StructuralSimplifier.cpp

@@ -28,7 +28,8 @@ using namespace solidity::yul;
 
 using OptionalStatements = std::optional<vector<Statement>>;
 
-namespace {
+namespace
+{
 
 OptionalStatements replaceConstArgSwitch(Switch& _switchStmt, u256 const& _constExprVal)
 {

scripts/check_style.sh

@@ -47,6 +47,7 @@ FORMATERROR=$(
     preparedGrep "\<(if|for|while|switch)\(" # no space after "if", "for", "while" or "switch"
     preparedGrep "\<for\>\s*\([^=]*\>\s:\s.*\)" # no space before range based for-loop
     preparedGrep "\<if\>\s*\(.*\)\s*\{\s*$" # "{\n" on same line as "if"
+    preparedGrep "namespace .*\{"
     preparedGrep "[,\(<]\s*const " # const on left side of type
     preparedGrep "^\s*(static)?\s*const " # const on left side of type (beginning of line)
     preparedGrep "^ [^*]|[^*] 	|	 [^*]" # uses spaces for indentation or mixes spaces and tabs