Boost libraries on osx use visibility=hidden to reduce unnecessary DWARF entries.
Unless we match visibility, ld will give a warning message like:
ld: warning: direct access in function 'boost::filesystem... from file ...
means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
solidity.sh:
* introduce SOLIDITY_BUILD_DIR env var for soltest.sh,
* add --help output
EthOptions.cmake: more complete configuration information
CODING_STYLE.md: note existence of .editorconfig
contributing.rst: note that tests are Boost C++ unit tests
CMake defaults to C *and* C++ toolchain, in case nothing has been specified.
This means that cmake always checks for both, which is more than needed.
This PR cuts off C toolchain requirement from /CMakeLists.txt and ensures that we
don't pass along any `..._C_...` variables in EthCompilerSettings.cake nor jsoncpp.cmake.
Removed push/pop if there was no change to the warnings *in the same
file* for a given compiler. This assumes the imported boost headers use
a warning stack themselves.
The pragmas don't seem to be required anymore, but were not removed to
mantain compatibility with older versions of the boost library.
Compiled with
- clang version 6.0.1 (tags/RELEASE_601/final)
- gcc (GCC) 8.1.1 20180531
against:
- libboost 1.67.0-5
This also removed PROFILE option that also adds --coverage flag. Instead you can use -DCMAKE_EXE_LINKER_FLAGS=-lprofiler. The profiling options can be added back when better investigated (e.g. -lprofiler vs -pg options).
According to cmake documents, we cannot assume CMAKE_INSTALL_LIBDIR is a
relative path. This commit fixes the "no rule to make libjsoncpp.a"
error by passing -DCMAKE_INSTALL_LIBDIR=lib to jsoncpp external project.
When building on Debian/Ubuntu with install prefix /usr (e.g. in PPA builds) the CMAKE_INSTALL_LIBDIR is resolved to lib/x86_64-linux-gnu. For jsoncpp external project this is never the case because the install prefix is not /usr. Remove multiarch part from libdir if there.
rocky
rocky
Bhargava Shastry
Alex Beregszaszi
Leonardo Alt
Shelly Grossman
Bhargava Shastry
Daniel Kirchner
Christian Parpart
chriseth
Paweł Bylica
Dominik Harz
Matías Aereal Aeón
Leo Arias
Augusto F. Hack
Guido Vranken
Cryptomental
Christian Parpart
mingchuan
Lefteris Karapetsas
Alexander Arlt