cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
21,609 Commits 348 Branches 121 Tags 100 MiB
6fe1ee6a8a
Commit Graph

21609 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Braden Watling
6fe1ee6a8a
Fix typo in control-structures.rst 
I'm learning Solidity by reading these docs and found this statement confusing. I'm fairly certain that the correct description here is that the *callee* changes get reverted, but the caller is able to react to the failures.

I tested this with the following snippet in Remix, which resulted in a successful transaction when deployed:

```
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.7;

contract A {
    uint public value;

    function a(uint newValue, bool shouldRevert) external {
        value = newValue;
        if (shouldRevert) {
            revert();
        }
    }
}

contract B {
    function b() external {
        A a = new A();
        try a.a(50, false) {
            assert(a.value() == 50);
        } catch {
            assert(false);
        }
        a = new A();
        try a.a(50, true) {
            assert(false);
        } catch {
            assert(a.value() == 0);
        }
    }
}
```
 2022-01-03 17:22:23 -05:00
chriseth
c28f85f1e2
Merge pull request #12484 from ethereum/fix-interpreter-mem-overflow-bug 
Impose stricter upper bound on memory accesses in order to prevent wrap around
 2022-01-03 19:16:09 +01:00
Bhargava Shastry
259a98b82c Impose stricter upper bound on memory accesses in order to prevent overflow/wrap around. 2022-01-03 18:22:42 +01:00
chriseth
b8ee17340b
Merge pull request #12481 from ethereum/internalLibraryCallsCode 
Clarify which functions are added.
 2022-01-03 16:44:56 +01:00
chriseth
57474917a0 Clarify which functions are added. 2022-01-03 15:38:39 +01:00
Harikrishnan Mulackal
223395bcad
Merge pull request #12477 from 0xpranay/patch-1 
Added specificity to data location.
 2022-01-03 13:34:49 +05:30
Pranay Reddy
f30130888e Added specificity to data location. 
Added the specificity that bytes1[] and bytes differ because of padding only in memory data location. Added extra sentence that they are similar when used in storage data location.
 2022-01-03 12:47:51 +05:30
chriseth
6849774bd7
Merge pull request #12456 from nishant-sachdeva/generate_warning_if_isoltest_gas_cost_expectations_not_enforced 
added warning if isoltest gas-cost-expectations are not enforced
 2021-12-30 14:59:45 +01:00
nishant-sachdeva
bd819c87fa added warning if isoltest gas-cost-expectations are not enforced 2021-12-30 18:51:55 +05:30
chriseth
692614df72
Merge pull request #12437 from ethereum/encodeCallForDeclarations 
abi.encodeCall for declarations.
 2021-12-29 18:40:18 +01:00
chriseth
563357cfec
Merge pull request #12464 from ethereum/franzihei-patch-1 
[DOCS] update contributing section meeting link
 2021-12-29 18:04:27 +01:00
Franziska Heintel
4456eeb6bb
[DOCS] update contributing section meeting link 2021-12-29 16:06:05 +01:00
Leo
048a8f4d28
Merge pull request #12455 from ethereum/smt_analyze_contracts 
[SMTChecker] Do not analyze unecessary contracts
 2021-12-29 15:14:35 +01:00
chriseth
7c4f4ae46c
Merge pull request #12461 from ethereum/cleanup-modifier-resolve 
[trivial] Remove unnecessary checks in modifier resolve function
 2021-12-29 14:28:52 +01:00
Marenz
b95db2db5e Remove unnecessary checks in modifier resolve function 2021-12-29 13:27:10 +01:00
chriseth
4c838d9cf5 abi.encodeCall for declarations. 2021-12-29 12:26:04 +01:00
Leo Alt
fb8c138b8b Do not analyze unecessary contracts 2021-12-24 19:36:32 +01:00
Kamil Śliwak
b28cd00aa0
Merge pull request #12198 from ethereum/switch-ens-ext-test-to-ens-contracts 
Switch ENS external test to ens-contracts repo
 2021-12-22 16:38:15 +01:00
Kamil Śliwak
7e91dba663 Switch ens external test to ens-contracts repo 2021-12-22 14:45:51 +01:00
chriseth
1582682626
Merge pull request #12444 from ethereum/pylint-disable-too-many-warnings 
[pylint] Disable the opinionated too-many-xyz warnings
 2021-12-21 19:27:37 +01:00
Kamil Śliwak
de364c566c pylint: Disable the opinionated too-many-xyz warnings 2021-12-21 18:37:38 +01:00
chriseth
0769e4df5d
Merge pull request #12445 from ethereum/pylint-enable-more-warnings 
[pylint] Enable more warnings
 2021-12-21 18:20:52 +01:00
chriseth
4149560be1
Merge pull request #12446 from ethereum/fix-eslint-warnings-in-external-test-js 
Fix ESLint warnings/errors in external test JS
 2021-12-21 17:06:06 +01:00
Kamil Śliwak
8cfecb45cc Fix ESLint warnings/errors in external test JS 2021-12-21 16:18:46 +01:00
chriseth
ef6dd2ec50
Merge pull request #12433 from ethereum/removeConstexpr 
Remove constexpr.
 2021-12-21 16:03:58 +01:00
Kamil Śliwak
589f4b2a83 pylint: Enable bad-continuation and ungrouped-imports warnings and update the list of warnings to eliminate in the future 2021-12-21 15:31:01 +01:00
Kamil Śliwak
dece5f4de2 pylint: Enable and fix redefined-builtin warnings 2021-12-21 15:30:11 +01:00
Kamil Śliwak
5b10ff1216 pylint: Enable and fix singleton-comparison warnings 2021-12-21 15:30:11 +01:00
Kamil Śliwak
784ae91b41 pylint: Enable and fix no-self-use warnings 2021-12-21 15:30:11 +01:00
Kamil Śliwak
449f56c15b pylint: Enable and fix consider-using-sys-exit warnings 2021-12-21 15:30:11 +01:00
Kamil Śliwak
b65e093394
Merge pull request #12438 from ethereum/documentnodejsversionchange 
Document nodejs required version change.
 2021-12-20 21:17:46 +01:00
chriseth
a4b2fc9cb7
Merge pull request #12361 from mejsiej/improved-err-msg-when-getter-returns-nothing 
Changed the message of the error thrown when the structure has all it's members omitted
 2021-12-20 21:06:14 +01:00
chriseth
e5d7b81ca6
Merge pull request #12397 from ethereum/enable-ext-test-presets-that-compile-but-fail-tests 
Enable external test presets that compile but fail tests
 2021-12-20 20:05:53 +01:00
chriseth
1cb9766835 Document nodejs required version change. 2021-12-20 19:39:05 +01:00
Kamil Śliwak
1124e28628 externalTests: With COMPILE_ONLY=1 still do compilation on all levels if only JS tests fail 2021-12-20 19:14:37 +01:00
chriseth
113ecbdeb3
Merge pull request #12408 from sbillig/fix-mac-build 
Update circleci mac xcode version to 13.2
 2021-12-20 18:49:22 +01:00
mejsiej
ddd9a84141 Improve failure message when generating getter. 2021-12-20 18:16:27 +01:00
chriseth
8da9239c83
Merge pull request #12396 from ethereum/ext-tests-via-ir 
External tests via IR
 2021-12-20 18:13:02 +01:00
chriseth
c374d27eec Remove constexpr. 2021-12-20 17:30:20 +01:00
chriseth
08abab1373
Merge pull request #12432 from ethereum/nextVersion 
Set version to 0.8.12.
 2021-12-20 17:04:57 +01:00
chriseth
ff181ad129 Set version to 0.8.12. 2021-12-20 16:17:07 +01:00
chriseth
d7f0394316
Merge pull request #12426 from ethereum/setDateFor0811 
Set release date for 0.8.11
 2021-12-20 15:00:55 +01:00
chriseth
25a3bf2df0 Set release date. 2021-12-20 13:15:58 +01:00
chriseth
018f8cd2e2
Merge pull request #12428 from ethereum/fix/arch-ci-build-error 
Fixes CI build error for ArchLinux.
 2021-12-20 13:15:22 +01:00
Christian Parpart
b8e64a4883 Fixes CI build error for ArchLinux. 2021-12-20 13:11:00 +01:00
Alex Beregszaszi
700a09aae4
Merge pull request #12425 from GitHubPang/patch-1 
Fix a few typos
 2021-12-20 10:30:35 +01:00
GitHubPang
1b0cef4624
Fix a few typos 2021-12-20 10:56:39 +08:00
Sean Billig
4819d010a8 Update circleci mac xcode version to 13.2 2021-12-16 20:26:14 -08:00
Kamil Śliwak
10289fbc6a
Merge pull request #12420 from ethereum/security-policy-and-labels-in-template-chooser 
Restore security policy link and labels in issue template chooser
 2021-12-16 18:58:53 +01:00
chriseth
3193dfbb5d
Merge pull request #11350 from ethereum/lsp 
Language Server
 2021-12-16 18:54:26 +01:00