cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
21,646 Commits 348 Branches 121 Tags 100 MiB
3731c0f4ac
Commit Graph

21646 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Harikrishnan Mulackal
3731c0f4ac
Merge pull request #12500 from safwen1/patch-1 
Explaining payable(msg.sender)
 2022-01-10 13:28:56 +05:30
Mohamed Safouen Bouabid
4c20821e6d Explaining payable(msg.sender) 
At this point of the documentation a new Solidity learner will not understand this line without further explanation:
if (!payable(msg.sender).send(amount)) {
It should explain how msg.sender is of type "address" and not "address payable" so it cannot send or receive Ether. Therefore it must be explicitly converted to payable.
 2022-01-10 12:49:30 +05:30
Harikrishnan Mulackal
c3b4292d1d
Merge pull request #12498 from ethereum/add-function-hoister-to-ese 
Add FunctionHoister as a pre-requisite for equal store eliminator.
 2022-01-06 20:10:37 +05:30
Bhargava Shastry
2c7aed1d7e Add FunctionHoister as a pre-requisite for equal store eliminator. 2022-01-06 14:16:02 +01:00
Mathias L. Baumann
63b6bbe15c
Merge pull request #12471 from ethereum/modifiers-control-flow-11483 
Properly generated control flows for inherited modifiers
 2022-01-06 13:39:50 +01:00
Marenz
e969aed780 Properly resolve virtual modifiers 2022-01-06 12:52:06 +01:00
chriseth
e17b06f4fd
Merge pull request #12497 from esquith/develop 
Fix typo
 2022-01-06 10:36:21 +01:00
Esquith Allen
b1ef5de496 fix typo 2022-01-05 21:58:41 -05:00
Christian Parpart
b6a203a9e8
Merge pull request #12493 from ethereum/lspAssert 
LSP: Introduces lspAssert(condition, ErrorCode, message)
 2022-01-05 12:18:32 +01:00
Christian Parpart
1bd0f9570f LSP: Introduces lspAssert(condition, ErrorCode, message) 2022-01-05 11:30:04 +01:00
chriseth
c16867cb83
Merge pull request #12272 from ethereum/equalStoreEliminator 
Equal store eliminator.
 2022-01-05 11:24:59 +01:00
chriseth
679f73c1e0
Merge pull request #12276 from ethereum/fuzz-RSE 
Yul interpreter: Changes required before merging Redundant store eliminator
 2022-01-05 11:23:51 +01:00
chriseth
02ed2f0054
Merge pull request #12482 from ethereum/lsp-handler-error 
LSP: Introduce RequestError exception for easier handling
 2022-01-05 11:18:56 +01:00
Christian Parpart
4105b0a587 LSP: Introduce HandlerError(id, code, message) exception for easier handling. 2022-01-05 11:04:40 +01:00
Harikrishnan Mulackal
75df03c8a8
Merge pull request #12490 from fulldecent/develop 
Typo: SemVer
 2022-01-05 13:32:29 +05:30
William Entriken
c798ac472e Typo: SemVer 2022-01-04 18:59:40 -05:00
chriseth
b892851d7c
Merge pull request #12489 from ethereum/fixPhaserTest 
Use fixed seed for flaky phaser test for now.
 2022-01-04 18:38:44 +01:00
Daniel Kirchner
671064b609 Use fixed seed for flaky phaser test for now. 2022-01-04 18:27:31 +01:00
Daniel Kirchner
cac0f203a2
Merge pull request #12467 from ethereum/fixMappingExample 
Fix mapping example.
 2022-01-04 18:23:57 +01:00
chriseth
e3bb5ab7b2
Merge pull request #12431 from ethereum/fixFun2 
Safer constructors for FunctionType
 2022-01-04 18:18:21 +01:00
Daniel Kirchner
55233285f4
Merge pull request #12480 from ethereum/static_z3_script_impish 
Add impish to static Z3 PPA script.
 2022-01-04 16:45:12 +01:00
chriseth
6dbe0d0933
Merge pull request #12436 from ethereum/testBatcher 
Test batcher.
 2022-01-04 16:21:56 +01:00
Bhargava Shastry
b8ad2b2718 Yul interpreter: Add flag to disable memory tracing and dump for fuzzing. 
Model revert in yul interpreter.
Add logTrace for a few more instructions and clear trace on revert.
 2022-01-04 11:56:27 +01:00
chriseth
13723fe2bf
Merge pull request #12486 from bradenwatling/patch-2 
Update control-structures.rst
 2022-01-04 11:11:10 +01:00
Braden Watling
bb16c1943c Fix gas retaining statement. 
According to https://docs.soliditylang.org/en/v0.8.11/introduction-to-smart-contracts.html?highlight=63%2F64#message-calls, the caller forwards 63/64th of its gas, but here we seem to contradict that by saying the caller retains 63/64th of its gas.
 2022-01-04 11:10:31 +01:00
hrkrshnn
85d1a57e65 Added more tests. Updated chromosome. Remove unused headers. 2022-01-04 13:27:39 +05:30
Harikrishnan Mulackal
96f06d29c2
Merge pull request #12485 from bradenwatling/patch-1 
Fix typo in control-structures.rst
 2022-01-04 11:50:37 +05:30
Braden Watling
6fe1ee6a8a
Fix typo in control-structures.rst 
I'm learning Solidity by reading these docs and found this statement confusing. I'm fairly certain that the correct description here is that the *callee* changes get reverted, but the caller is able to react to the failures.

I tested this with the following snippet in Remix, which resulted in a successful transaction when deployed:

```
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.7;

contract A {
    uint public value;

    function a(uint newValue, bool shouldRevert) external {
        value = newValue;
        if (shouldRevert) {
            revert();
        }
    }
}

contract B {
    function b() external {
        A a = new A();
        try a.a(50, false) {
            assert(a.value() == 50);
        } catch {
            assert(false);
        }
        a = new A();
        try a.a(50, true) {
            assert(false);
        } catch {
            assert(a.value() == 0);
        }
    }
}
```
 2022-01-03 17:22:23 -05:00
chriseth
c28f85f1e2
Merge pull request #12484 from ethereum/fix-interpreter-mem-overflow-bug 
Impose stricter upper bound on memory accesses in order to prevent wrap around
 2022-01-03 19:16:09 +01:00
Bhargava Shastry
259a98b82c Impose stricter upper bound on memory accesses in order to prevent overflow/wrap around. 2022-01-03 18:22:42 +01:00
chriseth
b8ee17340b
Merge pull request #12481 from ethereum/internalLibraryCallsCode 
Clarify which functions are added.
 2022-01-03 16:44:56 +01:00
chriseth
b354c81a63 Documentation 2022-01-03 15:52:05 +01:00
chriseth
e7fc2a176a Test updates. 2022-01-03 15:52:05 +01:00
chriseth
772e100813 Equal store eliminator. 2022-01-03 15:52:05 +01:00
chriseth
57474917a0 Clarify which functions are added. 2022-01-03 15:38:39 +01:00
Daniel Kirchner
e5f912ec89 Add static z3 build and version check to release checklist. 2022-01-03 15:36:27 +01:00
Daniel Kirchner
5597d43635 Add impish to static Z3 PPA script. 2022-01-03 14:03:40 +01:00
Harikrishnan Mulackal
223395bcad
Merge pull request #12477 from 0xpranay/patch-1 
Added specificity to data location.
 2022-01-03 13:34:49 +05:30
Pranay Reddy
f30130888e Added specificity to data location. 
Added the specificity that bytes1[] and bytes differ because of padding only in memory data location. Added extra sentence that they are similar when used in storage data location.
 2022-01-03 12:47:51 +05:30
chriseth
0010027e17 Fix mapping example. 2021-12-30 15:28:09 +01:00
chriseth
2a7f26e2c0 Test batcher. 2021-12-30 15:02:05 +01:00
chriseth
6849774bd7
Merge pull request #12456 from nishant-sachdeva/generate_warning_if_isoltest_gas_cost_expectations_not_enforced 
added warning if isoltest gas-cost-expectations are not enforced
 2021-12-30 14:59:45 +01:00
nishant-sachdeva
bd819c87fa added warning if isoltest gas-cost-expectations are not enforced 2021-12-30 18:51:55 +05:30
chriseth
692614df72
Merge pull request #12437 from ethereum/encodeCallForDeclarations 
abi.encodeCall for declarations.
 2021-12-29 18:40:18 +01:00
chriseth
563357cfec
Merge pull request #12464 from ethereum/franzihei-patch-1 
[DOCS] update contributing section meeting link
 2021-12-29 18:04:27 +01:00
Franziska Heintel
4456eeb6bb
[DOCS] update contributing section meeting link 2021-12-29 16:06:05 +01:00
Leo
048a8f4d28
Merge pull request #12455 from ethereum/smt_analyze_contracts 
[SMTChecker] Do not analyze unecessary contracts
 2021-12-29 15:14:35 +01:00
chriseth
7c4f4ae46c
Merge pull request #12461 from ethereum/cleanup-modifier-resolve 
[trivial] Remove unnecessary checks in modifier resolve function
 2021-12-29 14:28:52 +01:00
Marenz
b95db2db5e Remove unnecessary checks in modifier resolve function 2021-12-29 13:27:10 +01:00
chriseth
4c838d9cf5 abi.encodeCall for declarations. 2021-12-29 12:26:04 +01:00