Commit Graph

376 Commits

Author SHA1 Message Date
Bob Summerwill
29b8965b95 Merge pull request #968 from Denton-L/contributing
Update README to link to new contribution section
2016-08-29 11:19:21 -07:00
Denton Liu
30f1288537 Update README to link to new contribution section 2016-08-29 14:05:46 -04:00
Bob Summerwill
0b89e1e98c Merge pull request #964 from Denton-L/fix-documentation
Fix documentation
2016-08-29 10:36:15 -07:00
Denton Liu
4b74bf799c Create contribution guidelines 2016-08-29 13:28:33 -04:00
Denton Liu
be86a2af9e Fix line length 2016-08-29 11:00:11 -04:00
Denton Liu
dd543d4602 Fix selfdestruct documentation 2016-08-29 10:27:14 -04:00
Denton Liu
eea4b63b44 Fix syntax for Windows batch file 2016-08-29 10:25:10 -04:00
Denton Liu
9ace0ca310 Clarify typecasting 2016-08-26 17:13:45 -04:00
Denton Liu
f125b2813e Clean up contracts.rst 2016-08-26 17:13:45 -04:00
Denton Liu
f55fb808e9 Fix grammar error 2016-08-26 17:02:49 -04:00
Denton Liu
af2e844062 Cleanup docs 2016-08-26 17:02:42 -04:00
Bob Summerwill
d14d7109b6 Merge pull request #946 from bobsummerwill/build_from_source_docs
Updated Solidity documentation's "building from source" section
2016-08-26 13:17:52 -07:00
Bob Summerwill
deb95b617d Tweaks as suggested by chriseth.
I will commit this as-is, because it has been pending for a few days over minor issues.
We will continue to iterate on this.
2016-08-26 13:17:31 -07:00
Denton Liu
cb0b2286c1 Added library keyword 2016-08-26 11:18:28 -04:00
Denton Liu
b0d9da05cf Added ufixed and fixed keywords 2016-08-26 11:18:28 -04:00
chriseth
83160d56f3 Merge pull request #953 from Denton-L/fallback-stuff
Write about what fallback functions cannot do
2016-08-26 17:01:38 +02:00
Denton Liu
8c3b1334ae Add "Sending Ether" 2016-08-26 10:31:57 -04:00
chriseth
21b6aa92ff Disallow fallback function to return values. 2016-08-26 00:07:50 +02:00
Denton Liu
f5989fb5e0 Correct spacing 2016-08-25 15:44:16 -04:00
Denton Liu
c276086f3f Write about what fallback functions cannot do 2016-08-25 15:43:04 -04:00
chriseth
f329d5e772 Merge pull request #925 from mocamircea/patch-10
Update contracts.rst
2016-08-25 18:06:30 +02:00
Mircea Moca
55be44dd5f Update contracts.rst
I left the example with contract C only, showing the access specifiers discussed at 186-188. The specifier of data is left public since nothing is related to accessor functions now.

Added a separate example with contracts C, D and E to show specifier's effect. 

Added a separate example to prove the synthesizing of accessor functions.

Added a new example to show the internal/external call of the accessor, according to existent discussion.
2016-08-25 11:43:17 +03:00
chriseth
c2665dc2fe Merge pull request #913 from chriseth/auction
Updated the function withdraw() in the SimpleAuction and BlindAuction…
2016-08-24 23:17:04 +02:00
Bob Summerwill
d49cfebbf7 Updated Solidity documentation's "building from source" section.
It now references install_deps.sh/.bat, and also adds instructions for Windows.
Cherry picked some further tweaks from Denton-L.  Thanks :-)
2016-08-24 14:06:36 -07:00
Denton Liu
ef117c2902 Fix creating contracts section 2016-08-24 11:43:56 -04:00
Denton Liu
2716d01f2c Rename "call data" to "calldata" 2016-08-24 11:43:56 -04:00
Denton Liu
89004edb2f Add comma 2016-08-24 11:43:56 -04:00
Denton Liu
41ad2110c2 Fix control-structures 2016-08-24 11:43:56 -04:00
Denton Liu
1655f3b7bf Update contracts.rst 2016-08-24 11:43:55 -04:00
Denton Liu
4bd96d9382 Fix description about how blocks work 2016-08-24 11:43:55 -04:00
Denton Liu
c65735fc19 Change XXX bit to XXX-bit 2016-08-24 11:43:55 -04:00
Denton Liu
72f2799556 Fix typo 2016-08-24 11:43:55 -04:00
Denton Liu
c58e460ba2 Change example code formatting 2016-08-24 11:43:55 -04:00
Denton Liu
02a72871d2 Change capitalisation 2016-08-24 11:43:55 -04:00
Denton Liu
ac799aff0e Remove trailing whitespaces 2016-08-24 11:43:55 -04:00
Dave Hoover
1bb53ad3e7 Small documentation update 2016-08-23 22:53:30 -05:00
chriseth
0d736fde6d Merge pull request #706 from Denton-L/withdrawal-pattern
Add Withdrawal Pattern Example
2016-08-20 02:57:07 +02:00
Mircea Moca
01dc055d42 Update contracts.rst
I think it's more clear now and without the risk of mentioning the yet discussed accessor concept
2016-08-19 17:47:57 +03:00
Denton Liu
e27493aa83 Remove throw from withdrawal pattern 2016-08-18 12:56:39 -04:00
Denton Liu
bbe7c493ad Document throwing on contract-creation fail 2016-08-18 12:47:41 -04:00
Alex Darby
41eaf3a0cc Updated the function withdraw() in the SimpleAuction and BlindAuction contracts to not use a 'throw' if a address send() fails. 2016-08-18 18:00:30 +02:00
Mircea Moca
ee51894e73 Update contracts.rst
Extended example according to the discussed stuff, clarification & typos
2016-08-18 14:16:01 +03:00
Denton Liu
c2cfc819a2 Document throwing on calling empty code 2016-08-17 14:13:53 -04:00
Denton Liu
1826579f80 Add documentation about throwing 2016-08-17 12:09:20 -04:00
chriseth
b2507e9f10 Merge pull request #839 from chriseth/checkcode
BREAKING: Make function calls throw if target does not have code.
2016-08-17 16:44:15 +02:00
chriseth
d6579a0a5f Merge pull request #888 from chriseth/throwOnDivZero
Throw on division by zero.
2016-08-17 16:43:13 +02:00
chriseth
774bb8ab3b Make function calls throw if target does not have code.
Low-level calls still just execute and will actually report "success".
This allows `x.call.value(y)()` for x being a non-contract account.
2016-08-17 11:30:40 +02:00
chriseth
9c83109549 BREAKING: return only exits current function/modifier 2016-08-17 11:29:31 +02:00
chriseth
e7084d9e16 Throw on division by zero. 2016-08-17 11:27:15 +02:00
chriseth
e4578982c6 Merge pull request #905 from ethereum/chriseth-patch-1
Docs: wording: recursive call exploit -> reentrancy exploit
2016-08-17 11:14:47 +02:00