cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #6906 from ethereum/delegatecall_value_msg

Browse Source 
Improve error message for delegatecall.value
This commit is contained in:
Leonardo 2019-06-12 21:14:54 +02:00 committed by GitHub
commit d2019f49ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libsolidity/analysis/TypeChecker.cpp
View File

@ -2065,6 +2065,11 @@ bool TypeChecker::visit(MemberAccess const& _memberAccess)
{
if (funType->kind() == FunctionType::Kind::Creation)
errorMsg = "Constructor for " + t.front()->toString() + " must be payable for member \"value\" to be available.";
else if (
funType->kind() == FunctionType::Kind::DelegateCall ||
funType->kind() == FunctionType::Kind::BareDelegateCall
)
errorMsg = "Member \"value\" is not allowed in delegated calls due to \"msg.value\" persisting.";
else
errorMsg = "Member \"value\" is only available for payable functions.";
}

2
test/libsolidity/syntaxTests/nameAndTypeResolution/297_library_functions_do_not_have_value.sol
View File

@ -5,4 +5,4 @@ contract test {
}
}
// ----
// TypeError: (87-96): Member "value" is only available for payable functions.
// TypeError: (87-96): Member "value" is not allowed in delegated calls due to "msg.value" persisting.