cerc-io/solidity
15
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #11291 from ethereum/natspec

Browse Source 
Remove dead code in NatSpec
This commit is contained in:
chriseth 2021-04-22 14:39:38 +02:00 committed by GitHub
commit 9e6d26ffca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libsolidity/parsing/DocStringParser.cpp
View File

@ -164,7 +164,7 @@ DocStringParser::iter DocStringParser::parseDocTagParam(iter _pos, iter _end)
DocStringParser::iter DocStringParser::parseDocTag(iter _pos, iter _end, string const& _tag) DocStringParser::iter DocStringParser::parseDocTag(iter _pos, iter _end, string const& _tag)
{ {
// LTODO: need to check for @(start of a tag) between here and the end of line // TODO: need to check for @(start of a tag) between here and the end of line
// for all cases. // for all cases.
if (!m_lastTag || _tag != "") if (!m_lastTag || _tag != "")
{ {

7
libsolidity/parsing/DocStringParser.h
View File

@ -35,7 +35,7 @@ class ErrorReporter;
namespace solidity::frontend namespace solidity::frontend
{ {
class StructurallyDocumented; class StructuredDocumentation;
class DocStringParser class DocStringParser
{ {
@ -49,13 +49,10 @@ public:
private: private:
using iter = std::string::const_iterator; using iter = std::string::const_iterator;
void resetUser();
void resetDev();
iter parseDocTagLine(iter _pos, iter _end, bool _appending); iter parseDocTagLine(iter _pos, iter _end, bool _appending);
iter parseDocTagParam(iter _pos, iter _end); iter parseDocTagParam(iter _pos, iter _end);
iter appendDocTagParam(iter _pos, iter _end);
void parseDocString(std::string const& _string);
/// Parses the doc tag named @a _tag, adds it to m_docTags and returns the position /// Parses the doc tag named @a _tag, adds it to m_docTags and returns the position
/// after the tag. /// after the tag.
iter parseDocTag(iter _pos, iter _end, std::string const& _tag); iter parseDocTag(iter _pos, iter _end, std::string const& _tag);

2
libsolidity/parsing/Parser.cpp
View File

@ -1419,7 +1419,7 @@ ASTPointer<ForStatement> Parser::parseForStatement(ASTPointer<ASTString> const&
expectToken(Token::For); expectToken(Token::For);
expectToken(Token::LParen); expectToken(Token::LParen);
// LTODO: Maybe here have some predicate like peekExpression() instead of checking for semicolon and RParen? // TODO: Maybe here have some predicate like peekExpression() instead of checking for semicolon and RParen?
if (m_scanner->currentToken() != Token::Semicolon) if (m_scanner->currentToken() != Token::Semicolon)
initExpression = parseSimpleStatement(ASTPointer<ASTString>()); initExpression = parseSimpleStatement(ASTPointer<ASTString>());
expectToken(Token::Semicolon); expectToken(Token::Semicolon);