From 4855fca802a1bad44afbb18e0f89624e2f31089e Mon Sep 17 00:00:00 2001 From: Alex Beregszaszi Date: Fri, 1 May 2020 23:37:25 +0100 Subject: [PATCH] Remove dead code in NatSpec --- libsolidity/parsing/DocStringParser.cpp | 2 +- libsolidity/parsing/DocStringParser.h | 7 ++----- libsolidity/parsing/Parser.cpp | 2 +- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/libsolidity/parsing/DocStringParser.cpp b/libsolidity/parsing/DocStringParser.cpp index 73da98b71..d5a849751 100644 --- a/libsolidity/parsing/DocStringParser.cpp +++ b/libsolidity/parsing/DocStringParser.cpp @@ -164,7 +164,7 @@ DocStringParser::iter DocStringParser::parseDocTagParam(iter _pos, iter _end) DocStringParser::iter DocStringParser::parseDocTag(iter _pos, iter _end, string const& _tag) { - // LTODO: need to check for @(start of a tag) between here and the end of line + // TODO: need to check for @(start of a tag) between here and the end of line // for all cases. if (!m_lastTag || _tag != "") { diff --git a/libsolidity/parsing/DocStringParser.h b/libsolidity/parsing/DocStringParser.h index 981ff12a4..22625a160 100644 --- a/libsolidity/parsing/DocStringParser.h +++ b/libsolidity/parsing/DocStringParser.h @@ -35,7 +35,7 @@ class ErrorReporter; namespace solidity::frontend { -class StructurallyDocumented; +class StructuredDocumentation; class DocStringParser { @@ -49,13 +49,10 @@ public: private: using iter = std::string::const_iterator; - void resetUser(); - void resetDev(); iter parseDocTagLine(iter _pos, iter _end, bool _appending); iter parseDocTagParam(iter _pos, iter _end); - iter appendDocTagParam(iter _pos, iter _end); - void parseDocString(std::string const& _string); + /// Parses the doc tag named @a _tag, adds it to m_docTags and returns the position /// after the tag. iter parseDocTag(iter _pos, iter _end, std::string const& _tag); diff --git a/libsolidity/parsing/Parser.cpp b/libsolidity/parsing/Parser.cpp index 016ff75f8..cad62e173 100644 --- a/libsolidity/parsing/Parser.cpp +++ b/libsolidity/parsing/Parser.cpp @@ -1419,7 +1419,7 @@ ASTPointer Parser::parseForStatement(ASTPointer const& expectToken(Token::For); expectToken(Token::LParen); - // LTODO: Maybe here have some predicate like peekExpression() instead of checking for semicolon and RParen? + // TODO: Maybe here have some predicate like peekExpression() instead of checking for semicolon and RParen? if (m_scanner->currentToken() != Token::Semicolon) initExpression = parseSimpleStatement(ASTPointer()); expectToken(Token::Semicolon);