cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Apply suggestions

Browse Source
This commit is contained in:
r0qs
2023-10-02 14:35:38 +02:00
parent 1ec239c63f
commit 84d3af4a29
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libyul/Object.cpp
+6 -8
View File
@@ -149,7 +149,7 @@ std::set<YulString> Object::qualifiedDataNames() const
return qualifiedNames;
}
void Object::visitPath(YulString _qualifiedName, std::function<bool(Object const*)> _visitor) const
void Object::visitPath(YulString _qualifiedName, std::function<bool(Object const*)> const& _visitor) const
{
yulAssert(!_qualifiedName.empty(), "");
@@ -184,7 +184,7 @@ std::vector<size_t> Object::pathToSubObject(YulString _qualifiedName) const
this->visitPath(_qualifiedName, [&](Object const* _object) -> bool {
yulAssert(_object->subId != std::numeric_limits<size_t>::max(), "");
path.push_back({_object->subId});
path.push_back(_object->subId);
return false;
});
return path;
@@ -205,12 +205,10 @@ Object const* Object::subObjectAt(std::string const& _qualifiedName)
Object const* foundObject = nullptr;
this->visitPath(YulString(_qualifiedName), [&](Object const* _subObject) -> bool {
if (targetObjectName == _subObject->name.str())
{
foundObject = _subObject;
return true;
}
return false;
if (targetObjectName != _subObject->name.str())
return false;
foundObject = _subObject;
return true;
});
return foundObject;
libyul/Object.h
+1 -1
View File
@@ -127,7 +127,7 @@ public:
/// it continues until the last subobject in the path is reached.
void visitPath(
YulString _qualifiedName,
std::function<bool(Object const*)> _visitor
std::function<bool(Object const*)> const& _visitor
) const;
Object const* at(YulString _name) const;