cerc-io/sodium-javascript
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove extra argument passed to sodium_memcmp

Browse Source 
Problem: This was ported from libsodium, where sodium_memcmp takes the
length of the buffers. We don't need the length, so we don't need to
pass it.

Solution: Remove the extra argument.
This commit is contained in:
Christian Bundy 2020-09-04 09:14:43 -07:00 committed by Christophe Diederichs
parent 94f270857d
commit c0889e45e7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
crypto_auth.js
View File

@ -26,7 +26,7 @@ function crypto_auth_hmacsha256 (out, input, k) {
function crypto_auth_hmacsha256_verify (h, input, k) {
const correct = Sha256.HMAC(k).update(input).digest()
return crypto_verify_32(h, 0, correct, 0) && sodium_memcmp(correct, h, 32)
return crypto_verify_32(h, 0, correct, 0) && sodium_memcmp(correct, h)
}
function crypto_auth_hmacsha512 (out, input, k) {
@ -40,7 +40,7 @@ function crypto_auth_hmacsha512 (out, input, k) {
function crypto_auth_hmacsha512_verify (h, input, k) {
const correct = Sha512.HMAC(k).update(input).digest()
return crypto_verify_64(h, 0, correct, 0) && sodium_memcmp(correct, h, 64)
return crypto_verify_64(h, 0, correct, 0) && sodium_memcmp(correct, h)
}
function crypto_auth_hmacsha512256 (out, input, k) {
@ -57,7 +57,7 @@ function crypto_auth_hmacsha512256 (out, input, k) {
function crypto_auth_hmacsha512256_verify (h, input, k) {
const correct = Sha512.HMAC(k).update(input).digest()
return crypto_verify_32(h, 0, correct, 0) && sodium_memcmp(correct.subarray(0, 32), h, 32)
return crypto_verify_32(h, 0, correct, 0) && sodium_memcmp(correct.subarray(0, 32), h)
}
function crypto_auth (out, input, k) {