From c0889e45e7b53024989bd7db56be2f387a6f0143 Mon Sep 17 00:00:00 2001 From: Christian Bundy Date: Fri, 4 Sep 2020 09:14:43 -0700 Subject: [PATCH] Remove extra argument passed to sodium_memcmp Problem: This was ported from libsodium, where sodium_memcmp takes the length of the buffers. We don't need the length, so we don't need to pass it. Solution: Remove the extra argument. --- crypto_auth.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto_auth.js b/crypto_auth.js index fb3d3e6..79220e0 100644 --- a/crypto_auth.js +++ b/crypto_auth.js @@ -26,7 +26,7 @@ function crypto_auth_hmacsha256 (out, input, k) { function crypto_auth_hmacsha256_verify (h, input, k) { const correct = Sha256.HMAC(k).update(input).digest() - return crypto_verify_32(h, 0, correct, 0) && sodium_memcmp(correct, h, 32) + return crypto_verify_32(h, 0, correct, 0) && sodium_memcmp(correct, h) } function crypto_auth_hmacsha512 (out, input, k) { @@ -40,7 +40,7 @@ function crypto_auth_hmacsha512 (out, input, k) { function crypto_auth_hmacsha512_verify (h, input, k) { const correct = Sha512.HMAC(k).update(input).digest() - return crypto_verify_64(h, 0, correct, 0) && sodium_memcmp(correct, h, 64) + return crypto_verify_64(h, 0, correct, 0) && sodium_memcmp(correct, h) } function crypto_auth_hmacsha512256 (out, input, k) { @@ -57,7 +57,7 @@ function crypto_auth_hmacsha512256 (out, input, k) { function crypto_auth_hmacsha512256_verify (h, input, k) { const correct = Sha512.HMAC(k).update(input).digest() - return crypto_verify_32(h, 0, correct, 0) && sodium_memcmp(correct.subarray(0, 32), h, 32) + return crypto_verify_32(h, 0, correct, 0) && sodium_memcmp(correct.subarray(0, 32), h) } function crypto_auth (out, input, k) {