cerc-io/snowballtools-base
11
0
Fork 3
Code Issues 11 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

[WIP] Add support for multiple custom domains in single deployment #51

Draft
nabarun wants to merge 5 commits from iv-multi-custom-domains into custom-domain-for-auctions
pull from: iv-multi-custom-domains
merge into: :custom-domain-for-auctions
Conversation 0 Commits 5 Files Changed 5
+233 -107
nabarun commented 2025-02-10 03:38:43 +00:00
Collaborator
Copy Link
Copy Source

Part of https://www.notion.so/Support-custom-domains-in-deploy-laconic-com-18aa6b22d4728067a44ae27090c02ce5

  • Send all custom domains as comma separated strings in deployment request
  • Send removal request for canonical deployments if all the custom domains have changes
  • Store deployer version and only support multiple custom domains if version is present
Part of https://www.notion.so/Support-custom-domains-in-deploy-laconic-com-18aa6b22d4728067a44ae27090c02ce5 - Send all custom domains as comma separated strings in deployment request - Send removal request for canonical deployments if all the custom domains have changes - Store deployer version and only support multiple custom domains if version is present
nabarun added 5 commits 2025-02-10 03:38:43 +00:00
Send multiple domains in deployment request d75be96d70
Send canonical deployments removal request only if all custom domains change baaf0a2dd8
Add check for deployer version to support multiple custom domains 5c9437bf1a
Update rollback flow to handle multiple custom domains 4476de6faf
Remove check for deployer version number
Lint / lint (20.x) (pull_request) Successful in 1m46s
Details
b5d84470ff
All checks were successful
Lint / lint (20.x) (pull_request) Successful in 1m46s
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin iv-multi-custom-domains:iv-multi-custom-domains
git checkout iv-multi-custom-domains
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex cerccicd cfbender ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/snowballtools-base#51