cerc-io/snowballtools-base
11
0
Fork 3
Code Issues 11 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

[WIP] Add support for multiple custom domains in single deployment #51

Draft
nabarun wants to merge 5 commits from iv-multi-custom-domains into custom-domain-for-auctions
pull from: iv-multi-custom-domains
merge into: cerc-io:custom-domain-for-auctions
Conversation 0 Commits 5 Files Changed 5 +233 -107
nabarun commented 2025-02-10 03:38:43 +00:00
Member
Copy Link

Part of https://www.notion.so/Support-custom-domains-in-deploy-laconic-com-18aa6b22d4728067a44ae27090c02ce5

  • Send all custom domains as comma separated strings in deployment request
  • Send removal request for canonical deployments if all the custom domains have changes
  • Store deployer version and only support multiple custom domains if version is present
Part of https://www.notion.so/Support-custom-domains-in-deploy-laconic-com-18aa6b22d4728067a44ae27090c02ce5 - Send all custom domains as comma separated strings in deployment request - Send removal request for canonical deployments if all the custom domains have changes - Store deployer version and only support multiple custom domains if version is present
nabarun added 5 commits 2025-02-10 03:38:43 +00:00
Remove check for deployer version number
All checks were successful
Lint / lint (20.x) (pull_request) Successful in 1m46s
Details
b5d84470ff
All checks were successful
Lint / lint (20.x) (pull_request) Successful in 1m46s
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin iv-multi-custom-domains:iv-multi-custom-domains
git checkout iv-multi-custom-domains
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/snowballtools-base#51
No description provided.
Delete Branch "iv-multi-custom-domains"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?