Add --pluginsdir flag. #1

Merged
telackey merged 1 commits from telackey/pluginsdir into statediff-wip 2023-06-29 04:44:56 +00:00
Member

Add a new flag, --pluginsdir, for setting the directory where plugins are stored. The default remains $datadir/plugins.

Add a new flag, `--pluginsdir`, for setting the directory where plugins are stored. The default remains `$datadir/plugins`.
telackey added 1 commit 2023-06-29 03:52:40 +00:00
roysc approved these changes 2023-06-29 04:41:13 +00:00
roysc left a comment
Owner

Looks good but would be a bit cleaner to use the same pattern as DataDirFlag to set the default

Looks good but would be a bit cleaner to use the same pattern as `DataDirFlag` to set the default
telackey merged commit 80e02c90e3 into statediff-wip 2023-06-29 04:44:56 +00:00
Author
Member

Looks good but would be a bit cleaner to use the same pattern as DataDirFlag to set the default

I started to do this, and stopped for two reasons. One was to limit the changes (as much as possible) within the //begin and //end tags. I suspect those might be some sort of automated merging indicator for the PluGeth people.

The other was that the setDataDir() method has to do with the NodeConfig, but the plugin initialization happens before that rest of the NodeConfig is setup.

> Looks good but would be a bit cleaner to use the same pattern as `DataDirFlag` to set the default I started to do this, and stopped for two reasons. One was to limit the changes (as much as possible) within the `//begin` and `//end` tags. I suspect those might be some sort of automated merging indicator for the PluGeth people. The other was that the setDataDir() method has to do with the NodeConfig, but the plugin initialization happens before that rest of the NodeConfig is setup.
roysc deleted branch telackey/pluginsdir 2023-06-29 05:10:29 +00:00
roysc referenced this issue from a commit 2023-07-19 05:55:49 +00:00
roysc referenced this issue from a commit 2023-08-04 13:54:48 +00:00
roysc referenced this issue from a commit 2023-08-04 15:04:05 +00:00
roysc referenced this issue from a commit 2024-03-28 09:15:58 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/plugeth#1
No description provided.