Add --pluginsdir flag. #1
No reviewers
Labels
No Label
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cerc-io/plugeth#1
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "telackey/pluginsdir"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Add a new flag,
--pluginsdir
, for setting the directory where plugins are stored. The default remains$datadir/plugins
.Looks good but would be a bit cleaner to use the same pattern as
DataDirFlag
to set the defaultI started to do this, and stopped for two reasons. One was to limit the changes (as much as possible) within the
//begin
and//end
tags. I suspect those might be some sort of automated merging indicator for the PluGeth people.The other was that the setDataDir() method has to do with the NodeConfig, but the plugin initialization happens before that rest of the NodeConfig is setup.