cerc-io/plugeth
17
0
Fork 1
Code Issues 4 Pull Requests Packages Projects Releases Wiki Activity

Add --pluginsdir flag. #1

Merged
telackey merged 1 commits from telackey/pluginsdir into statediff-wip 2023-06-29 04:44:56 +00:00
Conversation 1 Commits 1 Files Changed 3 +20 -2
telackey commented 2023-06-29 03:52:39 +00:00
Member
Copy Link

Add a new flag, --pluginsdir, for setting the directory where plugins are stored. The default remains $datadir/plugins.

Add a new flag, `--pluginsdir`, for setting the directory where plugins are stored. The default remains `$datadir/plugins`.
telackey added 1 commit 2023-06-29 03:52:40 +00:00
roysc approved these changes 2023-06-29 04:41:13 +00:00
roysc left a comment
Owner
Copy Link

Looks good but would be a bit cleaner to use the same pattern as DataDirFlag to set the default

Looks good but would be a bit cleaner to use the same pattern as `DataDirFlag` to set the default
telackey merged commit 80e02c90e3 into statediff-wip 2023-06-29 04:44:56 +00:00
telackey commented 2023-06-29 05:05:04 +00:00
Author
Member
Copy Link

Looks good but would be a bit cleaner to use the same pattern as DataDirFlag to set the default

I started to do this, and stopped for two reasons. One was to limit the changes (as much as possible) within the //begin and //end tags. I suspect those might be some sort of automated merging indicator for the PluGeth people.

The other was that the setDataDir() method has to do with the NodeConfig, but the plugin initialization happens before that rest of the NodeConfig is setup.

> Looks good but would be a bit cleaner to use the same pattern as `DataDirFlag` to set the default I started to do this, and stopped for two reasons. One was to limit the changes (as much as possible) within the `//begin` and `//end` tags. I suspect those might be some sort of automated merging indicator for the PluGeth people. The other was that the setDataDir() method has to do with the NodeConfig, but the plugin initialization happens before that rest of the NodeConfig is setup.
roysc deleted branch telackey/pluginsdir 2023-06-29 05:10:29 +00:00
roysc referenced this issue from a commit 2023-07-19 05:55:49 +00:00
Add --pluginsdir flag. (#1)
roysc referenced this issue from a commit 2023-08-04 13:54:48 +00:00
Add --pluginsdir flag. (#1)
roysc referenced this issue from a commit 2023-08-04 15:04:05 +00:00
Add --pluginsdir flag. (#1)
roysc referenced this issue from a commit 2024-03-28 09:15:58 +00:00
Add --pluginsdir flag. (#1)
Sign in to join this conversation.
Reviewers
No reviewers
roysc
Labels
Clear labels
  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/plugeth#1
No description provided.
Delete Branch "telackey/pluginsdir"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?