Felix Lange
dcae0d348b
p2p/simulations: fix a deadlock and clean up adapters ( #17891 )
...
This fixes a rare deadlock with the inproc adapter:
- A node is stopped, which acquires Network.lock.
- The protocol code being simulated (swarm/network in my case)
waits for its goroutines to shut down.
- One of those goroutines calls into the simulation to add a peer,
which waits for Network.lock.
The fix for the deadlock is really simple, just release the lock
before stopping the simulation node.
Other changes in this PR clean up the exec adapter so it reports
node startup errors better and remove the docker adapter because
it just adds overhead.
In the exec adapter, node information is now posted to a one-shot
server. This avoids log parsing and allows reporting startup
errors to the simulation host.
A small change in package node was needed because simulation
nodes use port zero. Node.{HTTP,WS}Endpoint now return the live
endpoints after startup by checking the TCP listener.
2018-10-11 20:32:14 +02:00
Péter Szilágyi
f951e23fb5
Merge pull request #17887 from karalabe/warn-failed-account-access
...
internal/ethapi: warn on failed account accesses
2018-10-10 13:22:43 +03:00
Péter Szilágyi
aff421e78c
internal/ethapi: warn on failed account accesses
2018-10-10 12:29:05 +03:00
Felix Lange
4e474c74dc
rpc: fix subscription corner case and speed up tests ( #17874 )
...
Notifier tracks whether subscription are 'active'. A subscription
becomes active when the subscription ID has been sent to the client. If
the client sends notifications in the request handler before the
subscription becomes active they are dropped. The tests tried to work
around this problem by always waiting 5s before sending the first
notification.
Fix it by buffering notifications until the subscription becomes active.
This speeds up all subscription tests.
Also fix TestSubscriptionMultipleNamespaces to wait for three messages
per subscription instead of six. The test now finishes just after all
notifications have been received and doesn't hit the 30s timeout anymore.
2018-10-09 16:34:24 +02:00
Elad
da290e9707
cmd/swarm: speed up tests ( #17878 )
...
These minor changes already shaved off around 30s.
2018-10-09 14:08:40 +02:00
Anton Evangelatov
0fe9a372b3
swarm, swarm/storage: lower constants for faster tests ( #17876 )
...
* swarm/storage: lower constants for faster tests
* swarm: reduce test size for TestLocalStoreAndRetrieve
* swarm: reduce nodes for dec_inc_node_count
2018-10-09 11:45:42 +02:00
Martin Holst Swende
d5c7a6056a
cmd/clef: encrypt the master seed on disk ( #17704 )
...
* cmd/clef: encrypt master seed of clef
Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
* keystore: refactor for external use of encryption
* clef: utilize keystore encryption, check flags correctly
* clef: validate master password
* clef: add json wrapping around encrypted master seed
2018-10-09 11:05:41 +02:00
Péter Szilágyi
ff5538ad4c
params, swarm: begin Geth v1.8.18, Swarm v0.3.6 cycle
2018-10-09 10:37:49 +03:00
Péter Szilágyi
8bbe72075e
params, swarm: release Geth v1.8.17 and Swar v0.3.5
2018-10-09 10:35:31 +03:00
Guillaume Ballet
97b2806686
core/asm: Use hexadecimal addresses in assembly dumps ( #17870 )
2018-10-09 10:27:07 +03:00
holisticode
11d0ff6578
Fix retrieval tests and simulation backends ( #17723 )
...
* swarm/network/stream: introduced visualized snapshot sync test
* swarm/network/stream: non-existing hash visualization sim
* swarm/network/stream: fixed retrieval tests; new backend for visualization
* swarm/network/stream: cleanup of visualized_snapshot_sync_sim_test.go
* swarm/network/stream: rebased PR on master
* swarm/network/stream: fixed loop logic in retrieval tests
* swarm/network/stream: fixed iterations for snapshot tests
* swarm/network/stream: address PR comments
* swarm/network/stream: addressed PR comments
2018-10-08 20:28:44 +02:00
Felix Lange
72a076840b
travis, build: speed up CI runs ( #17854 )
...
* travis: exclude non-test jobs for PRs
We don't usually look at these builders and not starting them
removes ~15min of build time.
* build: don't run vet before tests
Recent versions of Go run vet during 'go test' and we have
a dedicated lint job.
* build: use -timeout 5m for tests
Tests sometimes hang on Travis. CI runs are aborted after 10min with no
output. Adding the timeout means we get to see the stack trace for
timeouts.
2018-10-08 16:37:06 +02:00
Felix Lange
459278cd57
miner: remove intermediate conversion to int in tests ( #17853 )
...
This fixes the tests on 32bit platforms.
2018-10-08 16:30:00 +02:00
Ryan Schneider
cfcc47529d
cmd/utils: fix bug when checking for flag value conflicts ( #17803 )
2018-10-08 17:08:56 +03:00
gary rong
c5d34fc94e
les, light: reduce les testing stress ( #17867 )
2018-10-08 16:52:23 +03:00
Péter Szilágyi
53634f1e04
trie: remove unused originalRoot field ( #17862 )
2018-10-08 13:16:16 +02:00
Wenbiao Zheng
31c4e3a118
core/types: Log.Index is the index in block, not receipt ( #17866 )
2018-10-08 13:15:19 +02:00
Péter Szilágyi
1d3d4a4d57
core/vm: reuse Keccak-256 hashes across opcode executions ( #17863 )
2018-10-08 13:14:29 +02:00
Javier Peletier
c5cb214f68
swarm/storage/feed: Expose MaxUpdateDataLength constant ( #17858 )
2018-10-08 10:57:38 +02:00
Philip Schlump
f95811e65b
cmd/abigen: support for --type flag with piped data ( #17648 )
2018-10-06 16:27:12 +02:00
Jeremy Schlatter
5ed3960b9b
accounts/abi/bind: stop using goimports in the binding generator ( #17768 )
2018-10-05 22:24:54 +02:00
Martin Holst Swende
5b0c9c8ae5
tests: use non-constantinople ropsten for difficulty tests ( #17850 )
...
This is a stopgap until new tests have been generated and imported.
2018-10-05 21:52:05 +02:00
Martin Holst Swende
58e868b759
core/vm : fix failing testcase ( #17852 )
...
* core/vm : fix failing testcase
* core/vm: fix nitpick
2018-10-05 19:02:06 +02:00
Péter Szilágyi
5d3b7bb023
Merge pull request #17839 from karalabe/downloader-invalid-hash-chain-fix
...
eth/downloader: fix invalid hash chain error due to head mini reorg
2018-10-05 11:03:38 +03:00
Péter Szilágyi
6ee3b26f44
eth/downloader: fix invalid hash chain error due to head mini reorg
2018-10-05 10:45:02 +03:00
Martin Holst Swende
092df3ab59
core/vm: SHA3 word cost for CREATE2 ( #17812 )
...
* core/vm: create2 address generation tests
* core/vm: per byte cost of CREATE2
* core/vm: fix linter issue in test
2018-10-05 10:32:35 +03:00
Martin Holst Swende
81375a3801
tests: do not exit early on log hash mismatch ( #17844 )
2018-10-05 08:35:31 +02:00
Péter Szilágyi
d79602d2d4
Merge pull request #17843 from karalabe/ropsten-block-and-chts
...
params: add ropsten fork delay, update les checkpoints
2018-10-04 22:10:53 +03:00
Péter Szilágyi
ff7fad18fb
params: add ropsten fork delay, update les checkpoints
2018-10-04 19:14:53 +03:00
Martin Holst Swende
89a32451ae
core/vm: faster create/create2 ( #17806 )
...
* core/vm/runtim: benchmark create/create2
* core/vm: do less hashing in CREATE2
* core/vm: avoid storing jumpdest analysis for initcode
* core/vm: avoid unneccesary lookups, remove unused fields
* core/vm: go formatting tests
* core/vm: save jumpdest analysis locally
* core/vm: use common.Hash instead of nil, fix review comments
* core/vm: removed type destinations
* core/vm: correct check for empty hash
* eth: more elegant api_tracer
* core/vm: address review concerns
2018-10-04 18:15:37 +03:00
Anton Evangelatov
8c63d0d2e4
swarm/storage: extract isValid. correctly remove invalid chunks from store on migration ( #17835 )
2018-10-04 18:13:48 +03:00
Felix Lange
1895059119
p2p: add enode URL to PeerInfo ( #17838 )
2018-10-04 18:13:21 +03:00
Péter Szilágyi
127553253e
Merge pull request #17801 from eosclassicteam/patch-1
...
Enable constantinople on Ropsten testnet
2018-10-04 12:36:15 +03:00
Liang Ma
ff6e0351ab
eth: fixed the minor typo inside the comments ( #17830 )
2018-10-04 12:35:24 +03:00
Felix Lange
b8a0daf0cc
cmd/puppeth: fix node URL in health check ( #17802 )
...
* cmd/puppeth: fix node URL in health check
* cmd/puppeth: set external IP for geth
* cmd/puppeth: fix enode cast issue
2018-10-04 12:34:49 +03:00
cdetrio
bfa0f96822
cmd/evm: fix state dump ( #17832 )
2018-10-04 10:22:41 +02:00
Anton Evangelatov
82a1c771ef
cmd/swarm: disable tests under Windows until they are fixed ( #17827 )
2018-10-04 09:18:03 +02:00
Felföldi Zsolt
9d06b2c5f3
core: use ChainHeadEvent subscription in the chain indexer ( #17826 )
2018-10-03 17:25:25 +03:00
Viktor Trón
e5677114dc
Merge pull request #17796 from epiclabs-io/mru-feeds
...
swarm/storage/feeds: Renamed MRU to Swarm Feeds
2018-10-03 14:59:41 +02:00
Anton Evangelatov
303b99663e
swarm: schemas and migrations ( #17813 )
2018-10-03 14:31:59 +02:00
Péter Szilágyi
14bef9a2db
core: fix unnecessary ancestor lookup after a fast sync ( #17825 )
2018-10-03 13:42:19 +03:00
Samuel Marks
d3a773c284
travis, appveyor: bump to Go 1.11.1 ( #17820 )
2018-10-03 13:41:24 +03:00
Javier Peletier
de01178c18
swarm/storage/feed: Renamed package
2018-10-03 09:15:28 +02:00
Javier Peletier
696bc9b01c
swarm/storage/feeds: renamed vars that can conflict with package name
2018-10-03 09:12:06 +02:00
Javier Peletier
58c0879c2f
swarm/storage/feeds: removed capital Feed throughout
2018-10-03 09:12:06 +02:00
Javier Peletier
68b8088cb9
swarm: Changed owners.
2018-10-03 09:12:06 +02:00
Javier Peletier
b6ccc06cda
swarm/storage/feeds: Final package rename and moved files
2018-10-03 09:12:06 +02:00
Javier Peletier
83705ef6aa
swarm/storage/mru: Renamed rest of MRU references
2018-10-03 09:12:06 +02:00
Javier Peletier
b35622cf3c
swarm/storage/mru: Renamed all comments to Feeds
2018-10-03 09:12:06 +02:00
Javier Peletier
f1e86ad9cf
swarm/storage/mru: Renamed all identifiers to Feeds
2018-10-03 09:12:06 +02:00