Håvard Anda Estensen
4b309c7006
all: replace non-trivial uses of package ioutil with os ( #24886 )
...
Co-authored-by: Martin Holst Swende <martin@swende.se>
2022-05-17 14:27:04 +02:00
Håvard Anda Estensen
e644d45c14
all: use strings.EqualFold for string comparison ( #24890 )
2022-05-17 13:56:52 +02:00
Martin Holst Swende
e0a9752b96
cmd/geth: add db check-state-content to verify integrity of trie nodes ( #24840 )
...
This PR adds db tooling (geth db check-state-content) to verify the integrity of trie nodes. It iterates through the 32-byte key space in the database, which is expected to contain RLP-encoded trie nodes, addressed by hash.
2022-05-17 13:01:46 +02:00
Marius van der Wijden
381c66caf0
eth/catalyst: set the correct LatestValidHash ( #24855 )
...
* eth/catalyst: set the correct LatestValidHash
* eth/catalyst: core: return LVH during reorg, rework invalid teminal block
* eth/catalyst: nitpicks
2022-05-17 12:32:55 +03:00
Sina Mahmoodi
29a6b6bcac
graphql: add raw fields to block and tx ( #24816 )
2022-05-17 11:31:17 +03:00
rjl493456442
39fb82bcfb
eth: fix flaky test, don't attach empty slots/proofs ( #24885 )
...
* eth/protocols/snap: don't include empty snapshot slot slice
This PR fixes the snapshot storage serving handler. In snap protocol
the response is capped by the response size. Server can cutdown the
response if the accumulated byte size exceeds the local hard limit.
It means we can meet a special scenario that there is no storage slot
included for a requested account, but we attach the proof for this
account by mistake.
So in the prover side, when it meets a empty storage response but with
a valid proof proves there are some more slots left in the trie, then
requestor will reject this response and disconnect with server.
In this PR, if there is no storage slot served for the requested account,
then no proof should be attached as well.
* eth/protocols/snap: loosen restrictions for flaky tests
* eth/catalyst: fix flaky test in catalyst
2022-05-17 11:19:51 +03:00
Qian Bin
fe5a26733c
core/vm: reduce overhead in instructions-benchmark ( #24860 )
...
* core/vm: reduce footprint of OP benchmark
* core/vm: for opBenchmark, add code to detect inputs mutation
* Update core/vm/instructions_test.go
Co-authored-by: Martin Holst Swende <martin@swende.se>
* core/vm: opBenchmark, stop timer before sanity-test code
Co-authored-by: Martin Holst Swende <martin@swende.se>
2022-05-17 09:21:43 +02:00
Martin Holst Swende
af806168b6
cmd/geth: update vulnerabilities.json testdata ( #24856 )
2022-05-16 13:41:36 +02:00
Håvard Anda Estensen
07508ac0e9
all: replace uses of ioutil with io and os ( #24869 )
2022-05-16 11:59:35 +02:00
s7v7nislands
330e53fbb9
core/asm: use strings.Builder and fix godoc issues ( #24861 )
2022-05-16 11:39:07 +02:00
Péter Szilágyi
fcbc05ccb6
Merge pull request #24884 from karalabe/deprecate-rinkeby
...
cmd/utils: add deprecation warning for Rinkeby
2022-05-16 11:10:55 +03:00
Péter Szilágyi
0a55b9731c
cmd/utils: add deprecation warning for Rinkeby
2022-05-16 08:29:38 +03:00
Marius van der Wijden
4f80f7806e
params: set ropsten TTD for TheMerge ( #24876 )
2022-05-16 07:32:56 +03:00
Ryan Schneider
ae7d834bc7
internal/ethapi: add debug_getRawReceipts RPC method ( #24773 )
...
Adds a method to retrieve all the binary encoded receipts from a block
2022-05-14 22:33:41 +02:00
Sina Mahmoodi
440c9fcf75
graphql: fix long literal passed in a variable ( #24864 )
2022-05-12 21:10:08 +02:00
Qian Bin
e0a1fd5fdc
core/vm: optimize Memory.Set32 ( #24847 )
...
* core/vm: remove unnecessary memset for Memory.Set32
* core/vm: optimize Memory.Set32
2022-05-11 11:00:29 +02:00
Felipe Strozberg
f5ff022dbc
ethclient: add PeerCount method ( #24849 )
...
* adding peer count function
* Update ethclient.go
Co-authored-by: Felix Lange <fjl@twurst.com>
2022-05-11 08:05:55 +03:00
s7v7nislands
539bbd6349
core/vm: separate opcode group for 0x20 range ( #24850 )
2022-05-11 08:04:16 +03:00
s7v7nislands
24c590cbec
core/vm: clean up some dead functions ( #24851 )
2022-05-11 08:03:35 +03:00
||= nil
8a008ee0e6
cmd/geth: print info banner for --dev mode ( #24759 )
...
Co-authored-by: nedifi <nedifi@users.noreply.github.com>
Co-authored-by: Felix Lange <fjl@twurst.com>
2022-05-11 00:29:22 +02:00
Martin Holst Swende
646503208e
eth/protocols/snap: sort trienode heal requests by path ( #24779 )
...
* sort snap trienode heal requests
* eth/protocols/snap: remove debug code
* eth/protocols/snap: simplify sort, generate pathsets later
* eth/protocols/snap: review concern
* eth/protocols/snap: renamings
* eth/protocols/snap: add comments in Merge
* eth/protocols/snap: remove variable 'last' in Merge
* eth/protocols/snap: fix lint flaws in test
Co-authored-by: Felix Lange <fjl@twurst.com>
2022-05-10 17:37:24 +03:00
aaronbuchwald
52eb87d87c
core/vm: update benchmark to use Errorf instead of Sprintf ( #24845 )
2022-05-10 17:26:48 +03:00
Martin Holst Swende
91751cbaa7
signer/fourbyte: remove offending signatures ( #24842 )
2022-05-10 13:54:11 +02:00
Sina Mahmoodi
5b46f1d1eb
internal: drop TestSignCliqueBlock ( #24837 )
2022-05-10 10:46:26 +02:00
s7v7nislands
7caa2d8163
all: replace strings.Replace with string.ReplaceAll ( #24835 )
2022-05-09 13:13:23 +03:00
Marius van der Wijden
86d5477079
core/state/snapshot: fix race condition ( #24685 )
...
Fixes three race conditions found through fuzzing by David Theodore
2022-05-06 17:20:41 +02:00
Rachel Franks
345b1fb827
abi: fix checks when all fields are indexed ( #24792 )
...
This PR fixes abi checks in the edge case where all arguments are indexed
2022-05-06 16:45:57 +02:00
Martin Holst Swende
1b26991bec
signer/fourbyte: import new signatures ( #22865 )
2022-05-06 16:12:06 +02:00
Martin Holst Swende
7175f82495
eth/fetcher: avoid hang in tests (partial fix for #23331 ) ( #23351 )
...
* eth/fetcher: fix test to avoid hanging. Partial fix for #23331
* eth/filters: avoid dangling goroutines
* eth/fetcher: revert closing of proceed
2022-05-06 15:23:43 +02:00
Alex Beregszaszi
3b967d16ca
core/vm: implement EIP-3855: PUSH0 instruction ( #24039 )
...
* core/vm: Implement PUSH0
* Move PUSH0 to enable3855
* Add method doc
2022-05-06 14:36:45 +02:00
rjl493456442
1941c5e6c9
core/rawdb: untie freezer and ancient chain data ( #24684 )
...
Previously freezer has only been used for storing ancient chain data, while obviously it can be used more. This PR unties the chain data and freezer, keep the minimal freezer structure and move all other logic (like incrementally freezing block data) into a separate structure called ChainFreezer.
This PR also extends the database interface by adding a new ancient store function AncientDatadir which can return the root directory of ancient store. The ancient root directory can be used when we want to open some other ancient-stores (e.g. reverse diff freezer).
2022-05-06 13:28:42 +02:00
Mateusz Morusiewicz
cef1a86df2
miner: discard interrupted blocks ( #24638 )
...
During mining, when a new head arrives and interrupts the block building, the block being built should not be commited (but discarded). Committing the interrupted block introduces unnecessary delay, and possibly causes miner to mine on the previous head, which could result in higher uncle rate.
2022-05-06 11:19:30 +02:00
Ikko Ashimine
33d7a469f6
p2p/simulations: fix typo in network_test.go ( #24824 )
2022-05-05 20:20:11 +02:00
ImanSharaf
ca8e2f1ecf
p2p/simulations: escape mockerType value from request ( #24822 )
...
Co-authored-by: Felix Lange <fjl@twurst.com>
2022-05-05 19:44:36 +02:00
EXEC
256aae0bfa
eth/filters: remove explicit continue label in filterLogs ( #24795 )
...
The loop label can be removed because this 'continue' statement
is not in a nested loop.
2022-05-05 17:58:43 +02:00
s7v7nislands
1c90d97c1e
eth/protocols/eth: fix godoc comments ( #24810 )
...
Co-authored-by: Martin Holst Swende <martin@swende.se>
2022-05-05 17:35:36 +02:00
rjl493456442
7f6f01d46f
core: recover state when beacon sets canonical head if it's missing ( #24613 )
...
* core: recover the state in SetChainHead if the head state is missing
* core: disable test logging
* core: address comment from martin
* core: improve log level in case state is recovered
* core, eth, les, light: rename SetChainHead to SetCanonical
2022-05-05 10:36:26 +03:00
milesvant
11b56ace2a
core: fix WriteBlockAndSetHead documentation ( #24818 )
2022-05-05 10:22:00 +03:00
Péter Szilágyi
992151fa6d
Merge pull request #24817 from karalabe/fix-PC-regression
...
cmd, eth: fix required blocks regression
2022-05-05 10:02:41 +03:00
Péter Szilágyi
ecae8e4f65
cmd, eth: fix required blocks regression
2022-05-04 19:55:17 +03:00
Péter Szilágyi
0a9e384cd5
Merge pull request #24813 from holiman/jammy
...
build: ppa build for jammy (ubuntu 22.04)
2022-05-04 18:22:37 +03:00
Sina Mahmoodi
b3af0a5538
cmd/geth: fix init genesis for dev ( #24693 )
...
* cmd/geth: fix init genesis for dev
* use ancient flag for init genesis cmd
2022-05-04 16:14:14 +02:00
EXEC
d6b77f661c
eth/filters: fix code comment ( #24799 )
2022-05-04 15:32:51 +02:00
Sina Mahmoodi
d73df893a6
graphql: add rawReceipt field to transaction type ( #24738 )
...
* graphql: add tx receiptsRLP field
* use MarshalBinary
Co-authored-by: Ryan Schneider <ryanleeschneider@gmail.com>
* update schema
Co-authored-by: Ryan Schneider <ryanleeschneider@gmail.com>
* rename to rawReceipt
* indent fix
Co-authored-by: Ryan Schneider <ryanleeschneider@gmail.com>
2022-05-04 14:31:07 +02:00
Martin Holst Swende
c164aed1d1
build: ppa build for jammy (ubuntu 22.04)
2022-05-04 11:41:24 +02:00
Evgeny Kolyakov
8d84a701a5
build: fix formatted logs ( #24807 )
...
Changed `log.Fatal` to `log.Fatalf()` as it has a parameter...
2022-05-04 00:37:37 +03:00
Martin Holst Swende
53304ff6c7
cmd/utils: double limit on free-disk monitor ( #24781 )
...
This PR doubles the limit on which to trigger automatic shutdown, and also changes the timer to run once every 30s instead of 60s.
2022-05-03 12:12:40 +02:00
EXEC
6b60d68344
docker: speed up docker image build ( #24796 )
...
This PR improves the docker build speed for repeated builds where go.mod and go.sum do no change, by placing the downloaded dependencies in a lower layer
2022-05-03 11:17:24 +02:00
nujabes403
c153bd40d7
accounts: fix typo in comments ( #24805 )
2022-05-03 08:49:41 +02:00
rjl493456442
344d6f95cf
cmd: group network and db path flags together ( #24698 )
...
This PR groups all built-in network flags together and list them in the command as a whole.
And all database path flags(datadir, ancient) are also grouped, since usually these two are
used together.
2022-05-03 08:46:17 +02:00
