cerc-io/plugeth-statediff
15
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

49: Use a Personal Access Token to access private modules. #4

Merged
roysc merged 6 commits from telackey/49b into wip 2023-07-07 04:36:32 +00:00
Conversation 0 Commits 6 Files Changed 1 +5 -8
telackey commented 2023-07-06 19:55:17 +00:00
Member
Copy Link

I left it unchanged in the PR, but I would recommend a variable name other than GITEA_TOKEN, as I suspect that will be used by Gitea at some future date--like Github use GITHUB_TOKEN--and cause confusion since this is not the same token.

Something like GIT_VDB_TO_TOKEN might do, since we could follow the HOST_NAME_TOKEN pattern for other repos if needed.

I left it unchanged in the PR, but I would recommend a variable name other than `GITEA_TOKEN`, as I suspect that will be used by Gitea at some future date--like Github use `GITHUB_TOKEN`--and cause confusion since this is not the same token. Something like `GIT_VDB_TO_TOKEN` might do, since we could follow the `HOST_NAME_TOKEN` pattern for other repos if needed.
telackey added 1 commit 2023-07-06 19:55:19 +00:00
49: Use a Personal Access Token to access private modulees.
Some checks failed
Test / Run unit tests (pull_request) Failing after 47s
Details
Test / Run integration tests (pull_request) Failing after 21s
Details
252a4015c4
telackey changed title from 49: Use a Personal Access Token to access private modulees. to 49: Use a Personal Access Token to access private modules. 2023-07-06 19:55:25 +00:00
telackey added 1 commit 2023-07-06 20:05:17 +00:00
Normalize var name.
Some checks failed
Test / Run unit tests (pull_request) Failing after 46s
Details
Test / Run integration tests (pull_request) Failing after 20s
Details
0e3a61c630
telackey added 1 commit 2023-07-06 20:05:58 +00:00
Restore comment
Some checks failed
Test / Run unit tests (pull_request) Failing after 51s
Details
Test / Run integration tests (pull_request) Failing after 20s
Details
539f2a5586
telackey added 1 commit 2023-07-06 20:07:42 +00:00
Minimize changes.
Some checks failed
Test / Run unit tests (pull_request) Failing after 52s
Details
Test / Run integration tests (pull_request) Failing after 20s
Details
eae5689af2
telackey added 1 commit 2023-07-06 20:08:25 +00:00
Minimize changes.
Some checks failed
Test / Run unit tests (pull_request) Failing after 53s
Details
Test / Run integration tests (pull_request) Failing after 25s
Details
f0750e32fb
telackey added 1 commit 2023-07-06 20:32:29 +00:00
Simplify slightly.
Some checks failed
Test / Run unit tests (pull_request) Failing after 46s
Details
Test / Run integration tests (pull_request) Failing after 22s
Details
0b9b571ec9
roysc approved these changes 2023-07-07 04:32:12 +00:00
roysc left a comment
Member
Copy Link

LGTM, much simpler

LGTM, much simpler
roysc merged commit 2bd312f0d0 into wip 2023-07-07 04:36:32 +00:00
roysc deleted branch telackey/49b 2023-07-07 04:36:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
roysc
Labels
Clear labels
  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/plugeth-statediff#4
No description provided.
Delete Branch "telackey/49b"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?