cerc-io/plugeth-statediff
16
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Concurrent statediff iteration #12

Merged
roysc merged 14 commits from use-concurrent-iterator into main 2023-09-22 08:44:38 +00:00
Conversation 2 Commits 14 Files Changed 18 +216 -188
roysc commented 2023-08-03 10:54:46 +00:00
Member
Copy Link

Uses subtrie iterators to concurrently process the state trie.

Note that this builds on #11

Uses subtrie iterators to concurrently process the state trie. Note that this builds on https://git.vdb.to/cerc-io/plugeth-statediff/pulls/11
roysc added 11 commits 2023-08-03 10:54:48 +00:00 
- Remove unused bits
- simplify and normalize test data
- Renames for clarity
consolidate, simplify
Some checks failed
Test / Run unit tests (pull_request) Failing after 4s
Details
Test / Run integration tests (pull_request) Failing after 5s
Details
06723ee4e0
iterator fixes
Some checks failed
Test / Run unit tests (pull_request) Failing after 10s
Details
Test / Run integration tests (pull_request) Failing after 10s
Details
99ac6bb9ae
builder cleanup
Some checks failed
Test / Run unit tests (pull_request) Failing after 7s
Details
Test / Run integration tests (pull_request) Failing after 8s
Details
a11d68c38d
use concurrent iterators
Some checks failed
Test / Run unit tests (pull_request) Failing after 8s
Details
Test / Run integration tests (pull_request) Failing after 7s
Details
d5634c937a
roysc added 1 commit 2023-08-03 14:16:26 +00:00
go mod update & tidy
Some checks failed
Test / Run unit tests (pull_request) Failing after 9s
Details
Test / Run integration tests (pull_request) Failing after 8s
Details
d61945fd3b
roysc changed title from WIP: Concurrent statediff iteration to Concurrent statediff iteration 2023-08-03 14:30:41 +00:00
roysc force-pushed use-concurrent-iterator from d61945fd3b to 35e3a38555 2023-08-03 18:04:09 +00:00 Compare
roysc requested review from i-norden 2023-09-01 20:55:58 +00:00
telackey requested review from telackey 2023-09-06 21:25:13 +00:00
telackey commented 2023-09-15 20:56:08 +00:00
Member
Copy Link

This looks good to me, provided we have the sort of comparison tests we mentioned in #11 so that we can be confident we are producing the output we expect.

This looks good to me, provided we have the sort of comparison tests we mentioned in #11 so that we can be confident we are producing the output we expect.
roysc force-pushed use-concurrent-iterator from 35e3a38555 to 00fbebb4b3 2023-09-20 13:19:39 +00:00 Compare
roysc added 1 commit 2023-09-21 10:30:07 +00:00
downgrade deps to match plugeth
All checks were successful
Test / Run unit tests (pull_request) Successful in 15m48s
Details
Test / Run integration tests (pull_request) Successful in 30m25s
Details
3da03c4088
roysc commented 2023-09-22 08:42:58 +00:00
Author
Member
Copy Link

I wrote a tool to compare full statediff output by CID and verified the output against the original geth code: cerc-io/eth-statediff-compliance#2

I wrote a tool to compare full statediff output by CID and verified the output against the original geth code: https://git.vdb.to/cerc-io/eth-statediff-compliance/pulls/2
roysc merged commit 82131564ca into main 2023-09-22 08:44:38 +00:00
roysc deleted branch use-concurrent-iterator 2023-09-22 08:44:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
i-norden
telackey
Labels
Clear labels
  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/plugeth-statediff#12
No description provided.
Delete Branch "use-concurrent-iterator"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?