cerc-io/plugeth-statediff
11
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Concurrent statediff iteration #12

Merged
roysc merged 14 commits from use-concurrent-iterator into main 2023-09-22 08:44:38 +00:00
Conversation 2 Commits 14 Files Changed 18
+216 -188
roysc commented 2023-08-03 10:54:46 +00:00
Owner
Copy Link
Copy Source

Uses subtrie iterators to concurrently process the state trie.

Note that this builds on #11

Uses subtrie iterators to concurrently process the state trie. Note that this builds on https://git.vdb.to/cerc-io/plugeth-statediff/pulls/11
roysc added 11 commits 2023-08-03 10:54:48 +00:00
update deps b49c61d9e4
update plugeth 2907882c1a
Builder clean up 6b1f676c60 
- Remove unused bits
- simplify and normalize test data
- Renames for clarity
Implement symmetric difference iterator a7d7ea6d7a
symmetric diff iterator: detect common paths 3c544d4388
use symmetric difference iterator 2ebd0421e2
consolidate, simplify
Test / Run unit tests (pull_request) Failing after 4s
Details
Test / Run integration tests (pull_request) Failing after 5s
Details
06723ee4e0
iterator fixes
Test / Run unit tests (pull_request) Failing after 10s
Details
Test / Run integration tests (pull_request) Failing after 10s
Details
99ac6bb9ae
builder test 84def829e6
builder cleanup
Test / Run unit tests (pull_request) Failing after 7s
Details
Test / Run integration tests (pull_request) Failing after 8s
Details
a11d68c38d
use concurrent iterators
Test / Run unit tests (pull_request) Failing after 8s
Details
Test / Run integration tests (pull_request) Failing after 7s
Details
d5634c937a
roysc added 1 commit 2023-08-03 14:16:26 +00:00
go mod update & tidy
Test / Run unit tests (pull_request) Failing after 9s
Details
Test / Run integration tests (pull_request) Failing after 8s
Details
d61945fd3b
roysc marked the pull request as ready for review 2023-08-03 14:30:41 +00:00
roysc force-pushed use-concurrent-iterator from d61945fd3b to 35e3a38555 2023-08-03 18:04:09 +00:00 Compare
roysc requested review from i-norden 2023-09-01 20:55:58 +00:00
telackey requested review from telackey 2023-09-06 21:25:13 +00:00
telackey commented 2023-09-15 20:56:08 +00:00
Contributor
Copy Link
Copy Source

This looks good to me, provided we have the sort of comparison tests we mentioned in #11 so that we can be confident we are producing the output we expect.

This looks good to me, provided we have the sort of comparison tests we mentioned in #11 so that we can be confident we are producing the output we expect.
roysc force-pushed use-concurrent-iterator from 35e3a38555 to 00fbebb4b3 2023-09-20 13:19:39 +00:00 Compare
roysc added 1 commit 2023-09-21 10:30:07 +00:00
downgrade deps to match plugeth
Test / Run unit tests (pull_request) Successful in 15m48s
Details
Test / Run integration tests (pull_request) Successful in 30m25s
Details
3da03c4088
roysc commented 2023-09-22 08:42:58 +00:00
Author
Owner
Copy Link
Copy Source

I wrote a tool to compare full statediff output by CID and verified the output against the original geth code: cerc-io/eth-statediff-compliance#2

I wrote a tool to compare full statediff output by CID and verified the output against the original geth code: https://git.vdb.to/cerc-io/eth-statediff-compliance/pulls/2
roysc merged commit 82131564ca into main 2023-09-22 08:44:38 +00:00
roysc deleted branch use-concurrent-iterator 2023-09-22 08:44:38 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
telackey
Labels
Clear labels
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex cerccicd ericlewis i-norden (Ian Norden) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/plugeth-statediff#12