49: Use a Personal Access Token to access private modules. #4

Merged

roysc merged 6 commits from telackey/49b into wip 2023-07-07 04:36:32 +00:00

Conversation 1 Commits 6 Files Changed 1

+5 -8

telackey commented 2023-07-06 19:55:17 +00:00

Contributor

Copy Link

Copy Source

I left it unchanged in the PR, but I would recommend a variable name other than GITEA_TOKEN, as I suspect that will be used by Gitea at some future date--like Github use GITHUB_TOKEN--and cause confusion since this is not the same token.

Something like GIT_VDB_TO_TOKEN might do, since we could follow the HOST_NAME_TOKEN pattern for other repos if needed.

I left it unchanged in the PR, but I would recommend a variable name other than `GITEA_TOKEN`, as I suspect that will be used by Gitea at some future date--like Github use `GITHUB_TOKEN`--and cause confusion since this is not the same token. Something like `GIT_VDB_TO_TOKEN` might do, since we could follow the `HOST_NAME_TOKEN` pattern for other repos if needed.

telackey added 1 commit 2023-07-06 19:55:19 +00:00

49: Use a Personal Access Token to access private modulees. 252a4015c4

telackey changed title from 49: Use a Personal Access Token to access private modulees. to 49: Use a Personal Access Token to access private modules. 2023-07-06 19:55:25 +00:00

telackey added 1 commit 2023-07-06 20:05:17 +00:00

Normalize var name. 0e3a61c630

telackey added 1 commit 2023-07-06 20:05:58 +00:00

Restore comment 539f2a5586

telackey added 1 commit 2023-07-06 20:07:42 +00:00

Minimize changes. eae5689af2

telackey added 1 commit 2023-07-06 20:08:25 +00:00

Minimize changes. f0750e32fb

telackey added 1 commit 2023-07-06 20:32:29 +00:00

Simplify slightly. 0b9b571ec9

roysc approved these changes 2023-07-07 04:32:12 +00:00

roysc left a comment

Owner

Copy Link

Copy Source

LGTM, much simpler

LGTM, much simpler

roysc merged commit 2bd312f0d0 into wip 2023-07-07 04:36:32 +00:00

roysc referenced this issue from a commit 2023-07-07 04:36:32 +00:00

49: Use a Personal Access Token to access private modules. (#4)

roysc deleted branch telackey/49b 2023-07-07 04:36:32 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

roysc

Labels

Clear labels

Copied from Github

An issue or PR manually copied from GitHub.

Kind/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Reviewed

Confirmed

Issue has been confirmed

Reviewed

Duplicate

This issue or pull request already exists

Reviewed

Invalid

Invalid issue

Reviewed

Won't Fix

This issue won't be fixed

Status

Abandoned

Somebody has started to work on this but abandoned work

Status

Blocked

Something is blocking this issue or pull request

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

AFDudley Alex cerccicd ericlewis i-norden (Ian Norden) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/plugeth-statediff#4