cerc-io/plugeth-statediff
11
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Register service lifecycles #20

New Issue
Open
opened 2023-10-06 07:23:47 +00:00 by roysc · 0 comments
roysc commented 2023-10-06 07:23:47 +00:00
Owner
Copy Link
Copy Source

Plugeth doesn't expose a way to register Geth service lifecycles. We just Start the service when the plugin loads, but shutdown will potentially not be handled cleanly.

It should be easy enough to patch Plugeth to register this alongside API registration.

Plugeth doesn't expose a way to register Geth [service lifecycles](https://github.com/ethereum/go-ethereum/blob/052355f5e2b1726552fdb38a94cf6ea1506caf95/node/lifecycle.go#L23). We just `Start` the service when the plugin loads, but shutdown will potentially not be handled cleanly. It should be easy enough to patch Plugeth to register this alongside API registration.
roysc added the Kind/Enhancement
Priority
Low
 labels 2023-10-06 07:23:47 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels Kind/Enhancement
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex cerccicd ericlewis i-norden (Ian Norden) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/plugeth-statediff#20