cerc-io/nitro-stack
10
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Bridge demo update #16

Open
rachmaninovquar wants to merge 1 commits from hotfix/demo-update into main
pull from: hotfix/demo-update
merge into: cerc-io:main
Conversation 0 Commits 1 Files Changed 1 +1 -1
rachmaninovquar commented 2025-11-04 17:20:30 +00:00
Member
Copy Link

I needed to change one line to get it to work

I needed to change one line to get it to work
rachmaninovquar added 1 commit 2025-11-04 17:20:31 +00:00
rachmaninovquar requested review from AFDudley 2025-11-04 17:21:05 +00:00
rachmaninovquar requested review from roysc 2025-11-04 17:21:05 +00:00
roysc reviewed 2025-11-05 16:05:25 +00:00
nitro-bridge-demo.md
@ -93,3 +93,3 @@
```bash
laconic-so --stack ~/cerc/nitro-stack/stack-orchestrator/stacks/nitro-node setup-repositories --git-ssh --pull
laconic-so --stack ~/cerc/nitro-stack/stack-orchestrator/stacks/nitro-contracts setup-repositories --git-ssh --pull
roysc commented 2025-11-05 16:05:25 +00:00
Owner
Copy Link

Seems like nitro-node should work since it has

containers:
  - cerc/go-nitro
  - cerc/nitro-client

while nitro-contracts only has nitro-client?

Seems like `nitro-node` should work since it has ```yaml containers: - cerc/go-nitro - cerc/nitro-client ``` while `nitro-contracts` only has `nitro-client`?
rachmaninovquar commented 2025-11-10 20:50:13 +00:00
Author
Member
Copy Link

This is what I'm seeing:

root@ubuntu-s-4vcpu-16gb-amd-nyc3-01:~# laconic-so --stack ~/cerc/nitro-stack/stack-orchestrator/stacks/nitro-node setup-repositories --git-ssh --pull
Dev Root is: /root/cerc
ERROR: stack /root/cerc/nitro-stack/stack-orchestrator/stacks/nitro-node does not exist
This is what I'm seeing: ``` root@ubuntu-s-4vcpu-16gb-amd-nyc3-01:~# laconic-so --stack ~/cerc/nitro-stack/stack-orchestrator/stacks/nitro-node setup-repositories --git-ssh --pull Dev Root is: /root/cerc ERROR: stack /root/cerc/nitro-stack/stack-orchestrator/stacks/nitro-node does not exist ```
roysc commented 2025-11-11 09:31:03 +00:00
Owner
Copy Link

That's really odd. Are you sure the fetch-stack command succeeds and CERC_REPO_BASE_DIR is not set to a different location?

That's really odd. Are you sure the fetch-stack command succeeds and CERC_REPO_BASE_DIR is not set to a different location?
roysc reviewed 2025-11-05 16:06:24 +00:00
roysc left a comment
Owner
Copy Link

Haven't tested yet, but should double check this

Haven't tested yet, but should double check this
rachmaninovquar requested review from roysc 2025-11-06 14:05:09 +00:00
roysc requested changes 2025-11-07 06:46:22 +00:00
Dismissed
roysc left a comment
Owner
Copy Link

Could you add a workflow to test this?

Could you add a workflow to test this?
roysc approved these changes 2025-11-11 09:32:09 +00:00
roysc left a comment
Owner
Copy Link

Actually I see I was wrong about your change, because after this the go-node image is no longer built from source so the nitro-node stack doesn't need any repos, only nitro-contracts does. It would still be nice to have a CI test but this looks fine.

Actually I see I was wrong about your change, because after [this](https://git.vdb.to/cerc-io/nitro-stack/commit/ceae9fe8d449cada3f6ed0dc235402035d1d3c57) the `go-node` image is no longer built from source so the nitro-node stack doesn't need any repos, only nitro-contracts does. It would still be nice to have a CI test but this looks fine.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin hotfix/demo-update:hotfix/demo-update
git checkout hotfix/demo-update
Sign in to join this conversation.
Reviewers
No reviewers
AFDudley
roysc
Labels
Clear labels
  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/nitro-stack#16
No description provided.
Delete Branch "hotfix/demo-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?